From: "Du, Changbin" <changbin.du@intel.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: "Du, Changbin" <changbin.du@intel.com>,
Steven Rostedt <rostedt@goodmis.org>,
jolsa@redhat.com, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, kernel-team@lge.com
Subject: Re: [PATCH v3 0/3] tracing: Fix the parser when processing strings w/ or w/o terminated '\0'
Date: Wed, 17 Jan 2018 13:47:38 +0800 [thread overview]
Message-ID: <20180117054737.ap2jvg5jnfuth4ya@intel.com> (raw)
In-Reply-To: <20180117054524.GB7530@danjae.aot.lge.com>
On Wed, Jan 17, 2018 at 02:45:24PM +0900, Namhyung Kim wrote:
> Hello,
>
> On Wed, Jan 17, 2018 at 12:54:34PM +0800, Du, Changbin wrote:
> > On Tue, Jan 16, 2018 at 12:42:26PM -0500, Steven Rostedt wrote:
> > > On Tue, 16 Jan 2018 17:02:27 +0800
> > > changbin.du@intel.com wrote:
> > >
> > > > From: Changbin Du <changbin.du@intel.com>
> > > >
> > > > I found there are some problems in the tracing parser when I investiage the root
> > > > cause of issues mentioned in below patch.
> > > > https://patchwork.kernel.org/patch/10132953/
> > >
> > > I pulled in your patches and tweaked the change logs of the other two
> > > patches as well. You can see my temporary git tree here, but it may
> > > rebase.
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
> > >
> > > ftrace/core
> > >
> > > -- Steve
> > Got it. Thank you!
> >
> > Hi Olsa, so the perf patch 'perf ftrace: Fix the buffer size in__write_tracing_file'
> > is still needed. I will resend you at appropriate time.
>
> But it will work on the future kernels only, right? For tools to be
> compatible with old kernels, you'd better writing a whitespace after
> the function name IMHO.
>
Yes, it needs to write a space if it doesn't want possible error hidden.
> Thanks,
> Namhyung
--
Thanks,
Changbin Du
next prev parent reply other threads:[~2018-01-17 5:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 9:02 [PATCH v3 0/3] tracing: Fix the parser when processing strings w/ or w/o terminated '\0' changbin.du
2018-01-16 9:02 ` [PATCH v3 1/3] tracing: detect the string termination character when parsing user input string changbin.du
2018-01-16 9:02 ` [PATCH v3 2/3] tracing: clear parser->idx if parser gets nothing changbin.du
2018-01-16 9:02 ` [PATCH v3 3/3] tracing: make sure the parsed string always terminates with '\0' changbin.du
2018-01-16 17:42 ` [PATCH v3 0/3] tracing: Fix the parser when processing strings w/ or w/o terminated '\0' Steven Rostedt
2018-01-17 4:54 ` Du, Changbin
2018-01-17 5:45 ` Namhyung Kim
2018-01-17 5:47 ` Du, Changbin [this message]
2018-01-17 2:35 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117054737.ap2jvg5jnfuth4ya@intel.com \
--to=changbin.du@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).