From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hendrik Brueckner Subject: Re: [PATCH 3/5] perf util: Introduce architecture specific errno/name mapping Date: Wed, 17 Jan 2018 09:49:35 +0100 Message-ID: <20180117084935.GB4470@linux.vnet.ibm.com> References: <1516095991-16337-1-git-send-email-brueckner@linux.vnet.ibm.com> <1516095991-16337-4-git-send-email-brueckner@linux.vnet.ibm.com> <20180116135848.GC25687@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38616 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752539AbeAQItl (ORCPT ); Wed, 17 Jan 2018 03:49:41 -0500 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w0H8nBTi009146 for ; Wed, 17 Jan 2018 03:49:40 -0500 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0b-001b2d01.pphosted.com with ESMTP id 2fj13dngfe-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 17 Jan 2018 03:49:40 -0500 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 17 Jan 2018 08:49:38 -0000 Content-Disposition: inline In-Reply-To: <20180116135848.GC25687@kernel.org> Sender: linux-perf-users-owner@vger.kernel.org List-ID: To: Arnaldo Carvalho de Melo Cc: Hendrik Brueckner , Thomas-Mich Richter , Michael Petlan , Jiri Olsa , linux-perf-users@vger.kernel.org, linux-s390@vger.kernel.org, Arnaldo Carvalho de Melo On Tue, Jan 16, 2018 at 10:58:48AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 16, 2018 at 10:46:29AM +0100, Hendrik Brueckner escreveu: > > Introduce a script that generates a mapping of errno numbers to > > their names for each architecture that is supported by perf (i.e. > > has a subdirectory in tools/perf/arch/). > > > > The file is generated as util/errno-names.c. A corresponding > > header file util/errno-names.h is provided that defines the > > arch_errno_to_name() function. Use arch_errno_to_name() to > > lookup an errno value to obtain the errno name (e.g. ENOENT) > > for a particular architecture. > > > > This is to be used by perf trace. > > Ok, this is almost there, one nit I think needs to be fixed, instead of > generating it on $(OUTPUT)util/errno-names.c we can generate it here: > [...] > > I.e. all these are beautifier routines generated by shell scripts from > kernel header copies, so I think this new one, for errno, belongs there, > ok? At the moment, just perf trace use this interface. Hence, putting it to the trace beautifiers makes sense. Will update the patch accordingly and re-post a v2 of the patch again. Additional feedback is welcome... so I can decide whether to post the single patch or an updated series. Thanks and kind regards, Hendrik