From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnaldo Carvalho de Melo Subject: Re: [PATCH 3/5] perf util: Introduce architecture specific errno/name mapping Date: Thu, 18 Jan 2018 11:11:06 -0300 Message-ID: <20180118141105.GD18383@kernel.org> References: <1516095991-16337-1-git-send-email-brueckner@linux.vnet.ibm.com> <1516095991-16337-4-git-send-email-brueckner@linux.vnet.ibm.com> <20180118100733.GA18567@krava> <20180118104953.GA18383@kernel.org> <20180118113320.GC4600@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.kernel.org ([198.145.29.99]:57010 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756290AbeAROLJ (ORCPT ); Thu, 18 Jan 2018 09:11:09 -0500 Content-Disposition: inline In-Reply-To: <20180118113320.GC4600@linux.vnet.ibm.com> Sender: linux-perf-users-owner@vger.kernel.org List-ID: To: Hendrik Brueckner Cc: Jiri Olsa , Thomas-Mich Richter , Michael Petlan , linux-perf-users@vger.kernel.org, linux-s390@vger.kernel.org, Arnaldo Carvalho de Melo Em Thu, Jan 18, 2018 at 12:33:20PM +0100, Hendrik Brueckner escreveu: > On Thu, Jan 18, 2018 at 07:49:53AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Thu, Jan 18, 2018 at 11:07:33AM +0100, Jiri Olsa escreveu: > > > On Tue, Jan 16, 2018 at 10:46:29AM +0100, Hendrik Brueckner wrote: > > > > > > SNIP > > > > > > > index 12dec6e..90ce14f 100644 > > > > --- a/tools/perf/Makefile.config > > > > +++ b/tools/perf/Makefile.config > > > > @@ -249,7 +249,7 @@ INC_FLAGS += -I$(srctree)/tools/arch/$(SRCARCH)/include/uapi > > > > INC_FLAGS += -I$(srctree)/tools/arch/$(SRCARCH)/include/ > > > > INC_FLAGS += -I$(srctree)/tools/arch/$(SRCARCH)/ > > > > > > > > -# $(obj-perf) for generated common-cmds.h > > > > +# $(obj-perf) for generated common-cmds.h and errno-names.c > > > > # $(obj-perf)/util for generated bison/flex headers > > > > ifneq ($(OUTPUT),) > > > > INC_FLAGS += -I$(obj-perf)/util > > > > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > > > > index 9fdefd7..332b4b4 100644 > > > > --- a/tools/perf/Makefile.perf > > > > +++ b/tools/perf/Makefile.perf > > > > @@ -518,6 +518,9 @@ $(OUTPUT)common-cmds.h: util/generate-cmdlist.sh command-list.txt > > > > $(OUTPUT)common-cmds.h: $(wildcard Documentation/perf-*.txt) > > > > $(QUIET_GEN). util/generate-cmdlist.sh > $@+ && mv $@+ $@ > > > > > > > > +$(OUTPUT)util/errno-names.c: util/generate-errno-names.sh > > > > + $(QUIET_GEN). util/generate-errno-names.sh "$(CC)" "$(srctree)/tools" > $@+ && mv $@+ $@ > > > > > > so this generates errno-names.c with following code: > > > > > > const char *arch_errno_to_name(const char *arch, int err) > > > { > > > if (!strcmp(arch, "alpha")) > > > return errno_to_name__alpha(err); > > > if (!strcmp(arch, "arm")) > > > return errno_to_name__arm(err); > > > if (!strcmp(arch, "arm64")) > > > return errno_to_name__arm64(err); > > > > > > > > > is there a reason why we want all archs compiled in? > > > I'd think we just need the arch perf is built in > > > > think about: > > > > On an arm64 system: > > > > perf trace record -a sleep 1 > > > > scp that to an x86_64 system and do: > > > > perf trace -i perf.data > > > > But doing that strcmp per call seems excessive, perhaps we could have > > something like: > > > > trace->arch = arch_syscalls__init(arch_name); > > > > char *s = arch_syscalls__strerrno(trace->arch, err); > > > > Have to look at the code to find the right naming according to what we > > already have. > > Another idea to get rid of the strcmp's is to introduce an arch enum > and let normalize_arch() in util/env.c return an enum number and handle > the arch stuff then on the enum. Where necessary, the arch string can > be used. But for "internal" purposes, an enum would be better. Right, we can go on improving things, but I think that after you get the generated directory sorted out I'll apply your patches in the current form, and then we can go on improving things from there, ok? - Arnaldo