linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	Ilya Pronin <ipronin@twitter.com>,
	Andi Kleen <ak@linux.intel.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 7/9] perf stat: Fix CVS output format for non-supported counters
Date: Tue,  6 Mar 2018 14:23:41 -0300	[thread overview]
Message-ID: <20180306172343.16546-8-acme@kernel.org> (raw)
In-Reply-To: <20180306172343.16546-1-acme@kernel.org>

From: Ilya Pronin <ipronin@twitter.com>

When printing stats in CSV mode, 'perf stat' appends extra separators
when a counter is not supported:

<not supported>,,L1-dcache-store-misses,mesos/bd442f34-2b4a-47df-b966-9b281f9f56fc,0,100.00,,,,

Which causes a failure when parsing fields. The numbers of separators
should be the same for each line, no matter if the counter is or not
supported.

Signed-off-by: Ilya Pronin <ipronin@twitter.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <ak@linux.intel.com>
Link: http://lkml.kernel.org/r/20180306064353.31930-1-xiyou.wangcong@gmail.com
Fixes: 92a61f6412d3 ("perf stat: Implement CSV metrics output")
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-stat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 98bf9d32f222..54a4c152edb3 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -917,7 +917,7 @@ static void print_metric_csv(void *ctx,
 	char buf[64], *vals, *ends;
 
 	if (unit == NULL || fmt == NULL) {
-		fprintf(out, "%s%s%s%s", csv_sep, csv_sep, csv_sep, csv_sep);
+		fprintf(out, "%s%s", csv_sep, csv_sep);
 		return;
 	}
 	snprintf(buf, sizeof(buf), fmt, val);
-- 
2.14.3

  parent reply	other threads:[~2018-03-06 17:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 17:23 [GIT PULL 0/9] perf/urgent fixes Arnaldo Carvalho de Melo
2018-03-06 17:23 ` [PATCH 1/9] perf kallsyms: Fix the usage on the man page Arnaldo Carvalho de Melo
2018-03-06 17:23 ` [PATCH 2/9] perf top: Fix annoying fallback message on older kernels Arnaldo Carvalho de Melo
2018-03-06 17:23 ` [PATCH 3/9] perf annotate browser: Be more robust when drawing jump arrows Arnaldo Carvalho de Melo
2018-03-06 17:23 ` [PATCH 4/9] perf record: Fix crash in pipe mode Arnaldo Carvalho de Melo
2018-03-06 17:23 ` [PATCH 5/9] tools headers: Sync copy of kvm UAPI headers Arnaldo Carvalho de Melo
2018-03-06 17:23 ` [PATCH 6/9] tools headers: Sync x86's cpufeatures.h Arnaldo Carvalho de Melo
2018-03-06 17:23 ` Arnaldo Carvalho de Melo [this message]
2018-03-06 17:23 ` [PATCH 8/9] perf auxtrace: Prevent decoding when --no-itrace Arnaldo Carvalho de Melo
2018-03-06 17:23 ` [PATCH 9/9] perf tools: Fix trigger class trigger_on() Arnaldo Carvalho de Melo
2018-03-07  8:22 ` [GIT PULL 0/9] perf/urgent fixes Ingo Molnar
2018-03-07 14:23   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180306172343.16546-8-acme@kernel.org \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=ipronin@twitter.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).