From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnaldo Carvalho de Melo Subject: Re: [PATCH] perf tools arm64: Add libdw DWARF post unwind support for ARM64 Date: Fri, 9 Mar 2018 15:24:40 -0300 Message-ID: <20180309182440.GA25111@kernel.org> References: <20180226142726.cd413c792d0782f77b60a23e@arm.com> <20180226174040.6998bd3c0a79b2f19c491e4d@arm.com> <9B701F46-6AEA-48D8-9103-71D35C83776D@cisco.com> <20180308211030.4ee4a0d6ff6dc5cda1b567d4@arm.com> <20180309150627.GB8347@kernel.org> <20180309120720.9358515dbff3b1d1fdf70cc8@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180309120720.9358515dbff3b1d1fdf70cc8@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Kim Phillips , Jiri Olsa Cc: "Christian Hansen (chansen3)" , "linux-perf-users@vger.kernel.org" , Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-kernel@vger.kernel.org, Mathieu Poirier , "Vuille, Martin (Martin)" , Martin Vuille List-Id: linux-perf-users.vger.kernel.org Em Fri, Mar 09, 2018 at 12:07:20PM -0600, Kim Phillips escreveu: > On Fri, 9 Mar 2018 12:06:27 -0300 > Arnaldo Carvalho de Melo wrote: > > Hi Arnaldo, > > > Em Thu, Mar 08, 2018 at 09:10:30PM -0600, Kim Phillips escreveu: > > > Based on prior work: > > > > > > https://lkml.org/lkml/2014/5/6/395 > > > > Thanks, looks good, applying. > > > > Jean, is everything ok with you on this? > > By now your email to Jean should have bounced with "The email account > that you tried to reach does not exist." Removing Jean from Cc. > > It seems like you're applying patches. There are a couple that have > slipped through the cracks: Can you please take a look at applying them? > > - "perf tools: Fixing uninitialised variable" > https://patchwork.kernel.org/patch/10179381/ [acme@jouet perf]$ git tag --contains d2785de15f1bd42d613d56bbac5a007e7293b874 perf-core-for-mingo-4.17-20180216 commit d2785de15f1bd42d613d56bbac5a007e7293b874 Author: Mathieu Poirier AuthorDate: Mon Feb 12 13:32:37 2018 -0700 Commit: Arnaldo Carvalho de Melo CommitDate: Fri Feb 16 14:55:40 2018 -0300 perf auxtrace arm: Fixing uninitialised variable When working natively on arm64 the compiler gets pesky and complains that variable 'i' is uninitialised, something that breaks the compilation. Here no further checks are needed since variable 'found_spe' can only be true if variable 'i' has been initialised as part of the for loop. Signed-off-by: Mathieu Poirier Cc: Alexander Shishkin Cc: Jin Yao Cc: Namhyung Kim Cc: Peter Zijlstra Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/1518467557-18505-4-git-send-email-mathieu.poirier@linaro.org Signed-off-by: Arnaldo Carvalho de Melo diff --git a/tools/perf/arch/arm/util/auxtrace.c b/tools/perf/arch/arm/util/auxtrace.c index 2323581b157d..fa639e3e52ac 100644 --- a/tools/perf/arch/arm/util/auxtrace.c +++ b/tools/perf/arch/arm/util/auxtrace.c @@ -68,7 +68,7 @@ struct auxtrace_record bool found_spe = false; static struct perf_pmu **arm_spe_pmus = NULL; static int nr_spes = 0; - int i; + int i = 0; > - "perf unwind: Report error from dwfl_attach_state" > https://patchwork.kernel.org/patch/10211483/ > [Martin, I guess it would help if you replied-all that patch and > added your signed-off-by.] Right, the S-o-B is needed > - "perf unwind: Unwind with libdw doesn't take symfs into account" > https://patchwork.kernel.org/patch/10211599/ This one has the S-o-B, applying, Jiri, holler if you disagree, - Arnaldo > Thanks, > > Kim