linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: linxiulei@gmail.com
Cc: peterz@infradead.org, jolsa@redhat.com, mingo@redhat.com,
	acme@kernel.org, alexander.shishkin@linux.intel.com,
	linux-kernel@vger.kernel.org, tglx@linutronix.de,
	eranian@gmail.com, torvalds@linux-foundation.org,
	linux-perf-users@vger.kernel.org, brendan.d.gregg@gmail.com,
	yang_oliver@hotmail.com,
	"leilei.lin" <leilei.lin@alibaba-inc.com>
Subject: Re: [PATCH RESEND v5] perf/core: Fix installing arbitrary cgroup event into cpu
Date: Mon, 12 Mar 2018 08:53:07 +0100	[thread overview]
Message-ID: <20180312075307.iut52znscixqcpag@gmail.com> (raw)
In-Reply-To: <20180306093637.28247-1-linxiulei@gmail.com>


* linxiulei@gmail.com <linxiulei@gmail.com> wrote:

>  	/*
>  	 * Because cgroup events are always per-cpu events,
>  	 * this will always be called from the right CPU.
>  	 */

> +	/*
> +	 * if only the cgroup is running on this cpu
> +	 * and cpuctx->cgrp == NULL (otherwise it would've
> +	 * been set with running cgroup), we put this cgroup
> +	 * into cpu context. Or it would case mismatch in
> +	 * following cgroup events at event_filter_match()
> +	 */

Beyond making sure that what you comment on makes sense, please also follow 
existing comment style, which I quoted above.

There's 3 separate mistakes in that paragraph alone.

Thanks,

	Ingo

  parent reply	other threads:[~2018-03-12  7:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06  9:36 [PATCH RESEND v5] perf/core: Fix installing arbitrary cgroup event into cpu linxiulei
2018-03-06 11:50 ` Peter Zijlstra
2018-03-07 11:19   ` Lin Xiulei
2018-03-12 12:24     ` Peter Zijlstra
2018-03-12 13:10       ` Lin Xiulei
2018-03-12  7:53 ` Ingo Molnar [this message]
2018-03-12 11:46   ` Lin Xiulei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180312075307.iut52znscixqcpag@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=brendan.d.gregg@gmail.com \
    --cc=eranian@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=leilei.lin@alibaba-inc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linxiulei@gmail.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=yang_oliver@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).