* [PATCH RESEND] perf unwind: Report error from dwfl_attach_state
@ 2018-03-18 17:50 Martin Vuille
2018-03-20 0:06 ` Kim Phillips
0 siblings, 1 reply; 3+ messages in thread
From: Martin Vuille @ 2018-03-18 17:50 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: Martin Vuille, linux-perf-users, linux-kernel
In verbose level 2, errors returned by libdw are reported in most cases,
but not when calling dwfl_attach_state.
Since elfutils v 0.160 (2014), dwfl_attach_state sets the error code to
report failure cause. On failure, log the reported error.
Signed-off-by: Martin Vuille <jpmv27@aim.com>
---
tools/perf/util/unwind-libdw.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/unwind-libdw.c b/tools/perf/util/unwind-libdw.c
index 8e969f28cc59..7bdd239c795c 100644
--- a/tools/perf/util/unwind-libdw.c
+++ b/tools/perf/util/unwind-libdw.c
@@ -236,7 +236,8 @@ int unwind__get_entries(unwind_entry_cb_t cb, void *arg,
if (err)
goto out;
- if (!dwfl_attach_state(ui->dwfl, EM_NONE, thread->tid, &callbacks, ui))
+ err = !dwfl_attach_state(ui->dwfl, EM_NONE, thread->tid, &callbacks, ui);
+ if (err)
goto out;
err = dwfl_getthread_frames(ui->dwfl, thread->tid, frame_callback, ui);
--
2.13.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] perf unwind: Report error from dwfl_attach_state
2018-03-18 17:50 [PATCH RESEND] perf unwind: Report error from dwfl_attach_state Martin Vuille
@ 2018-03-20 0:06 ` Kim Phillips
2018-03-20 16:18 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Kim Phillips @ 2018-03-20 0:06 UTC (permalink / raw)
To: Martin Vuille; +Cc: Arnaldo Carvalho de Melo, linux-perf-users, linux-kernel
On Sun, 18 Mar 2018 13:50:53 -0400
Martin Vuille <jpmv27@aim.com> wrote:
> In verbose level 2, errors returned by libdw are reported in most cases,
> but not when calling dwfl_attach_state.
>
> Since elfutils v 0.160 (2014), dwfl_attach_state sets the error code to
> report failure cause. On failure, log the reported error.
>
> Signed-off-by: Martin Vuille <jpmv27@aim.com>
> ---
Reviewed-by: Kim Phillips <kim.phillips@arm.com>
Kim
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] perf unwind: Report error from dwfl_attach_state
2018-03-20 0:06 ` Kim Phillips
@ 2018-03-20 16:18 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-03-20 16:18 UTC (permalink / raw)
To: Kim Phillips
Cc: Martin Vuille, Arnaldo Carvalho de Melo, linux-perf-users,
linux-kernel
Em Tue, Mar 20, 2018 at 08:06:33AM +0800, Kim Phillips escreveu:
> On Sun, 18 Mar 2018 13:50:53 -0400
> Martin Vuille <jpmv27@aim.com> wrote:
>
> > In verbose level 2, errors returned by libdw are reported in most cases,
> > but not when calling dwfl_attach_state.
> >
> > Since elfutils v 0.160 (2014), dwfl_attach_state sets the error code to
> > report failure cause. On failure, log the reported error.
> >
> > Signed-off-by: Martin Vuille <jpmv27@aim.com>
> > ---
>
> Reviewed-by: Kim Phillips <kim.phillips@arm.com>
Thanks, applied.
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-20 16:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-18 17:50 [PATCH RESEND] perf unwind: Report error from dwfl_attach_state Martin Vuille
2018-03-20 0:06 ` Kim Phillips
2018-03-20 16:18 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).