linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Thomas Richter <tmricht@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	jolsa@redhat.com, brueckner@linux.vnet.ibm.com,
	schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com
Subject: Re: [PATCH 1/3] perf alias: Remove trailing newline when reading sysfs files
Date: Thu, 14 Jun 2018 11:05:29 -0300	[thread overview]
Message-ID: <20180614140528.GE30043@kernel.org> (raw)
In-Reply-To: <20180614114845.41221-1-tmricht@linux.ibm.com>

Em Thu, Jun 14, 2018 at 01:48:43PM +0200, Thomas Richter escreveu:
> Remove a trailing newline when reading sysfs file contents
<SNIP>
> +	/* Remove trailing newline from sysfs file */
> +	cp = strrchr(buf, '\n');
> +	if (cp)
> +		*cp = '\0';
> +

We have rtrim()

- Arnaldo

      parent reply	other threads:[~2018-06-14 14:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-14 11:48 [PATCH 1/3] perf alias: Remove trailing newline when reading sysfs files Thomas Richter
2018-06-14 11:48 ` [PATCH 2/3] perf alias: Rebuild alias expression string to make it comparable Thomas Richter
2018-06-14 13:53   ` Paul Clarke
2018-06-14 14:16     ` Thomas-Mich Richter
2018-06-15  8:12     ` Jiri Olsa
2018-06-15  9:09       ` Thomas-Mich Richter
2018-06-15  9:27         ` Jiri Olsa
2018-06-14 11:48 ` [PATCH 3/3] perf stat: Remove duplicate event counting Thomas Richter
2018-06-15  8:21   ` Jiri Olsa
2018-06-15  8:56     ` Thomas-Mich Richter
2018-06-19 15:17     ` Arnaldo Carvalho de Melo
2018-06-19 18:24       ` Jiri Olsa
2018-06-14 13:17 ` [PATCH 1/3] perf alias: Remove trailing newline when reading sysfs files Paul Clarke
2018-06-14 14:10   ` Thomas-Mich Richter
2018-06-15  9:10   ` David Laight
2018-06-14 14:05 ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180614140528.GE30043@kernel.org \
    --to=acme@kernel.org \
    --cc=brueckner@linux.vnet.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=tmricht@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).