linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Thomas Richter <tmricht@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com,
	heiko.carstens@de.ibm.com, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH 2/3 v2] perf alias: Rebuild alias expression string to make it comparable
Date: Tue, 19 Jun 2018 12:16:21 -0300	[thread overview]
Message-ID: <20180619151621.GI20477@kernel.org> (raw)
In-Reply-To: <20180615101105.47047-2-tmricht@linux.ibm.com>

Em Fri, Jun 15, 2018 at 12:11:04PM +0200, Thomas Richter escreveu:
> PMU alias definitions in sysfs files may have spaces, newlines
> and numbers with leading zeroes. Some alias definitions may
> also appear in JSON files without spaces, etc.
> 
> Scan alias definitions and remove leading zeroes, spaces,
> newlines, etc and rebuild string to make alias->str member
> comparable.
> 
> s390 for example  has terms specified as
> event=0x0091 (read from files ../<PMU>/events/<FILE>
> and terms specified as event=0x91 (read from JSON files).

Applying, I think Jiri agreed with this one in the v1 post, right?

- Arnaldo

  reply	other threads:[~2018-06-19 15:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-15 10:11 [PATCH 1/3 v2] perf alias: Remove trailing newline when reading sysfs files Thomas Richter
2018-06-15 10:11 ` [PATCH 2/3 v2] perf alias: Rebuild alias expression string to make it comparable Thomas Richter
2018-06-19 15:16   ` Arnaldo Carvalho de Melo [this message]
2018-06-15 10:11 ` [PATCH 3/3 v2] perf stat: Remove duplicate event counting Thomas Richter
2018-06-19 15:13 ` [PATCH 1/3 v2] perf alias: Remove trailing newline when reading sysfs files Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180619151621.GI20477@kernel.org \
    --to=acme@kernel.org \
    --cc=brueckner@linux.vnet.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=tmricht@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).