linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH RESEND] tools/perf: Add Hygon Dhyana support
@ 2018-11-12  7:40 Pu Wen
  2018-11-12 11:09 ` Borislav Petkov
  0 siblings, 1 reply; 3+ messages in thread
From: Pu Wen @ 2018-11-12  7:40 UTC (permalink / raw)
  To: peterz, mingo, acme, alexander.shishkin, jolsa, namhyung, tglx,
	bp
  Cc: linux-kernel, linux-perf-users, Pu Wen

The tool perf is useful for the performance analysis on the Hygon Dhyana
platform. But right now there is no Hygon support for it to analyze the
KVM guest os data. So add Hygon Dhyana support to it by checking vendor
string to share the code path of AMD.

Signed-off-by: Pu Wen <puwen@hygon.cn>
---
 tools/perf/arch/x86/util/kvm-stat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/arch/x86/util/kvm-stat.c b/tools/perf/arch/x86/util/kvm-stat.c
index b32409a..081353d 100644
--- a/tools/perf/arch/x86/util/kvm-stat.c
+++ b/tools/perf/arch/x86/util/kvm-stat.c
@@ -156,7 +156,7 @@ int cpu_isa_init(struct perf_kvm_stat *kvm, const char *cpuid)
 	if (strstr(cpuid, "Intel")) {
 		kvm->exit_reasons = vmx_exit_reasons;
 		kvm->exit_reasons_isa = "VMX";
-	} else if (strstr(cpuid, "AMD")) {
+	} else if (strstr(cpuid, "AMD") || strstr(cpuid, "Hygon")) {
 		kvm->exit_reasons = svm_exit_reasons;
 		kvm->exit_reasons_isa = "SVM";
 	} else
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [RFC PATCH RESEND] tools/perf: Add Hygon Dhyana support
  2018-11-12  7:40 [RFC PATCH RESEND] tools/perf: Add Hygon Dhyana support Pu Wen
@ 2018-11-12 11:09 ` Borislav Petkov
  2018-11-12 16:30   ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 3+ messages in thread
From: Borislav Petkov @ 2018-11-12 11:09 UTC (permalink / raw)
  To: Pu Wen, acme
  Cc: peterz, mingo, alexander.shishkin, jolsa, namhyung, tglx,
	linux-kernel, linux-perf-users

On Mon, Nov 12, 2018 at 03:40:51PM +0800, Pu Wen wrote:
> The tool perf is useful for the performance analysis on the Hygon Dhyana
> platform. But right now there is no Hygon support for it to analyze the
> KVM guest os data. So add Hygon Dhyana support to it by checking vendor

acme, pls fix that to "OS" when applying. Thx.

> string to share the code path of AMD.
> 
> Signed-off-by: Pu Wen <puwen@hygon.cn>
> ---
>  tools/perf/arch/x86/util/kvm-stat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Borislav Petkov <bp@suse.de>

> diff --git a/tools/perf/arch/x86/util/kvm-stat.c b/tools/perf/arch/x86/util/kvm-stat.c
> index b32409a..081353d 100644
> --- a/tools/perf/arch/x86/util/kvm-stat.c
> +++ b/tools/perf/arch/x86/util/kvm-stat.c
> @@ -156,7 +156,7 @@ int cpu_isa_init(struct perf_kvm_stat *kvm, const char *cpuid)
>  	if (strstr(cpuid, "Intel")) {
>  		kvm->exit_reasons = vmx_exit_reasons;
>  		kvm->exit_reasons_isa = "VMX";
> -	} else if (strstr(cpuid, "AMD")) {
> +	} else if (strstr(cpuid, "AMD") || strstr(cpuid, "Hygon")) {
>  		kvm->exit_reasons = svm_exit_reasons;
>  		kvm->exit_reasons_isa = "SVM";
>  	} else
> -- 
> 2.7.4
> 

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFC PATCH RESEND] tools/perf: Add Hygon Dhyana support
  2018-11-12 11:09 ` Borislav Petkov
@ 2018-11-12 16:30   ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-11-12 16:30 UTC (permalink / raw)
  To: Borislav Petkov
  Cc: Pu Wen, peterz, mingo, alexander.shishkin, jolsa, namhyung, tglx,
	linux-kernel, linux-perf-users

Em Mon, Nov 12, 2018 at 12:09:23PM +0100, Borislav Petkov escreveu:
> On Mon, Nov 12, 2018 at 03:40:51PM +0800, Pu Wen wrote:
> > The tool perf is useful for the performance analysis on the Hygon Dhyana
> > platform. But right now there is no Hygon support for it to analyze the
> > KVM guest os data. So add Hygon Dhyana support to it by checking vendor
> 
> acme, pls fix that to "OS" when applying. Thx.
> 
> > string to share the code path of AMD.
> > 
> > Signed-off-by: Pu Wen <puwen@hygon.cn>
> > ---
> >  tools/perf/arch/x86/util/kvm-stat.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Acked-by: Borislav Petkov <bp@suse.de>

Thanks, applied.

- Arnaldo
 
> > diff --git a/tools/perf/arch/x86/util/kvm-stat.c b/tools/perf/arch/x86/util/kvm-stat.c
> > index b32409a..081353d 100644
> > --- a/tools/perf/arch/x86/util/kvm-stat.c
> > +++ b/tools/perf/arch/x86/util/kvm-stat.c
> > @@ -156,7 +156,7 @@ int cpu_isa_init(struct perf_kvm_stat *kvm, const char *cpuid)
> >  	if (strstr(cpuid, "Intel")) {
> >  		kvm->exit_reasons = vmx_exit_reasons;
> >  		kvm->exit_reasons_isa = "VMX";
> > -	} else if (strstr(cpuid, "AMD")) {
> > +	} else if (strstr(cpuid, "AMD") || strstr(cpuid, "Hygon")) {
> >  		kvm->exit_reasons = svm_exit_reasons;
> >  		kvm->exit_reasons_isa = "SVM";
> >  	} else
> > -- 
> > 2.7.4
> > 
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> Good mailing practices for 400: avoid top-posting and trim the reply.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-12 16:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-12  7:40 [RFC PATCH RESEND] tools/perf: Add Hygon Dhyana support Pu Wen
2018-11-12 11:09 ` Borislav Petkov
2018-11-12 16:30   ` Arnaldo Carvalho de Melo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).