From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, tools: Support srccode output
Date: Wed, 5 Dec 2018 13:28:38 +0100 [thread overview]
Message-ID: <20181205122838.GH2950@krava> (raw)
In-Reply-To: <20181204001848.24769-1-andi@firstfloor.org>
On Mon, Dec 03, 2018 at 04:18:48PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> When looking at PT or brstackinsn traces with perf script
> it can be very useful to see the source code. This adds a simple
> facility to print them with perf script, if the information
> is available through dwarf
>
> % perf record ...
> % perf script -F insn,ip,sym,srccode
> ...
>
> 4004c6 main
> 5 for (i = 0; i < 10000000; i++)
> 4004cd main
> 5 for (i = 0; i < 10000000; i++)
> 4004c6 main
> 5 for (i = 0; i < 10000000; i++)
> 4004cd main
> 5 for (i = 0; i < 10000000; i++)
> 4004cd main
> 5 for (i = 0; i < 10000000; i++)
> 4004cd main
> 5 for (i = 0; i < 10000000; i++)
> 4004cd main
> 5 for (i = 0; i < 10000000; i++)
> 4004cd main
> 5 for (i = 0; i < 10000000; i++)
> 4004b3 main
> 6 v++;
>
> % perf record -b ...
> % perf script -F insn,ip,sym,srccode,brstackinsn
>
> ...
> main+22:
> 0000000000400543 insn: e8 ca ff ff ff # PRED
> |18 f1();
> f1:
> 0000000000400512 insn: 55
> |10 {
> 0000000000400513 insn: 48 89 e5
> 0000000000400516 insn: b8 00 00 00 00
> |11 f2();
> 000000000040051b insn: e8 d6 ff ff ff # PRED
> f2:
> 00000000004004f6 insn: 55
> |5 {
> 00000000004004f7 insn: 48 89 e5
> 00000000004004fa insn: 8b 05 2c 0b 20 00
> |6 c = a / b;
> 0000000000400500 insn: 8b 0d 2a 0b 20 00
> 0000000000400506 insn: 99
> 0000000000400507 insn: f7 f9
> 0000000000400509 insn: 89 05 29 0b 20 00
> 000000000040050f insn: 90
> |7 }
> 0000000000400510 insn: 5d
> 0000000000400511 insn: c3 # PRED
> f1+14:
> 0000000000400520 insn: b8 00 00 00 00
> |12 f2();
> 0000000000400525 insn: e8 cc ff ff ff # PRED
> f2:
> 00000000004004f6 insn: 55
> |5 {
> 00000000004004f7 insn: 48 89 e5
> 00000000004004fa insn: 8b 05 2c 0b 20 00
> |6 c = a / b;
>
> Not supported for callchains currently, would need some
> layout changes there.
nice, works nicely, especialy with --xed
Acked-by: Jiri Olsa <jolsa@kernel.org>
I need to check, but is there a way to make this work with
perf-with-kcore script? looks like we endup with kcore and
won't allow vmlinux lookups for debug info
thanks,
jirka
next prev parent reply other threads:[~2018-12-05 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 0:18 [PATCH] perf, tools: Support srccode output Andi Kleen
2018-12-05 12:28 ` Jiri Olsa [this message]
2018-12-05 16:54 ` Arnaldo Carvalho de Melo
2018-12-05 17:05 ` Jiri Olsa
2018-12-05 17:33 ` Andi Kleen
2018-12-05 22:15 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205122838.GH2950@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).