From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
lkml <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
linux-perf-users@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
eranian@google.com, vincent.weaver@maine.edu,
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Subject: Re: System crash with perf_fuzzer (kernel: 5.0.0-rc3)
Date: Wed, 30 Jan 2019 23:33:08 +0100 [thread overview]
Message-ID: <20190130223308.GA8145@krava> (raw)
In-Reply-To: <87zhrhzxpo.fsf@linux.intel.com>
On Wed, Jan 30, 2019 at 12:39:47PM -0800, Andi Kleen wrote:
> Jiri Olsa <jolsa@redhat.com> writes:
> >
> > the patch adds check_eriod pmu callback.. I need to check if there's
> > better way to do this, but so far it fixes the crash for me
> >
> > if you guys could check this patch, that'd be great
>
> There's already a limit_period callback, perhaps that could
> be extended. But ok, can do it this way too.
right, we call it within x86_perf_event_set_period to limit
the period, but I guess we should include this check after
changing the period:
if (event->attr.sample_period && x86_pmu.limit_period) {
if (x86_pmu.limit_period(event, event->attr.sample_period) >
event->attr.sample_period)
return -EINVAL;
}
>
> I suspect there are some other cases that need this callback, not
> just BTS, e.g. the checks in hsw_hw_config
ok, the sample_period values for checkpointed events,
we should check for this as well.. I'll add that
jirka
next prev parent reply other threads:[~2019-01-30 22:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 6:46 System crash with perf_fuzzer (kernel: 5.0.0-rc3) Ravi Bangoria
2019-01-25 15:11 ` Vince Weaver
2019-01-25 16:00 ` Andi Kleen
2019-01-31 7:58 ` Ravi Bangoria
2019-01-31 13:00 ` Andi Kleen
2019-01-31 20:27 ` Cong Wang
2019-01-31 20:39 ` Andi Kleen
2019-03-06 23:09 ` Pavel Machek
2019-01-30 18:36 ` Jiri Olsa
2019-01-30 20:39 ` Andi Kleen
2019-01-30 22:33 ` Jiri Olsa [this message]
2019-01-31 7:36 ` Jiri Olsa
2019-01-31 8:27 ` Jiri Olsa
2019-02-01 7:43 ` Jiri Olsa
2019-02-01 7:54 ` Ravi Bangoria
2019-02-02 3:24 ` Ravi Bangoria
2019-02-02 10:34 ` Jiri Olsa
2019-02-01 16:27 ` Vince Weaver
2019-02-01 17:38 ` Jiri Olsa
2019-02-02 17:58 ` Vince Weaver
2019-02-04 12:35 ` [PATCH] perf: Add check_period pmu callback Jiri Olsa
2019-02-11 10:11 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130223308.GA8145@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).