From: Jiri Olsa <jolsa@redhat.com>
To: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
Cc: linux-perf-users@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <ak@linux.intel.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Stephane Eranian <eranian@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: fix HEADER_CMDLINE description in perf.data documentation
Date: Tue, 19 Feb 2019 15:04:09 +0100 [thread overview]
Message-ID: <20190219140409.GD6435@krava> (raw)
In-Reply-To: <20190218140203.1982-1-jonas.rabenstein@studium.uni-erlangen.de>
On Mon, Feb 18, 2019 at 03:02:03PM +0100, Jonas Rabenstein wrote:
> The content of this feature header is a perf_header_string_list of
> the argument vector and not a perf_header_string of the commandline.
missing your Signed-off-by
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
> ---
> tools/perf/Documentation/perf.data-file-format.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt
> index dfb218feaad9..5f9a3924830b 100644
> --- a/tools/perf/Documentation/perf.data-file-format.txt
> +++ b/tools/perf/Documentation/perf.data-file-format.txt
> @@ -131,7 +131,7 @@ An uint64_t with the total memory in bytes.
>
> HEADER_CMDLINE = 11,
>
> -A perf_header_string with the perf command line used to collect the data.
> +A perf_header_string_list with the perf arg-vector used to collect the data.
>
> HEADER_EVENT_DESC = 12,
>
> --
> 2.19.2
>
next prev parent reply other threads:[~2019-02-19 14:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 18:28 [PATCH] perf: update perf.data file format documentation Jonas Rabenstein
2019-02-17 23:22 ` Jiri Olsa
2019-02-18 9:04 ` Jonas Rabenstein
2019-02-18 12:46 ` Arnaldo Carvalho de Melo
2019-02-18 14:02 ` [PATCH] perf: fix HEADER_CMDLINE description in perf.data documentation Jonas Rabenstein
2019-02-19 14:04 ` Jiri Olsa [this message]
2019-02-19 15:24 ` Arnaldo Carvalho de Melo
2019-02-19 15:45 ` Jonas Rabenstein
2019-02-19 15:45 ` [PATCH] perf: fix documentation of the Flags section in perf.data Jonas Rabenstein
2019-02-18 14:18 ` Jonas Rabenstein
2019-02-19 14:04 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219140409.GD6435@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=jonas.rabenstein@studium.uni-erlangen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).