linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Jones <tonyj@suse.de>
To: linux-kernel@vger.kernel.org
Cc: acme@kernel.org, linux-perf-users@vger.kernel.org,
	Tony Jones <tonyj@suse.de>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Feng Tang <feng.tang@intel.com>, Tom Zanussi <tzanussi@gmail.com>,
	Seeteena Thoufeek <s1seetee@linux.vnet.ibm.com>
Subject: [PATCH v2 0/7] perf script python: add Python3 support
Date: Fri,  1 Mar 2019 17:18:56 -0800	[thread overview]
Message-ID: <20190302011903.2416-1-tonyj@suse.de> (raw)

This is v2 of my version of the patchset.  Incorporating the 
previous feedback.  Some changes from v1 were already merged.

Patch 1/7 deals with the existing inconsistent indentation.
Indentation is now consistent per file but varying styles (tabs,
4 spaces and 8 spaces).   
I will followup at a later date with changes to checkpatch to ensure
that the syntax per file is maintained.

Patches 2/7 through 5/7 were sent in v1,  they have been changed 
to remove the previous indentation changes

Patch 6/7 was sent in v1.  I had previously *not* been able to test 
export-to-postgresql.py.  I was able to do so this time and found
that more changes were needed.    The author of the original code
seems concerned about code-style so I would suggest you only merge 
with his explicit ACK.

Patch 7/7 was not in v1, it cleans up some repeated use of date
functions in the SQL exporters.  It is not mandatory for Python3
support.  It is dependent on Patch#6.

I hope I've got everything correct, I've retested until I feel I 
can't look at Python code anymore for a while :-). Hopefully I've 
not made any more mistakes.  If I have, please LMK and I'll do v3.

Thanks

Tony

             reply	other threads:[~2019-03-02  1:18 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-02  1:18 Tony Jones [this message]
2019-03-02  1:18 ` [PATCH v2 1/7] perf script python: remove mixed indentation Tony Jones
2019-03-05 10:39   ` Adrian Hunter
2019-03-06 21:09   ` Arnaldo Carvalho de Melo
2019-03-02  1:18 ` [PATCH v2 2/7] perf script python: add Python3 support to futex-contention.py Tony Jones
2019-03-06 21:11   ` Arnaldo Carvalho de Melo
2019-03-02  1:18 ` [PATCH v2 3/7] perf script python: add Python3 support to check-perf-trace.py Tony Jones
2019-03-06 21:11   ` Arnaldo Carvalho de Melo
2019-03-02  1:19 ` [PATCH v2 4/7] perf script python: add Python3 support to event_analyzing_sample.py Tony Jones
2019-03-06 21:11   ` Arnaldo Carvalho de Melo
2019-03-02  1:19 ` [PATCH v2 5/7] perf script python: add Python3 support to intel-pt-events.py Tony Jones
2019-03-05 10:16   ` Adrian Hunter
2019-03-05 15:02     ` Tony Jones
2019-03-05 16:10       ` Tony Jones
2019-03-05 16:19         ` Tony Jones
2019-03-06  9:28           ` Adrian Hunter
2019-03-06 21:12             ` Arnaldo Carvalho de Melo
2019-03-02  1:19 ` [PATCH v2 6/7] perf script python: add Python3 support to sql scripts Tony Jones
2019-03-06  9:26   ` Adrian Hunter
2019-03-06 16:32     ` Tony Jones
2019-03-07 18:51       ` Arnaldo Carvalho de Melo
2019-03-08  9:47         ` Adrian Hunter
2019-03-08 14:36           ` Arnaldo Carvalho de Melo
2019-03-02  1:19 ` [PATCH v2 7/7] perf script python: add printdate function to SQL exporters Tony Jones
2019-03-06 21:13   ` Arnaldo Carvalho de Melo
2019-03-08 12:50     ` Adrian Hunter
2019-03-05  9:55 ` [PATCH v2 0/7] perf script python: add Python3 support Adrian Hunter
2019-03-05 14:53   ` Tony Jones
2019-03-05 15:18     ` Tony Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190302011903.2416-1-tonyj@suse.de \
    --to=tonyj@suse.de \
    --cc=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=feng.tang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=s1seetee@linux.vnet.ibm.com \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).