From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v3 10/11] perf tools report: Implement browsing of individual samples
Date: Mon, 4 Mar 2019 15:48:12 +0100 [thread overview]
Message-ID: <20190304144812.GG30476@krava> (raw)
In-Reply-To: <20190228183550.14126-11-andi@firstfloor.org>
On Thu, Feb 28, 2019 at 10:35:49AM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Now report can show whole time periods with perf script,
> but the user still has to find individual samples of interest
> manually.
>
> It would be expensive and complicated to search for the
> right samples in the whole perf file. Typically users
> only need to look at a small number of samples for useful
> analysis.
>
> Also the full scripts tend to show samples of all CPUs and all
> threads mixed up, which can be very confusing on larger systems.
>
> Add a new --samples option to save a small random number of samples
> per hist entry
>
> Use a reservoir sample technique to select a representatve
> number of samples.
>
> Then allow browsing the samples using perf script
> as part of the hist entry context menu. This automatically
> adds the right filters, so only the thread or cpu of the sample
> is displayed. Then we use less' search functionality
> to directly jump the to the time stamp of the selected
> sample.
when I choose:
148156.305096328: CPU 0 tid 16402 ▒
I'm getting:
sched-messaging 16402 [000] 148156.305096328: 886205 cycles:ppp: ffffffff93a001ad syscall_return_via_sysret+0xbc ([kernel.kallsyms])
sched-messaging 16402 [000] 148156.305344526: 887134 cycles:ppp: ffffffff933f8c7d avc_has_perm+0xcd ([kernel.kallsyms])
sched-messaging 16402 [000] 148156.305594286: 888614 cycles:ppp: ffffffff93208a02 stackleak_erase+0xa2 ([kernel.kallsyms])
sched-messaging 16402 [000] 148156.305843034: 888750 cycles:ppp: ffffffff93986d30 _raw_spin_lock+0x10 ([kernel.kallsyms])
sched-messaging 16402 [000] 148156.306091824: 889265 cycles:ppp: ffffffff932c623e __vfs_write+0xbe ([kernel.kallsyms])
sched-messaging 16402 [000] 148156.306340739: 889802 cycles:ppp: ffffffff937eaee4 skb_set_owner_w+0x54 ([kernel.kallsyms])
sched-messaging 16402 [000] 148156.306590950: 890449 cycles:ppp: ffffffff93291e33 __kmalloc_node_track_caller+0xc3 ([kernel.kallsyms])
sched-messaging 16402 [000] 148156.306840144: 890348 cycles:ppp: ffffffff932089a9 stackleak_erase+0x49 ([kernel.kallsyms])
sched-messaging 16402 [000] 148156.307089348: 890707 cycles:ppp: ffffffff932e60e6 __fget_light+0x46 ([kernel.kallsyms])
sched-messaging 16402 [000] 148156.307338691: 891063 cycles:ppp: ffffffff938ed2a3 unix_stream_sendmsg+0x213 ([kernel.kallsyms])
sched-messaging 16402 [001] 148156.323855201: 916081 cycles:ppp: ffffffff93208a05 stackleak_erase+0xa5 ([kernel.kallsyms])
sched-messaging 16402 [001] 148156.324104737: 916330 cycles:ppp: ffffffff93986d30 _raw_spin_lock+0x10 ([kernel.kallsyms])
sched-messaging 16402 [001] 148156.324354188: 916467 cycles:ppp: ffffffff9324192f kmalloc_slab+0x4f ([kernel.kallsyms])
systemd-journal 882 [005] 148156.373698788: PERF_RECORD_FORK(882:16422):(882:882)
systemd-journal 882 [005] 148156.373718699: PERF_RECORD_FORK(882:16423):(882:882)
journal-offline 16422 [002] 148156.373720344: PERF_RECORD_COMM: journal-offline:882/16422
journal-offline 16423 [005] 148156.373766480: PERF_RECORD_COMM: journal-offline:882/16423
journal-offline 16423 [005] 148156.385947319: PERF_RECORD_EXIT(882:16423):(882:16423)
systemd-journal 882 [002] 148156.386052146: PERF_RECORD_FORK(882:16424):(882:882)
journal-offline 16424 [001] 148156.386069865: PERF_RECORD_COMM: journal-offline:882/16424
journal-offline 16422 [002] 148156.386132447: PERF_RECORD_EXIT(882:16422):(882:16422)
journal-offline 16424 [001] 148156.389171176: PERF_RECORD_EXIT(882:16424):(882:16424)
systemd-journal 882 [002] 148156.389263406: PERF_RECORD_FORK(882:16425):(882:882)
some other cpus and threads mixed in
jirka
next prev parent reply other threads:[~2019-03-04 14:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 18:35 Support sample context in perf report Andi Kleen
2019-02-28 18:35 ` [PATCH v3 01/11] perf tools: Add utility function to fetch executable Andi Kleen
2019-03-04 14:48 ` Jiri Olsa
2019-02-28 18:35 ` [PATCH v3 02/11] perf tools script: Support insn output for normal samples Andi Kleen
2019-03-04 14:48 ` Jiri Olsa
2019-03-04 18:14 ` Andi Kleen
2019-02-28 18:35 ` [PATCH v3 03/11] perf tools report: Support nano seconds Andi Kleen
2019-02-28 18:35 ` [PATCH v3 04/11] perf tools report: Parse time quantum Andi Kleen
2019-03-04 14:49 ` Jiri Olsa
2019-02-28 18:35 ` [PATCH v3 05/11] perf tools report: Support time sort key Andi Kleen
2019-02-28 18:35 ` [PATCH v3 06/11] perf tools report: Use less for scripts output Andi Kleen
2019-02-28 18:35 ` [PATCH v3 07/11] perf tools report: Support running scripts for current time range Andi Kleen
2019-03-04 14:48 ` Jiri Olsa
2019-02-28 18:35 ` [PATCH v3 08/11] perf tools report: Support builtin perf script in scripts menu Andi Kleen
2019-02-28 18:35 ` [PATCH v3 09/11] perf tools: Add utility function to print ns time stamps Andi Kleen
2019-02-28 18:35 ` [PATCH v3 10/11] perf tools report: Implement browsing of individual samples Andi Kleen
2019-03-04 14:47 ` Jiri Olsa
2019-03-04 14:48 ` Jiri Olsa [this message]
2019-03-04 14:48 ` Jiri Olsa
2019-03-04 18:13 ` Andi Kleen
2019-03-04 15:27 ` Jiri Olsa
2019-02-28 18:35 ` [PATCH v3 11/11] perf tools: Add some new tips describing the new options Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304144812.GG30476@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).