From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Andi Kleen <andi@firstfloor.org>,
jolsa@kernel.org, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 09/11] perf tools report: Add custom scripts to script menu
Date: Mon, 11 Mar 2019 15:45:34 -0300 [thread overview]
Message-ID: <20190311184534.GZ10690@kernel.org> (raw)
In-Reply-To: <20190311183455.GB29294@tassilo.jf.intel.com>
Em Mon, Mar 11, 2019 at 11:34:55AM -0700, Andi Kleen escreveu:
> > Isn't it better to use 'scripts' for those scripts and leave 'script'
> > for configuring the 'perf script' command like we have options for
> > annotate, etc?
>
> Yes that's fine.
>
> That's just two character updates in the doc and in the strstarts below.
> If there's nothing else can you please just do these changes when you apply?
Sure, doing that now.
> Thanks.
>
> > > +static int scripts_config(const char *var, const char *value, void *data)
> > > +{
> > > + struct script_config *c = data;
> > > +
> > > + if (!strstarts(var, "script."))
> > > + return -1;
--
- Arnaldo
next prev parent reply other threads:[~2019-03-11 18:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 14:44 Support sample context in perf report Andi Kleen
2019-03-11 14:44 ` [PATCH v6 01/11] perf tools script: Filter COMM/FORK/.. events by CPU Andi Kleen
2019-03-11 16:58 ` Arnaldo Carvalho de Melo
2019-03-11 14:44 ` [PATCH v6 02/11] perf tools report: Parse time quantum Andi Kleen
2019-03-11 16:59 ` Arnaldo Carvalho de Melo
2019-03-11 14:44 ` [PATCH v6 03/11] perf tools report: Support time sort key Andi Kleen
2019-03-11 17:04 ` Arnaldo Carvalho de Melo
2019-03-11 14:44 ` [PATCH v6 04/11] perf tools report: Use less for scripts output Andi Kleen
2019-03-11 17:05 ` Arnaldo Carvalho de Melo
2019-03-11 14:44 ` [PATCH v6 05/11] perf tools report: Support running scripts for current time range Andi Kleen
2019-03-11 17:06 ` Arnaldo Carvalho de Melo
2019-03-11 14:44 ` [PATCH v6 06/11] perf tools report: Support builtin perf script in scripts menu Andi Kleen
2019-03-11 17:09 ` Arnaldo Carvalho de Melo
2019-03-11 14:44 ` [PATCH v6 07/11] perf tools report: Implement browsing of individual samples Andi Kleen
2019-03-11 17:24 ` Jiri Olsa
2019-03-11 17:46 ` Andi Kleen
2019-03-11 18:35 ` Arnaldo Carvalho de Melo
2019-03-11 19:04 ` Andi Kleen
2019-03-11 14:44 ` [PATCH v6 08/11] perf tools: Add some new tips describing the new options Andi Kleen
2019-03-11 14:45 ` [PATCH v6 09/11] perf tools report: Add custom scripts to script menu Andi Kleen
2019-03-11 18:10 ` Arnaldo Carvalho de Melo
2019-03-11 18:34 ` Andi Kleen
2019-03-11 18:45 ` Arnaldo Carvalho de Melo [this message]
2019-03-11 14:45 ` [PATCH v6 10/11] perf tools script: Add array bound checking to list_scripts Andi Kleen
2019-03-11 18:18 ` Arnaldo Carvalho de Melo
2019-03-11 14:45 ` [PATCH v6 11/11] perf tools ui: Fix ui popup browser for many entries Andi Kleen
2019-03-11 18:17 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311184534.GZ10690@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).