From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Subject: Re: [PATCH v6 09/11] perf tools report: Add custom scripts to script
 menu
Date: Mon, 11 Mar 2019 15:45:34 -0300
Message-ID: <20190311184534.GZ10690@kernel.org>
References: <20190311144502.15423-1-andi@firstfloor.org>
 <20190311144502.15423-10-andi@firstfloor.org>
 <20190311181021.GT10690@kernel.org>
 <20190311183455.GB29294@tassilo.jf.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20190311183455.GB29294@tassilo.jf.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Andi Kleen <ak@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>, Andi Kleen <andi@firstfloor.org>, jolsa@kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
List-Id: linux-perf-users.vger.kernel.org

Em Mon, Mar 11, 2019 at 11:34:55AM -0700, Andi Kleen escreveu:
> > Isn't it better to use 'scripts' for those scripts and leave 'script'
> > for configuring the 'perf script' command like we have options for
> > annotate, etc?
> 
> Yes that's fine.
> 
> That's just two character updates in the doc and in the strstarts below. 
> If there's nothing else can you please just do these changes when you apply?

Sure, doing that now.
 
> Thanks.
> 
> > > +static int scripts_config(const char *var, const char *value, void *data)
> > > +{
> > > +	struct script_config *c = data;
> > > +
> > > +	if (!strstarts(var, "script."))
> > > +		return -1;

-- 

- Arnaldo