From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Andi Kleen <andi@firstfloor.org>,
jolsa@kernel.org, linux-perf-users@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 02/10] perf, tools, stat: Avoid memory overrun with -r
Date: Tue, 19 Mar 2019 16:33:46 -0300 [thread overview]
Message-ID: <20190319193346.GN3029@kernel.org> (raw)
In-Reply-To: <20190319192023.GX24002@tassilo.jf.intel.com>
Em Tue, Mar 19, 2019 at 12:20:23PM -0700, Andi Kleen escreveu:
> > mmap size 8192B
> > perf: util/evlist.c:533: perf_evlist__id_add: Assertion `evsel->ids < evsel->sample_id->max_x * evsel->sample_id->max_y' failed.
>
> I suspect this is a latent bug just caught by my assert.
>
> So it was already broken.
>
> You could of course remove the assert, but it would merely
> hide it.
I'm removing it just for the moment, I'll definetely revisit this.
- Arnaldo
prev parent reply other threads:[~2019-03-19 19:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190314225002.30108-1-andi@firstfloor.org>
[not found] ` <20190314225002.30108-2-andi@firstfloor.org>
2019-03-19 19:14 ` [PATCH v2 02/10] perf, tools, stat: Avoid memory overrun with -r Arnaldo Carvalho de Melo
2019-03-19 19:20 ` Andi Kleen
2019-03-19 19:33 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319193346.GN3029@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).