From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Cc: Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Clark Williams <williams@redhat.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 15/18] perf list: Avoid extra : for --raw metrics
Date: Wed, 3 Jul 2019 00:27:43 -0300 [thread overview]
Message-ID: <20190703032746.21692-16-acme@kernel.org> (raw)
In-Reply-To: <20190703032746.21692-1-acme@kernel.org>
From: Andi Kleen <ak@linux.intel.com>
When printing the metrics raw, don't print : after the metricgroups.
This helps the command line completion to complete those too.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/20190628220737.13259-2-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/metricgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
index bc25995255ab..7d36435fa84c 100644
--- a/tools/perf/util/metricgroup.c
+++ b/tools/perf/util/metricgroup.c
@@ -375,7 +375,7 @@ void metricgroup__print(bool metrics, bool metricgroups, char *filter,
struct mep *me = container_of(node, struct mep, nd);
if (metricgroups)
- printf("%s%s%s", me->name, metrics ? ":" : "", raw ? " " : "\n");
+ printf("%s%s%s", me->name, metrics && !raw ? ":" : "", raw ? " " : "\n");
if (metrics)
metricgroup__print_strlist(me->metrics, raw);
next = rb_next(node);
--
2.20.1
next prev parent reply other threads:[~2019-07-03 3:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 3:27 [GIT PULL] perf/core improvements and fixes Arnaldo Carvalho de Melo
2019-07-03 3:27 ` [PATCH 01/18] objtool: Fix build by linking against tools/lib/ctype.o sources Arnaldo Carvalho de Melo
2019-07-03 3:27 ` [PATCH 02/18] perf symbol: Create block_info structure Arnaldo Carvalho de Melo
2019-07-03 3:27 ` [PATCH 03/18] perf hists: Add block_info in hist_entry Arnaldo Carvalho de Melo
2019-07-03 3:27 ` [PATCH 04/18] perf diff: Check if all data files with branch stacks Arnaldo Carvalho de Melo
2019-07-03 3:27 ` [PATCH 05/18] perf diff: Use hists to manage basic blocks per symbol Arnaldo Carvalho de Melo
2019-07-03 3:27 ` [PATCH 06/18] perf diff: Link same basic blocks among different data Arnaldo Carvalho de Melo
2019-07-03 3:27 ` [PATCH 07/18] perf diff: Print the basic block cycles diff Arnaldo Carvalho de Melo
2019-07-03 3:27 ` [PATCH 08/18] perf diff: Documentation -c cycles option Arnaldo Carvalho de Melo
2019-07-03 3:27 ` [PATCH 09/18] perf pmu: Support more complex PMU event aliasing Arnaldo Carvalho de Melo
2019-07-03 3:27 ` [PATCH 10/18] perf jevents: Add support for Hisi hip08 DDRC PMU aliasing Arnaldo Carvalho de Melo
2019-07-03 3:27 ` [PATCH 11/18] perf jevents: Add support for Hisi hip08 HHA " Arnaldo Carvalho de Melo
2019-07-03 3:27 ` [PATCH 12/18] perf jevents: Add support for Hisi hip08 L3C " Arnaldo Carvalho de Melo
2019-07-03 3:27 ` [PATCH 13/18] perf tools: Fix typos / broken sentences Arnaldo Carvalho de Melo
2019-07-03 3:27 ` [PATCH 14/18] perf vendor events intel: Metric fixes for SKX/CLX Arnaldo Carvalho de Melo
2019-07-03 3:27 ` Arnaldo Carvalho de Melo [this message]
2019-07-03 3:27 ` [PATCH 16/18] perf tools metric: Don't include duration_time in group Arnaldo Carvalho de Melo
2019-07-03 3:27 ` [PATCH 17/18] perf tests: Fix record+probe_libc_inet_pton.sh for powerpc64 Arnaldo Carvalho de Melo
2019-07-03 3:27 ` [PATCH 18/18] perf script: Allow specifying the files to process guest samples Arnaldo Carvalho de Melo
2019-07-03 13:56 ` [GIT PULL] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703032746.21692-16-acme@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).