From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Clark Williams <williams@redhat.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
David Carrillo Cisneros <davidca@fb.com>,
Leo Yan <leo.yan@linaro.org>, Luke Mujica <lukemujica@google.com>,
Numfor Mbiziwo-Tiapo <nums@google.com>,
Song Liu <songliubraving@fb.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [GIT PULL] perf/core improvements and fixes
Date: Sat, 13 Jul 2019 11:13:56 +0200 [thread overview]
Message-ID: <20190713091356.GA81998@gmail.com> (raw)
In-Reply-To: <20190709183126.30257-1-acme@kernel.org>
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> Best regards,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit d1d59b817939821bee149e870ce7723f61ffb512:
>
> Merge tag 'perf-urgent-for-mingo-5.3-20190708-2' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2019-07-09 13:22:03 +0200)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-5.3-20190709
>
> for you to fetch changes up to 323fd749821daab0f327ec86d707c4542963cdb0:
>
> perf intel-pt: Fix potential NULL pointer dereference found by the smatch tool (2019-07-09 10:13:28 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> Intel PT:
>
> Adrian Hunter:
>
> - Fix DROP VIEW power_events_view in the postgresql and sqlite export-db
> python scripts.
>
> perf script:
>
> Song Liu:
>
> - Assume native_arch for pipe mode, fixing a segfault.
>
> perf inject:
>
> Arnaldo Carvalho de Melo:
>
> - The tool->read() call may pass a NULL evsel, handle it.
>
> core:
>
> Arnaldo Carvalho de Melo:
>
> - Move zalloc/zfree.c to tools/lib, further eroding tools/perf/util.[ch]
>
> - Use zfree() where applicable instead of open coded equivalent.
>
> - Add stdlib.h and some other headers to places where its needed and were
> getting via util.h, that doesn't need that anymore.
>
> - Use list_del_init() more thoroughly.
>
> Miscellaneous:
>
> Leo Yan:
>
> - Fix use after free and potential NULL pointer derefs detected by the
> smatch tool in various places.
>
> Luke Mujica:
>
> - Remove a couple unused variables in the parse-events code.
>
> Numfor Mbiziwo-Tiapo:
>
> - Initialize variable to suppress memory sanitizer warning in the
> mmap-thread-lookup 'perf test' entry.
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (2):
> perf scripts python: export-to-postgresql.py: Fix DROP VIEW power_events_view
> perf scripts python: export-to-sqlite.py: Fix DROP VIEW power_events_view
>
> Arnaldo Carvalho de Melo (9):
> perf inject: The tool->read() call may pass a NULL evsel, handle it
> perf evsel: perf_evsel__name(NULL) is valid, no need to check evsel
> perf tools: Add missing headers, mostly stdlib.h
> perf namespaces: Move the conditional setns() prototype to namespaces.h
> perf tools: Move get_current_dir_name() cond prototype out of util.h
> tools lib: Adopt zalloc()/zfree() from tools/perf
> perf tools: Use zfree() where applicable
> perf tools: Use list_del_init() more thorougly
> perf metricgroup: Add missing list_del_init() when flushing egroups list
>
> Leo Yan (10):
> perf stat: Fix use-after-freed pointer detected by the smatch tool
> perf top: Fix potential NULL pointer dereference detected by the smatch tool
> perf annotate: Fix dereferencing freed memory found by the smatch tool
> perf trace: Fix potential NULL pointer dereference found by the smatch tool
> perf map: Fix potential NULL pointer dereference found by smatch tool
> perf session: Fix potential NULL pointer dereference found by the smatch tool
> perf cs-etm: Fix potential NULL pointer dereference found by the smatch tool
> perf hists browser: Fix potential NULL pointer dereference found by the smatch tool
> perf intel-bts: Fix potential NULL pointer dereference found by the smatch tool
> perf intel-pt: Fix potential NULL pointer dereference found by the smatch tool
>
> Luke Mujica (2):
> perf parse-events: Remove unused variable 'i'
> perf parse-events: Remove unused variable: error
>
> Numfor Mbiziwo-Tiapo (1):
> perf test mmap-thread-lookup: Initialize variable to suppress memory sanitizer warning
>
> Song Liu (1):
> perf script: Assume native_arch for pipe mode
>
> tools/include/linux/zalloc.h | 12 +++++
> tools/lib/zalloc.c | 15 ++++++
> tools/perf/MANIFEST | 1 +
> tools/perf/arch/arm/annotate/instructions.c | 1 +
> tools/perf/arch/arm/util/auxtrace.c | 1 +
> tools/perf/arch/arm/util/cs-etm.c | 1 +
> tools/perf/arch/arm64/util/arm-spe.c | 1 +
> tools/perf/arch/common.c | 3 +-
> tools/perf/arch/powerpc/util/perf_regs.c | 4 +-
> tools/perf/arch/s390/util/auxtrace.c | 1 +
> tools/perf/arch/s390/util/header.c | 3 +-
> tools/perf/arch/x86/util/event.c | 2 +-
> tools/perf/arch/x86/util/intel-bts.c | 2 +-
> tools/perf/arch/x86/util/intel-pt.c | 2 +-
> tools/perf/arch/x86/util/perf_regs.c | 2 +-
> tools/perf/bench/futex-hash.c | 3 +-
> tools/perf/bench/futex-lock-pi.c | 3 +-
> tools/perf/bench/mem-functions.c | 2 +-
> tools/perf/bench/numa.c | 2 +-
> tools/perf/builtin-annotate.c | 2 +-
> tools/perf/builtin-bench.c | 2 +-
> tools/perf/builtin-c2c.c | 2 +-
> tools/perf/builtin-config.c | 1 +
> tools/perf/builtin-diff.c | 2 +-
> tools/perf/builtin-ftrace.c | 2 +-
> tools/perf/builtin-help.c | 2 +
> tools/perf/builtin-inject.c | 2 +-
> tools/perf/builtin-kmem.c | 2 +-
> tools/perf/builtin-kvm.c | 2 +-
> tools/perf/builtin-lock.c | 10 ++--
> tools/perf/builtin-probe.c | 2 +-
> tools/perf/builtin-record.c | 4 +-
> tools/perf/builtin-report.c | 4 +-
> tools/perf/builtin-sched.c | 2 +-
> tools/perf/builtin-script.c | 5 +-
> tools/perf/builtin-stat.c | 8 ++--
> tools/perf/builtin-timechart.c | 4 +-
> tools/perf/builtin-top.c | 8 +++-
> tools/perf/builtin-trace.c | 7 +--
> tools/perf/perf.c | 2 +-
> tools/perf/pmu-events/jevents.c | 2 +-
> tools/perf/scripts/python/export-to-postgresql.py | 2 +-
> tools/perf/scripts/python/export-to-sqlite.py | 2 +-
> tools/perf/tests/dwarf-unwind.c | 5 +-
> tools/perf/tests/expr.c | 3 +-
> tools/perf/tests/llvm.c | 1 +
> tools/perf/tests/mem2node.c | 3 +-
> tools/perf/tests/mmap-thread-lookup.c | 2 +-
> tools/perf/tests/sample-parsing.c | 1 +
> tools/perf/tests/switch-tracking.c | 3 +-
> tools/perf/tests/thread-map.c | 3 +-
> tools/perf/tests/vmlinux-kallsyms.c | 1 +
> tools/perf/ui/browser.c | 2 +-
> tools/perf/ui/browser.h | 1 +
> tools/perf/ui/browsers/annotate.c | 2 +-
> tools/perf/ui/browsers/hists.c | 17 +++++--
> tools/perf/ui/browsers/map.c | 1 +
> tools/perf/ui/browsers/res_sample.c | 6 +--
> tools/perf/ui/browsers/scripts.c | 4 +-
> tools/perf/ui/gtk/annotate.c | 2 +-
> tools/perf/ui/gtk/util.c | 3 +-
> tools/perf/ui/stdio/hist.c | 2 +-
> tools/perf/ui/tui/setup.c | 1 +
> tools/perf/ui/tui/util.c | 2 +-
> tools/perf/util/Build | 5 ++
> tools/perf/util/annotate.c | 13 ++---
> tools/perf/util/arm-spe.c | 2 +-
> tools/perf/util/auxtrace.c | 11 ++---
> tools/perf/util/bpf-loader.c | 3 +-
> tools/perf/util/build-id.c | 1 +
> tools/perf/util/call-path.c | 5 +-
> tools/perf/util/callchain.c | 12 ++---
> tools/perf/util/cgroup.c | 4 +-
> tools/perf/util/comm.c | 2 +-
> tools/perf/util/config.c | 3 +-
> tools/perf/util/counts.c | 2 +-
> tools/perf/util/cpumap.c | 2 +-
> tools/perf/util/cputopo.c | 5 +-
> tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 1 +
> tools/perf/util/cs-etm.c | 8 ++--
> tools/perf/util/data-convert-bt.c | 4 +-
> tools/perf/util/data.c | 3 +-
> tools/perf/util/db-export.c | 7 +--
> tools/perf/util/debug.c | 1 +
> tools/perf/util/demangle-java.c | 3 +-
> tools/perf/util/dso.c | 5 +-
> tools/perf/util/dwarf-aux.c | 2 +-
> tools/perf/util/env.c | 11 +++--
> tools/perf/util/event.c | 3 +-
> tools/perf/util/evlist.c | 2 +-
> tools/perf/util/evsel.c | 4 +-
> tools/perf/util/get_current_dir_name.c | 6 +--
> tools/perf/util/get_current_dir_name.h | 8 ++++
> tools/perf/util/header.c | 8 ++--
> tools/perf/util/help-unknown-cmd.c | 2 +
> tools/perf/util/hist.c | 20 ++++----
> tools/perf/util/intel-bts.c | 7 ++-
> .../perf/util/intel-pt-decoder/intel-pt-decoder.c | 2 +-
> tools/perf/util/intel-pt.c | 15 +++---
> tools/perf/util/jitdump.c | 7 ++-
> tools/perf/util/llvm-utils.c | 4 +-
> tools/perf/util/machine.c | 6 +--
> tools/perf/util/map.c | 9 ++--
> tools/perf/util/mem2node.c | 2 +-
> tools/perf/util/metricgroup.c | 10 ++--
> tools/perf/util/mmap.c | 1 +
> tools/perf/util/namespaces.c | 3 +-
> tools/perf/util/namespaces.h | 4 ++
> tools/perf/util/ordered-events.c | 6 +--
> tools/perf/util/parse-branch-options.c | 2 +-
> tools/perf/util/parse-events.c | 3 +-
> tools/perf/util/parse-events.y | 2 -
> tools/perf/util/parse-regs-options.c | 8 +++-
> tools/perf/util/pmu.c | 4 +-
> tools/perf/util/probe-event.c | 55 ++++++++++------------
> tools/perf/util/probe-file.c | 2 +-
> tools/perf/util/probe-finder.c | 2 +-
> tools/perf/util/pstack.c | 2 +-
> tools/perf/util/python-ext-sources | 1 +
> tools/perf/util/s390-cpumsf.c | 11 ++---
> tools/perf/util/session.c | 7 ++-
> tools/perf/util/setns.c | 4 +-
> tools/perf/util/srccode.c | 11 +++--
> tools/perf/util/srcline.c | 2 +-
> tools/perf/util/stat-shadow.c | 3 +-
> tools/perf/util/stat.c | 3 +-
> tools/perf/util/strbuf.c | 3 +-
> tools/perf/util/strfilter.c | 3 +-
> tools/perf/util/strlist.c | 2 +-
> tools/perf/util/svghelper.c | 2 +-
> tools/perf/util/symbol-elf.c | 18 +++----
> tools/perf/util/symbol-minimal.c | 3 +-
> tools/perf/util/symbol.c | 1 +
> tools/perf/util/syscalltbl.c | 2 +-
> tools/perf/util/target.c | 2 +-
> tools/perf/util/thread-stack.c | 3 +-
> tools/perf/util/thread.c | 6 +--
> tools/perf/util/thread_map.c | 4 +-
> tools/perf/util/trace-event-info.c | 1 +
> tools/perf/util/trace-event-scripting.c | 2 +-
> tools/perf/util/unwind-libdw.c | 1 +
> tools/perf/util/unwind-libunwind-local.c | 3 +-
> tools/perf/util/usage.c | 3 ++
> tools/perf/util/util.h | 17 -------
> tools/perf/util/values.c | 2 +-
> tools/perf/util/vdso.c | 1 +
> tools/perf/util/xyarray.c | 2 +-
> 147 files changed, 375 insertions(+), 279 deletions(-)
> create mode 100644 tools/include/linux/zalloc.h
> create mode 100644 tools/lib/zalloc.c
> create mode 100644 tools/perf/util/get_current_dir_name.h
Pulled, thanks a lot Arnaldo!
Ingo
next prev parent reply other threads:[~2019-07-13 9:13 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 18:31 [GIT PULL] perf/core improvements and fixes Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 01/25] perf test mmap-thread-lookup: Initialize variable to suppress memory sanitizer warning Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 02/25] perf stat: Fix use-after-freed pointer detected by the smatch tool Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 03/25] perf top: Fix potential NULL pointer dereference " Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 04/25] perf annotate: Fix dereferencing freed memory found " Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 05/25] perf trace: Fix potential NULL pointer dereference " Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 06/25] perf map: Fix potential NULL pointer dereference found by " Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 07/25] perf inject: The tool->read() call may pass a NULL evsel, handle it Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 08/25] perf session: Fix potential NULL pointer dereference found by the smatch tool Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 09/25] perf evsel: perf_evsel__name(NULL) is valid, no need to check evsel Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 10/25] perf tools: Add missing headers, mostly stdlib.h Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 11/25] perf namespaces: Move the conditional setns() prototype to namespaces.h Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 12/25] perf tools: Move get_current_dir_name() cond prototype out of util.h Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 13/25] tools lib: Adopt zalloc()/zfree() from tools/perf Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 14/25] perf tools: Use zfree() where applicable Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 15/25] perf tools: Use list_del_init() more thorougly Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 16/25] perf metricgroup: Add missing list_del_init() when flushing egroups list Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 17/25] perf parse-events: Remove unused variable 'i' Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 18/25] perf parse-events: Remove unused variable: error Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 19/25] perf cs-etm: Fix potential NULL pointer dereference found by the smatch tool Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 20/25] perf hists browser: " Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 21/25] perf scripts python: export-to-postgresql.py: Fix DROP VIEW power_events_view Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 22/25] perf scripts python: export-to-sqlite.py: " Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 23/25] perf script: Assume native_arch for pipe mode Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 24/25] perf intel-bts: Fix potential NULL pointer dereference found by the smatch tool Arnaldo Carvalho de Melo
2019-07-09 18:31 ` [PATCH 25/25] perf intel-pt: " Arnaldo Carvalho de Melo
2019-07-13 9:13 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-06 15:21 [GIT PULL] perf/core improvements and fixes Arnaldo Carvalho de Melo
2020-04-20 11:52 Arnaldo Carvalho de Melo
2020-04-22 12:09 ` Ingo Molnar
2020-04-23 21:28 ` Daniel Díaz
2020-04-24 13:07 ` Arnaldo Carvalho de Melo
2020-04-24 14:10 ` Andreas Gerstmayr
2020-05-04 19:07 ` Daniel Díaz
2020-05-05 16:37 ` Arnaldo Carvalho de Melo
2020-05-05 16:57 ` Daniel Díaz
2020-05-05 17:03 ` Arnaldo Carvalho de Melo
2020-03-25 12:41 Arnaldo Carvalho de Melo
2020-03-17 21:32 Arnaldo Carvalho de Melo
2020-03-19 14:03 ` Ingo Molnar
2020-03-19 14:07 ` Arnaldo Carvalho de Melo
2020-03-10 11:15 Arnaldo Carvalho de Melo
2020-01-16 13:48 Arnaldo Carvalho de Melo
2020-01-20 8:23 ` Ingo Molnar
2020-01-06 16:06 Arnaldo Carvalho de Melo
2020-01-10 17:50 ` Ingo Molnar
2020-01-28 19:10 ` pr-tracker-bot
2019-12-03 13:55 Arnaldo Carvalho de Melo
2019-12-04 7:51 ` Ingo Molnar
2019-11-28 13:40 Arnaldo Carvalho de Melo
2019-11-29 5:58 ` Ingo Molnar
2019-11-22 14:56 Arnaldo Carvalho de Melo
2019-11-23 8:07 ` Ingo Molnar
2019-11-19 11:32 Arnaldo Carvalho de Melo
2019-11-19 12:00 ` Ingo Molnar
2019-11-12 18:37 Arnaldo Carvalho de Melo
2019-11-15 7:35 ` Ingo Molnar
2019-11-07 18:59 Arnaldo Carvalho de Melo
2019-11-12 11:08 ` Ingo Molnar
2019-10-21 13:37 Arnaldo Carvalho de Melo
2019-10-21 23:16 ` Ingo Molnar
2019-10-11 20:04 Arnaldo Carvalho de Melo
2019-10-15 5:25 ` Ingo Molnar
2019-09-26 0:31 Arnaldo Carvalho de Melo
2019-09-26 5:55 ` Ingo Molnar
2019-09-20 14:25 Arnaldo Carvalho de Melo
2019-09-20 16:15 ` Ingo Molnar
2019-09-01 12:22 Arnaldo Carvalho de Melo
2019-09-02 7:14 ` Ingo Molnar
2019-08-29 14:38 Arnaldo Carvalho de Melo
2019-08-29 18:58 ` Ingo Molnar
2019-08-27 1:36 Arnaldo Carvalho de Melo
2019-08-27 8:24 ` Ingo Molnar
2019-08-22 21:00 Arnaldo Carvalho de Melo
2019-08-23 10:30 ` Ingo Molnar
2019-08-20 19:27 Arnaldo Carvalho de Melo
2019-08-20 19:39 ` Ingo Molnar
2019-08-20 19:44 ` Arnaldo Carvalho de Melo
2019-08-16 20:16 Arnaldo Carvalho de Melo
2019-08-14 18:40 Arnaldo Carvalho de Melo
2019-07-22 17:38 Arnaldo Carvalho de Melo
2019-07-15 21:11 Arnaldo Carvalho de Melo
2019-07-03 3:27 Arnaldo Carvalho de Melo
2019-07-03 13:56 ` Ingo Molnar
2019-07-02 2:25 Arnaldo Carvalho de Melo
2019-07-03 13:55 ` Ingo Molnar
2019-06-21 17:38 Arnaldo Carvalho de Melo
2019-06-22 6:28 ` Ingo Molnar
2019-06-11 18:57 Arnaldo Carvalho de Melo
2019-06-17 18:48 ` Ingo Molnar
2019-05-17 19:34 Arnaldo Carvalho de Melo
2019-05-18 8:27 ` Ingo Molnar
2019-02-25 21:19 Arnaldo Carvalho de Melo
2019-02-28 7:31 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190713091356.GA81998@gmail.com \
--to=mingo@kernel.org \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=davidca@fb.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lukemujica@google.com \
--cc=namhyung@kernel.org \
--cc=nums@google.com \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).