* [PATCH] Fixes issue when debugging debug builds of Perf. @ 2019-10-28 11:34 James Clark 2019-10-29 14:00 ` Arnaldo Carvalho de Melo 0 siblings, 1 reply; 6+ messages in thread From: James Clark @ 2019-10-28 11:34 UTC (permalink / raw) To: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: nd, acme@redhat.com, irogers@google.com, James Clark When a 'make DEBUG=1' build is done, the command parser is still built with -O6 and is hard to step through. This change also moves EXTRA_WARNINGS and EXTRA_FLAGS to the end of the compilation line, otherwise they cannot be used to override the default values. Signed-off-by: James Clark <james.clark@arm.com> --- tools/lib/subcmd/Makefile | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tools/lib/subcmd/Makefile b/tools/lib/subcmd/Makefile index 5b2cd5e58df0..1c777a72bb39 100644 --- a/tools/lib/subcmd/Makefile +++ b/tools/lib/subcmd/Makefile @@ -19,8 +19,7 @@ MAKEFLAGS += --no-print-directory LIBFILE = $(OUTPUT)libsubcmd.a -CFLAGS := $(EXTRA_WARNINGS) $(EXTRA_CFLAGS) -CFLAGS += -ggdb3 -Wall -Wextra -std=gnu99 -fPIC +CFLAGS := -ggdb3 -Wall -Wextra -std=gnu99 -fPIC ifeq ($(DEBUG),0) ifeq ($(feature-fortify-source), 1) @@ -28,7 +27,9 @@ ifeq ($(DEBUG),0) endif endif -ifeq ($(CC_NO_CLANG), 0) +ifeq ($(DEBUG),1) + CFLAGS += -O0 +else ifeq ($(CC_NO_CLANG), 0) CFLAGS += -O3 else CFLAGS += -O6 @@ -43,6 +44,8 @@ CFLAGS += -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE CFLAGS += -I$(srctree)/tools/include/ +CFLAGS += $(EXTRA_WARNINGS) $(EXTRA_CFLAGS) + SUBCMD_IN := $(OUTPUT)libsubcmd-in.o all: -- 2.23.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Fixes issue when debugging debug builds of Perf. 2019-10-28 11:34 [PATCH] Fixes issue when debugging debug builds of Perf James Clark @ 2019-10-29 14:00 ` Arnaldo Carvalho de Melo 2019-10-29 14:18 ` Arnaldo Carvalho de Melo 0 siblings, 1 reply; 6+ messages in thread From: Arnaldo Carvalho de Melo @ 2019-10-29 14:00 UTC (permalink / raw) To: James Clark Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, nd, acme@redhat.com, irogers@google.com Em Mon, Oct 28, 2019 at 11:34:01AM +0000, James Clark escreveu: > When a 'make DEBUG=1' build is done, the command parser > is still built with -O6 and is hard to step through. > > This change also moves EXTRA_WARNINGS and EXTRA_FLAGS to > the end of the compilation line, otherwise they cannot be > used to override the default values. The patch came mangled, so I'm applying by hand, and separating it into two patches, the first for the first paragraph and the other for the second, ok? - Arnaldo > Signed-off-by: James Clark <james.clark@arm.com> > --- > tools/lib/subcmd/Makefile | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/tools/lib/subcmd/Makefile b/tools/lib/subcmd/Makefile > index 5b2cd5e58df0..1c777a72bb39 100644 > --- a/tools/lib/subcmd/Makefile > +++ b/tools/lib/subcmd/Makefile > @@ -19,8 +19,7 @@ MAKEFLAGS += --no-print-directory > > LIBFILE = $(OUTPUT)libsubcmd.a > > -CFLAGS := $(EXTRA_WARNINGS) $(EXTRA_CFLAGS) > -CFLAGS += -ggdb3 -Wall -Wextra -std=gnu99 -fPIC > +CFLAGS := -ggdb3 -Wall -Wextra -std=gnu99 -fPIC > > ifeq ($(DEBUG),0) > ifeq ($(feature-fortify-source), 1) > @@ -28,7 +27,9 @@ ifeq ($(DEBUG),0) > endif > endif > > -ifeq ($(CC_NO_CLANG), 0) > +ifeq ($(DEBUG),1) > + CFLAGS += -O0 > +else ifeq ($(CC_NO_CLANG), 0) > CFLAGS += -O3 > else > CFLAGS += -O6 > @@ -43,6 +44,8 @@ CFLAGS += -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE > > CFLAGS += -I$(srctree)/tools/include/ > > +CFLAGS += $(EXTRA_WARNINGS) $(EXTRA_CFLAGS) > + > SUBCMD_IN := $(OUTPUT)libsubcmd-in.o > > all: > -- > 2.23.0 -- - Arnaldo ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fixes issue when debugging debug builds of Perf. 2019-10-29 14:00 ` Arnaldo Carvalho de Melo @ 2019-10-29 14:18 ` Arnaldo Carvalho de Melo 2019-10-29 14:26 ` Arnaldo Carvalho de Melo 0 siblings, 1 reply; 6+ messages in thread From: Arnaldo Carvalho de Melo @ 2019-10-29 14:18 UTC (permalink / raw) To: James Clark Cc: linux-perf-users, linux-kernel, nd, Adrian Hunter, Ian Rogers, James Clark, Jiri Olsa, Josh Poimboeuf, Namhyung Kim Em Tue, Oct 29, 2019 at 11:00:52AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Oct 28, 2019 at 11:34:01AM +0000, James Clark escreveu: > > When a 'make DEBUG=1' build is done, the command parser > > is still built with -O6 and is hard to step through. > > > > This change also moves EXTRA_WARNINGS and EXTRA_FLAGS to > > the end of the compilation line, otherwise they cannot be > > used to override the default values. > > The patch came mangled, so I'm applying by hand, and separating it into > two patches, the first for the first paragraph and the other for the > second, ok? So, this is what I mean by mangled: diff --git a/tools/lib/subcmd/Makefile b/tools/lib/subcmd/Makefile index 5b2cd5e58df0..1c777a72bb39 100644 --- a/tools/lib/subcmd/Makefile +++ b/tools/lib/subcmd/Makefile @@ -19,8 +19,7 @@ MAKEFLAGS +=3D --no-print-directory =20 LIBFILE =3D $(OUTPUT)libsubcmd.a =20 -CFLAGS :=3D $(EXTRA_WARNINGS) $(EXTRA_CFLAGS) -CFLAGS +=3D -ggdb3 -Wall -Wextra -std=3Dgnu99 -fPIC +CFLAGS :=3D -ggdb3 -Wall -Wextra -std=3Dgnu99 -fPIC =20 ifeq ($(DEBUG),0) ifeq ($(feature-fortify-source), 1) @@ -28,7 +27,9 @@ ifeq ($(DEBUG),0) endif endif =20 -ifeq ($(CC_NO_CLANG), 0) -------------------- And here is the first patch out of your larger one, I changed the subject line to reflect that this is not tools/perf specific, as tools/objtool/ also uses libsubcmd, added Josh, objtool's maintainer so that he is made aware. Thanks, - Arnaldo commit a554275abf9f13054595d3155b835668dab74bf9 Author: James Clark <James.Clark@arm.com> Date: Mon Oct 28 11:34:01 2019 +0000 libsubcmd: Move EXTRA_FLAGS to the end to allow overriding existing flags Move EXTRA_WARNINGS and EXTRA_FLAGS to the end of the compilation line, otherwise they cannot be used to override the default values. Signed-off-by: James Clark <james.clark@arm.com> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Ian Rogers <irogers@google.com> Cc: James Clark <james.clark@arm.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: nd <nd@arm.com> Link: http://lore.kernel.org/lkml/20191028113340.4282-1-james.clark@arm.com [ split from a larger patch ] Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> diff --git a/tools/lib/subcmd/Makefile b/tools/lib/subcmd/Makefile index 5b2cd5e58df0..352c6062deba 100644 --- a/tools/lib/subcmd/Makefile +++ b/tools/lib/subcmd/Makefile @@ -19,8 +19,7 @@ MAKEFLAGS += --no-print-directory LIBFILE = $(OUTPUT)libsubcmd.a -CFLAGS := $(EXTRA_WARNINGS) $(EXTRA_CFLAGS) -CFLAGS += -ggdb3 -Wall -Wextra -std=gnu99 -fPIC +CFLAGS := -ggdb3 -Wall -Wextra -std=gnu99 -fPIC ifeq ($(DEBUG),0) ifeq ($(feature-fortify-source), 1) @@ -43,6 +42,8 @@ CFLAGS += -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE CFLAGS += -I$(srctree)/tools/include/ +CFLAGS += $(EXTRA_WARNINGS) $(EXTRA_CFLAGS) + SUBCMD_IN := $(OUTPUT)libsubcmd-in.o all: ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Fixes issue when debugging debug builds of Perf. 2019-10-29 14:18 ` Arnaldo Carvalho de Melo @ 2019-10-29 14:26 ` Arnaldo Carvalho de Melo 2019-10-30 11:03 ` James Clark 0 siblings, 1 reply; 6+ messages in thread From: Arnaldo Carvalho de Melo @ 2019-10-29 14:26 UTC (permalink / raw) To: James Clark Cc: linux-perf-users, linux-kernel, nd, Adrian Hunter, Ian Rogers, Jiri Olsa, Josh Poimboeuf, Namhyung Kim Em Tue, Oct 29, 2019 at 11:18:52AM -0300, Arnaldo Carvalho de Melo escreveu: > And here is the first patch out of your larger one, I changed the > subject line to reflect that this is not tools/perf specific, as > tools/objtool/ also uses libsubcmd, added Josh, objtool's maintainer so > that he is made aware. And the second patch: commit d0381449fd9ab733ec2daf527263da9f73f1e94e Author: James Clark <James.Clark@arm.com> Date: Mon Oct 28 11:34:01 2019 +0000 libsubcmd: Use -O0 with DEBUG=1 When a 'make DEBUG=1' build is done, the command parser is still built with -O6 and is hard to step through, fix it making it use -O0 in that case. Signed-off-by: James Clark <james.clark@arm.com> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Ian Rogers <irogers@google.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: nd <nd@arm.com> Link: http://lore.kernel.org/lkml/20191028113340.4282-1-james.clark@arm.com [ split from a larger patch ] Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> diff --git a/tools/lib/subcmd/Makefile b/tools/lib/subcmd/Makefile index 352c6062deba..1c777a72bb39 100644 --- a/tools/lib/subcmd/Makefile +++ b/tools/lib/subcmd/Makefile @@ -27,7 +27,9 @@ ifeq ($(DEBUG),0) endif endif -ifeq ($(CC_NO_CLANG), 0) +ifeq ($(DEBUG),1) + CFLAGS += -O0 +else ifeq ($(CC_NO_CLANG), 0) CFLAGS += -O3 else CFLAGS += -O6 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Fixes issue when debugging debug builds of Perf. 2019-10-29 14:26 ` Arnaldo Carvalho de Melo @ 2019-10-30 11:03 ` James Clark 2019-10-30 15:13 ` Arnaldo Carvalho de Melo 0 siblings, 1 reply; 6+ messages in thread From: James Clark @ 2019-10-30 11:03 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, nd, Adrian Hunter, Ian Rogers, Jiri Olsa, Josh Poimboeuf, Namhyung Kim Hi Arnaldo, Thanks for that, yes separating them looks better. I will try to break down commits in the future. > The patch came mangled, so I'm applying by hand, and separating it into > two patches, the first for the first paragraph and the other for the > second, ok? By mangled do you mean the quoted printables "=3D" and "=20"? It seems like git send-email falls back to this behavior by default: --transfer-encoding=(7bit|8bit|quoted-printable|base64|auto) Specify the transfer encoding to be used to send the message over SMTP. 7bit will fail upon encountering a non-ASCII message. quoted-printable can be useful when the repository contains files that contain carriage returns, but makes the raw patch email file (as saved from a MUA) much harder to inspect manually. base64 is even more fool proof, but also even more opaque. auto will use 8bit when possible, and quoted-printable otherwise. I copied my raw patch and was able to successfully apply it with git am, even with this escaping. Although I did upgrade to a newer version of git (2.23.0). If I view the patch that you created, then it doesn't have quoted printable escaping. So there does seem to be a difference somewhere. Do you think I should use "git send-email --transfer-encoding=7bit"? Thanks James On 29/10/2019 14:26, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 29, 2019 at 11:18:52AM -0300, Arnaldo Carvalho de Melo escreveu: >> And here is the first patch out of your larger one, I changed the >> subject line to reflect that this is not tools/perf specific, as >> tools/objtool/ also uses libsubcmd, added Josh, objtool's maintainer so >> that he is made aware. > > And the second patch: > > > commit d0381449fd9ab733ec2daf527263da9f73f1e94e > Author: James Clark <James.Clark@arm.com> > Date: Mon Oct 28 11:34:01 2019 +0000 > > libsubcmd: Use -O0 with DEBUG=1 > > When a 'make DEBUG=1' build is done, the command parser is still built > with -O6 and is hard to step through, fix it making it use -O0 in that > case. > > Signed-off-by: James Clark <james.clark@arm.com> > Cc: Adrian Hunter <adrian.hunter@intel.com> > Cc: Ian Rogers <irogers@google.com> > Cc: Jiri Olsa <jolsa@kernel.org> > Cc: Josh Poimboeuf <jpoimboe@redhat.com> > Cc: Namhyung Kim <namhyung@kernel.org> > Cc: nd <nd@arm.com> > Link: http://lore.kernel.org/lkml/20191028113340.4282-1-james.clark@arm.com > [ split from a larger patch ] > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > diff --git a/tools/lib/subcmd/Makefile b/tools/lib/subcmd/Makefile > index 352c6062deba..1c777a72bb39 100644 > --- a/tools/lib/subcmd/Makefile > +++ b/tools/lib/subcmd/Makefile > @@ -27,7 +27,9 @@ ifeq ($(DEBUG),0) > endif > endif > > -ifeq ($(CC_NO_CLANG), 0) > +ifeq ($(DEBUG),1) > + CFLAGS += -O0 > +else ifeq ($(CC_NO_CLANG), 0) > CFLAGS += -O3 > else > CFLAGS += -O6 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fixes issue when debugging debug builds of Perf. 2019-10-30 11:03 ` James Clark @ 2019-10-30 15:13 ` Arnaldo Carvalho de Melo 0 siblings, 0 replies; 6+ messages in thread From: Arnaldo Carvalho de Melo @ 2019-10-30 15:13 UTC (permalink / raw) To: James Clark Cc: Arnaldo Carvalho de Melo, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, nd, Adrian Hunter, Ian Rogers, Jiri Olsa, Josh Poimboeuf, Namhyung Kim Em Wed, Oct 30, 2019 at 11:03:43AM +0000, James Clark escreveu: > Hi Arnaldo, > > Thanks for that, yes separating them looks better. > I will try to break down commits in the future. > > > The patch came mangled, so I'm applying by hand, and separating it into > > two patches, the first for the first paragraph and the other for the > > second, ok? > > By mangled do you mean the quoted printables "=3D" and "=20"? > > It seems like git send-email falls back to this behavior by default: > > > --transfer-encoding=(7bit|8bit|quoted-printable|base64|auto) > > Specify the transfer encoding to be used to send the message over SMTP. > 7bit will fail upon encountering a non-ASCII message. quoted-printable can be > useful when the repository contains files that contain carriage returns, but > makes the raw patch email file (as saved from a MUA) much harder to inspect > manually. base64 is even more fool proof, but also even more opaque. auto will > use 8bit when possible, and quoted-printable otherwise. > > > I copied my raw patch and was able to successfully apply it with git am, even with this escaping. Although I > did upgrade to a newer version of git (2.23.0). > > If I view the patch that you created, then it doesn't have quoted printable escaping. So there does > seem to be a difference somewhere. > Do you think I should use "git send-email --transfer-encoding=7bit"? Well, I'm using mutt defaults, I'd say take a look at: ~/git/linux/Documentation/process/email-clients.rst There is a sesion for your mail agent, maybe it helps. - Arnaldo > > Thanks > James > > On 29/10/2019 14:26, Arnaldo Carvalho de Melo wrote: > > Em Tue, Oct 29, 2019 at 11:18:52AM -0300, Arnaldo Carvalho de Melo escreveu: > >> And here is the first patch out of your larger one, I changed the > >> subject line to reflect that this is not tools/perf specific, as > >> tools/objtool/ also uses libsubcmd, added Josh, objtool's maintainer so > >> that he is made aware. > > > > And the second patch: > > > > > > commit d0381449fd9ab733ec2daf527263da9f73f1e94e > > Author: James Clark <James.Clark@arm.com> > > Date: Mon Oct 28 11:34:01 2019 +0000 > > > > libsubcmd: Use -O0 with DEBUG=1 > > > > When a 'make DEBUG=1' build is done, the command parser is still built > > with -O6 and is hard to step through, fix it making it use -O0 in that > > case. > > > > Signed-off-by: James Clark <james.clark@arm.com> > > Cc: Adrian Hunter <adrian.hunter@intel.com> > > Cc: Ian Rogers <irogers@google.com> > > Cc: Jiri Olsa <jolsa@kernel.org> > > Cc: Josh Poimboeuf <jpoimboe@redhat.com> > > Cc: Namhyung Kim <namhyung@kernel.org> > > Cc: nd <nd@arm.com> > > Link: http://lore.kernel.org/lkml/20191028113340.4282-1-james.clark@arm.com > > [ split from a larger patch ] > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > > > diff --git a/tools/lib/subcmd/Makefile b/tools/lib/subcmd/Makefile > > index 352c6062deba..1c777a72bb39 100644 > > --- a/tools/lib/subcmd/Makefile > > +++ b/tools/lib/subcmd/Makefile > > @@ -27,7 +27,9 @@ ifeq ($(DEBUG),0) > > endif > > endif > > > > -ifeq ($(CC_NO_CLANG), 0) > > +ifeq ($(DEBUG),1) > > + CFLAGS += -O0 > > +else ifeq ($(CC_NO_CLANG), 0) > > CFLAGS += -O3 > > else > > CFLAGS += -O6 > > -- - Arnaldo ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-30 15:13 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-10-28 11:34 [PATCH] Fixes issue when debugging debug builds of Perf James Clark 2019-10-29 14:00 ` Arnaldo Carvalho de Melo 2019-10-29 14:18 ` Arnaldo Carvalho de Melo 2019-10-29 14:26 ` Arnaldo Carvalho de Melo 2019-10-30 11:03 ` James Clark 2019-10-30 15:13 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).