From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Olsa Subject: Re: [PATCH 12/12] perf maps: Set maps pointer in the kmap area for kernel maps Date: Wed, 18 Dec 2019 10:07:07 +0100 Message-ID: <20191218090707.GF19062@krava> References: <20191217144828.2460-1-acme@kernel.org> <20191217144828.2460-13-acme@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191217144828.2460-13-acme@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Namhyung Kim , Ingo Molnar , Thomas Gleixner , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter List-Id: linux-perf-users.vger.kernel.org On Tue, Dec 17, 2019 at 11:48:28AM -0300, Arnaldo Carvalho de Melo wrote: SNIP > > @@ -1098,7 +1097,6 @@ __machine__create_kernel_maps(struct machine *machine, struct dso *kernel) > if (!kmap) > return -1; > > - kmap->kmaps = &machine->kmaps; > maps__insert(&machine->kmaps, map); > > return 0; > diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c > index fdd5bddb3075..a2cdfe62df94 100644 > --- a/tools/perf/util/map.c > +++ b/tools/perf/util/map.c > @@ -223,7 +223,7 @@ struct map *map__new(struct machine *machine, u64 start, u64 len, > * they are loaded) and for vmlinux, where only after we load all the > * symbols we'll know where it starts and ends. > */ > -struct map *map__new2(u64 start, struct dso *dso) > +struct map *map__new2(u64 start, struct dso *dso, struct maps *kmaps) hum, how about map__new? kernel maps could go throught that as well, right? jirka