From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Olsa Subject: Re: [PATCH] tools lib api fs: Move cgroupsfs_find_mountpoint() Date: Mon, 27 Jan 2020 17:22:22 +0100 Message-ID: <20200127162222.GG1114818@krava> References: <20200127100031.1368732-1-namhyung@kernel.org> <20200127111234.GA1114818@krava> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , LKML , linux-perf-users List-Id: linux-perf-users.vger.kernel.org On Mon, Jan 27, 2020 at 11:58:27PM +0900, Namhyung Kim wrote: > Hi Jiri, > > On Mon, Jan 27, 2020 at 8:12 PM Jiri Olsa wrote: > > > > On Mon, Jan 27, 2020 at 07:00:31PM +0900, Namhyung Kim wrote: > > > > SNIP > > > > > - > > > - if (strlen(path) < maxlen) { > > > - strcpy(buf, path); > > > - return 0; > > > - } > > > - return -1; > > > -} > > > - > > > static int open_cgroup(const char *name) > > > { > > > char path[PATH_MAX + 1]; > > > @@ -79,7 +20,7 @@ static int open_cgroup(const char *name) > > > int fd; > > > > > > > > > - if (cgroupfs_find_mountpoint(mnt, PATH_MAX + 1)) > > > + if (cgroupfs_find_mountpoint(mnt, PATH_MAX + 1, "perf_event")) > > > > nice, but could you please follow fs API names and change the > > name to cgroupfs__mountpoint > > > > I think we don't need to define the rest of the functions now, > > if they are not used > > > > #define FS(name) \ > > const char *name##__mountpoint(void); \ > > const char *name##__mount(void); \ > > bool name##__configured(void); \ > > > > just follow the function name > > I thought about it too, but still it has different arguments. > So I left it as is... Do you really want to rename? yea I think we should keep the same name, Arnaldo? jirka > > Thanks > Namhyung >