From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Thomas Richter <tmricht@linux.ibm.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
gor@linux.ibm.com, sumanthk@linux.ibm.com,
heiko.carstens@de.ibm.com
Subject: Re: [PATCH] perf symbol: Fix kernel symbol address display
Date: Fri, 24 Apr 2020 12:06:31 -0300 [thread overview]
Message-ID: <20200424150631.GN19437@kernel.org> (raw)
In-Reply-To: <475a5c86-2be3-4f12-56f3-7bd6587e8ec3@linux.ibm.com>
Em Fri, Apr 24, 2020 at 02:37:01PM +0200, Thomas Richter escreveu:
> On 4/20/20 10:46 PM, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Apr 15, 2020 at 09:07:44AM +0200, Thomas Richter escreveu:
> >> Running commands
> >>
> >> ./perf record -e rb0000 -- find .
> >> ./perf report -v
> >
> > Or when pressing 'V' in the TUI.
> >
> >> reveals symbol names and its addresses. There is a mismatch between
> >
> > Yeah, an address that at some point was put there to help with debugging
> > the symbol resolution, IIRC how it looked like when looking at
> >
> > readelf -sW vmlinux
> >
> > Or any other DSO, for instance, for a glibc symbol here:
> >
> > Using 'perf report -s pid,dso,sym' then pressing 'V':
> >
> > 1.55% 20325:perf /usr/lib64/libc-2.30.so 0x161825 B [.] __strlen_avx2
> >
> > [acme@five perf]$ readelf -sW /usr/lib64/libc-2.30.so | grep strlen_avx2
> > 24371: 0000000000161810 414 FUNC LOCAL DEFAULT 15 __strlen_avx2
> > [acme@five perf]$
> >
> > Can you check if doing in /lib/modules/.../build/vmlinux produces what
> > appears when 'V' is in place?
> >
> > And perhaps we can also show the DSO offset and the rip as it gets laid
> > out in memory in the end? So we have all the informations?
> >
> > - Arnaldo
> >
>
> Arnaldo,
>
> having verified this also works in the TUI mode using 'V', are you going to pick
> this patch?
That would be a change in behaviour, the original intent was to show the
value one would get from the ELF symbol table, isn't that the case?
That is why I asked if you would think that providing the information
you want, which is matching to what is in kallsyms, would be
interesting, which I think it is, but how? showing the vmlinux offset
somehow?
> Thanks
>
>
> --
> Thomas Richter, Dept 3252, IBM s390 Linux Development, Boeblingen, Germany
> --
> Vorsitzender des Aufsichtsrats: Matthias Hartmann
> Geschäftsführung: Dirk Wittkopp
> Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294
--
- Arnaldo
next prev parent reply other threads:[~2020-04-24 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 7:07 [PATCH] perf symbol: Fix kernel symbol address display Thomas Richter
2020-04-20 20:46 ` Arnaldo Carvalho de Melo
2020-04-21 11:18 ` Thomas Richter
2020-04-24 12:37 ` Thomas Richter
2020-04-24 15:06 ` Arnaldo Carvalho de Melo [this message]
2020-04-24 18:01 ` Thomas Richter
2020-04-24 18:23 ` Arnaldo Carvalho de Melo
2020-04-27 12:23 ` Thomas Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424150631.GN19437@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sumanthk@linux.ibm.com \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).