From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Olsa Subject: Re: [PATCH 4/7] perf bpf: Decouple creating the evlist from adding the SB event Date: Tue, 28 Apr 2020 11:48:51 +0200 Message-ID: <20200428094851.GE1476763@krava> References: <20200427211935.25789-1-acme@kernel.org> <20200427211935.25789-5-acme@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200427211935.25789-5-acme@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Namhyung Kim , Ingo Molnar , Thomas Gleixner , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter , Song Liu List-Id: linux-perf-users.vger.kernel.org On Mon, Apr 27, 2020 at 06:19:32PM -0300, Arnaldo Carvalho de Melo wrote: > From: Arnaldo Carvalho de Melo > > Renaming bpf_event__add_sb_event() to evlist__add_sb_event() and > requiring that the evlist be allocated beforehand. hum, this seems to be done in previous patch, maybe you need to squash this with the previous one? jirka > > This will allow using the same side band thread and evlist to be used > for multiple purposes in addition to react to PERF_RECORD_BPF_EVENT soon > after they are generated. > > Cc: Adrian Hunter > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Song Liu > Signed-off-by: Arnaldo Carvalho de Melo > --- > tools/perf/util/bpf-event.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/bpf-event.h b/tools/perf/util/bpf-event.h > index 2c7a50509659..68f315c3df5b 100644 > --- a/tools/perf/util/bpf-event.h > +++ b/tools/perf/util/bpf-event.h > @@ -45,7 +45,7 @@ static inline int machine__process_bpf(struct machine *machine __maybe_unused, > return 0; > } > > -static inline int evlist__add_bpf_sb_event(struct evlist **evlist __maybe_unused, > +static inline int evlist__add_bpf_sb_event(struct evlist *evlist __maybe_unused, > struct perf_env *env __maybe_unused) > { > return 0; > -- > 2.21.1 >