From: Jiri Olsa <jolsa@redhat.com>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
Haiyan Song <haiyanx.song@intel.com>,
Jin Yao <yao.jin@linux.intel.com>,
Song Liu <songliubraving@fb.com>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
John Garry <john.garry@huawei.com>, Leo Yan <leo.yan@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Paul Clarke <pc@us.ibm.com>,
linux-kernel@vger.kernel.org, kajoljain <kjain@linux.ibm.com>,
linux-perf-users@vger.kernel.org,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v3 00/12] perf metric fixes and test
Date: Fri, 1 May 2020 12:35:19 +0200 [thread overview]
Message-ID: <20200501103519.GB1789042@krava> (raw)
In-Reply-To: <20200430075144.132716-1-irogers@google.com>
On Thu, Apr 30, 2020 at 12:51:32AM -0700, Ian Rogers wrote:
> Add a test that all perf metrics (for your architecture) are parsable
> with the simple expression parser. Attempt to parse all events in
> metrics but only fail if the metric is for the current CPU. Fix bugs
> in the expr parser, x86 and powerpc metrics. Improve debug messages
> around add PMU config term failures.
>
> v3 adds parse event testing of ids and improves debug messages for add
> PMU. These messages are paticular visible with 'perf test 10
> -vvv'. It moves the testing logic from tests/expr.c to
> tests/pmu-events.c as suggested by John Garry
> <john.garry@huawei.com>.
> v2 adds Fixes tags to commit messages for when broken metrics were
> first added. Adds a debug warning for division by zero in expr, and
> adds a workaround for id values in the expr test necessary for
> powerpc. It also fixes broken power8 and power9 metrics.
>
> Ian Rogers (12):
> perf expr: unlimited escaped characters in a symbol
> perf metrics: fix parse errors in cascade lake metrics
> perf metrics: fix parse errors in skylake metrics
> perf expr: allow ',' to be an other token
> perf expr: increase max other
> perf expr: parse numbers as doubles
> perf expr: debug lex if debugging yacc
> perf metrics: fix parse errors in power8 metrics
> perf metrics: fix parse errors in power9 metrics
> perf expr: print a debug message for division by zero
> perf parse-events: expand add PMU error/verbose messages
> perf test: improve pmu event metric testing
this does not apply on top of changes from Kajol Jain
which are now in Arnaldo's perf/core.. could you please
rebase?
thanks,
jirka
next prev parent reply other threads:[~2020-05-01 10:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 7:51 [PATCH v3 00/12] perf metric fixes and test Ian Rogers
2020-04-30 7:51 ` [PATCH v3 01/12] perf expr: unlimited escaped characters in a symbol Ian Rogers
2020-04-30 7:51 ` [PATCH v3 02/12] perf metrics: fix parse errors in cascade lake metrics Ian Rogers
2020-04-30 7:51 ` [PATCH v3 03/12] perf metrics: fix parse errors in skylake metrics Ian Rogers
2020-04-30 7:51 ` [PATCH v3 04/12] perf expr: allow ',' to be an other token Ian Rogers
2020-04-30 7:51 ` [PATCH v3 05/12] perf expr: increase max other Ian Rogers
2020-04-30 7:51 ` [PATCH v3 06/12] perf expr: parse numbers as doubles Ian Rogers
2020-04-30 7:51 ` [PATCH v3 07/12] perf expr: debug lex if debugging yacc Ian Rogers
2020-04-30 7:51 ` [PATCH v3 08/12] perf metrics: fix parse errors in power8 metrics Ian Rogers
2020-04-30 7:51 ` [PATCH v3 09/12] perf metrics: fix parse errors in power9 metrics Ian Rogers
2020-04-30 7:51 ` [PATCH v3 10/12] perf expr: print a debug message for division by zero Ian Rogers
2020-04-30 7:51 ` [PATCH v3 11/12] perf parse-events: expand add PMU error/verbose messages Ian Rogers
2020-04-30 7:51 ` [PATCH v3 12/12] perf test: improve pmu event metric testing Ian Rogers
2020-04-30 11:44 ` John Garry
2020-04-30 14:31 ` Ian Rogers
2020-04-30 17:53 ` John Garry
2020-05-01 10:35 ` Jiri Olsa [this message]
2020-05-01 17:39 ` [PATCH v3 00/12] perf metric fixes and test Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501103519.GB1789042@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=haiyanx.song@intel.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=songliubraving@fb.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox