From: Jiri Olsa <jolsa@redhat.com>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
Haiyan Song <haiyanx.song@intel.com>,
Jin Yao <yao.jin@linux.intel.com>,
Song Liu <songliubraving@fb.com>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
John Garry <john.garry@huawei.com>, Leo Yan <leo.yan@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Paul Clarke <pc@us.ibm.com>, LKML <linux-kernel@vger.kernel.org>,
kajoljain <kjain@linux.ibm.com>,
linux-perf-users <linux-perf-users@vger.kernel.org>,
Stephane
Subject: Re: [PATCH v4 12/12] perf test: improve pmu event metric testing
Date: Mon, 4 May 2020 00:16:50 +0200 [thread overview]
Message-ID: <20200503221650.GA1916255@krava> (raw)
In-Reply-To: <CAP-5=fVaLWVyxweesWYCj1=FFubM3t6OsF1Jd46d=FtsQUQVmQ@mail.gmail.com>
On Sun, May 03, 2020 at 10:31:37AM -0700, Ian Rogers wrote:
SNIP
> > >
> > > This looks like a bug in skl-metrics.json:
> > >
> > > {
> > > "BriefDescription": "Average number of parallel data read
> > > requests to external memory. Accounts for demand loads and L1/L2
> > > prefetches",
> > > "MetricExpr": "arb@event\\=0x80\\,umask\\=0x2@ /
> > > arb@event\\=0x80\\,umask\\=0x2\\,thresh\\=1@",
> > > "MetricGroup": "Memory_BW",
> > > "MetricName": "DRAM_Parallel_Reads"
> > > },
> > >
> > > which can be fixed by removing "\\,thresh\\=1" but looking at the
> > > expression this will just make the expression yield a value of 1. As
> > > this is an Intel json file could they comment? Jiri, could you be
> > > missing a patch on the kernel side? We could lower this failure to
> > > just a diagnostic message to land this set of patches, let me know
> > > what you'd like me to do.
> >
> > I applied this on current Arnaldo's perf/core.. not sure there's
> > more pending changes out there
> >
> > I'd like not to delay this patchset too long.. could we push the
> > first 10 patches and solve the rest in separate change?
>
> Thanks, I've attached a patch that can be squashed into 12 to make the
> error non-fatal. Patch 11 is trying to make the diagnostics around
> adding a PMU event clearer and aside warning messages, and removal of,
> has no functional effect. I don't mind the first 10 being merged and
> these coming later. I don't mind just patch 11 coming later as it'd be
> nice to have the test so metrics can get fixed.
sounds good, for patches 1 - 10:
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
next prev parent reply other threads:[~2020-05-03 22:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 17:33 [PATCH v4 00/12] perf metric fixes and test Ian Rogers
2020-05-01 17:33 ` [PATCH v4 01/12] perf expr: unlimited escaped characters in a symbol Ian Rogers
2020-05-04 6:48 ` kajoljain
2020-05-01 17:33 ` [PATCH v4 02/12] perf metrics: fix parse errors in cascade lake metrics Ian Rogers
2020-05-01 17:33 ` [PATCH v4 03/12] perf metrics: fix parse errors in skylake metrics Ian Rogers
2020-05-01 17:33 ` [PATCH v4 04/12] perf expr: allow ',' to be an other token Ian Rogers
2020-05-01 17:33 ` [PATCH v4 05/12] perf expr: increase max other Ian Rogers
2020-05-01 17:33 ` [PATCH v4 06/12] perf expr: parse numbers as doubles Ian Rogers
2020-05-04 6:50 ` kajoljain
2020-05-01 17:33 ` [PATCH v4 07/12] perf expr: debug lex if debugging yacc Ian Rogers
2020-05-01 17:33 ` [PATCH v4 08/12] perf metrics: fix parse errors in power8 metrics Ian Rogers
2020-05-01 17:33 ` [PATCH v4 09/12] perf metrics: fix parse errors in power9 metrics Ian Rogers
2020-05-01 17:33 ` [PATCH v4 10/12] perf expr: print a debug message for division by zero Ian Rogers
2020-05-01 17:33 ` [PATCH v4 11/12] perf parse-events: expand add PMU error/verbose messages Ian Rogers
2020-05-01 17:33 ` [PATCH v4 12/12] perf test: improve pmu event metric testing Ian Rogers
[not found] ` <20200503145553.GA1865281@krava>
[not found] ` <CAP-5=fXrwcz+MMF0Dqd_UnoXoTo1iO7T3-ENX0fzytPmJWmtoA@mail.gmail.com>
2020-05-03 17:06 ` Jiri Olsa
2020-05-03 17:31 ` Ian Rogers
2020-05-03 22:16 ` Jiri Olsa [this message]
2020-05-07 8:44 ` [PATCH v4 00/12] perf metric fixes and test Jiri Olsa
2020-05-07 16:00 ` Arnaldo Carvalho de Melo
2020-05-11 15:32 ` Arnaldo Carvalho de Melo
2020-05-11 16:12 ` Ian Rogers
2020-05-13 6:32 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200503221650.GA1916255@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=haiyanx.song@intel.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=songliubraving@fb.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).