From: Jiri Olsa <jolsa@redhat.com>
To: Kajol Jain <kjain@linux.ibm.com>
Cc: acme@kernel.org, ak@linux.intel.com, yao.jin@linux.intel.com,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
irogers@google.com, maddy@linux.ibm.com,
ravi.bangoria@linux.ibm.com
Subject: Re: [RFC] perf/jevents: Add new structure to pass json fields.
Date: Wed, 26 Aug 2020 12:57:05 +0200 [thread overview]
Message-ID: <20200826105705.GD703542@krava> (raw)
In-Reply-To: <20200825074041.378520-1-kjain@linux.ibm.com>
On Tue, Aug 25, 2020 at 01:10:41PM +0530, Kajol Jain wrote:
SNIP
> diff --git a/tools/perf/pmu-events/jevents.h b/tools/perf/pmu-events/jevents.h
> index 2afc8304529e..e696edf70e9a 100644
> --- a/tools/perf/pmu-events/jevents.h
> +++ b/tools/perf/pmu-events/jevents.h
> @@ -2,14 +2,28 @@
> #ifndef JEVENTS_H
> #define JEVENTS_H 1
>
> +#include "pmu-events.h"
> +
> +struct json_event {
> + char *name;
> + char *event;
> + char *desc;
> + char *topic;
> + char *long_desc;
> + char *pmu;
> + char *unit;
> + char *perpkg;
> + char *metric_expr;
> + char *metric_name;
> + char *metric_group;
> + char *deprecated;
> + char *metric_constraint;
> +};
> +
> int json_events(const char *fn,
> - int (*func)(void *data, char *name, char *event, char *desc,
> - char *long_desc,
> - char *pmu,
> - char *unit, char *perpkg, char *metric_expr,
> - char *metric_name, char *metric_group,
> - char *deprecated, char *metric_constraint),
> - void *data);
> + int (*func)(void *data, struct json_event *je),
> + void *data);
please also add typedef for the function,
it's used in other places as well
thanks,
jirka
next prev parent reply other threads:[~2020-08-26 10:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 7:40 [RFC] perf/jevents: Add new structure to pass json fields Kajol Jain
2020-08-25 8:14 ` John Garry
2020-08-26 11:00 ` Jiri Olsa
2020-08-26 11:24 ` kajoljain
2020-08-26 11:33 ` John Garry
2020-08-27 12:57 ` kajoljain
2020-08-25 15:47 ` Andi Kleen
2020-08-26 11:25 ` kajoljain
2020-08-26 10:56 ` Jiri Olsa
2020-08-26 11:32 ` kajoljain
2020-08-26 11:59 ` Jiri Olsa
2020-08-27 12:58 ` kajoljain
2020-08-26 10:57 ` Jiri Olsa [this message]
2020-08-26 11:28 ` kajoljain
2020-08-26 10:57 ` Jiri Olsa
2020-08-26 11:33 ` kajoljain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826105705.GD703542@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=irogers@google.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=ravi.bangoria@linux.ibm.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).