linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC] perf/core: Fixes hung issue on perf stat command during cpu hotplug
@ 2020-08-26  9:32 Kajol Jain
  2020-08-26 13:21 ` Arnaldo Carvalho de Melo
  2020-08-27  8:37 ` [perf/core] 16fb162e78: WARNING:at_kernel/events/core.c:#list_add_event kernel test robot
  0 siblings, 2 replies; 5+ messages in thread
From: Kajol Jain @ 2020-08-26  9:32 UTC (permalink / raw)
  To: acme
  Cc: jolsa, linux-kernel, linux-perf-users, maddy, peterz, mingo,
	mark.rutland, alexander.shishkin, namhyung, daniel, brho, srikar,
	kjain

Commit 2ed6edd33a21 ("perf: Add cond_resched() to task_function_call()")
added assignment of ret value as -EAGAIN in case function
call to 'smp_call_function_single' fails.
For non-zero ret value, it did 
'ret = !ret ? data.ret : -EAGAIN;', which always
assign -EAGAIN to ret and make second if condition useless.

In scenarios like when executing a perf stat with --per-thread option, and 
if any of the monitoring cpu goes offline, the 'smp_call_function_single'
function could return -ENXIO, and with the above check,
task_function_call hung and increases CPU
usage (because of repeated 'smp_call_function_single()')

Recration scenario:
	# perf stat -a --per-thread && (offline a CPU )

Patch here removes the tertiary condition added as part of that 
commit and added a check for NULL and -EAGAIN.

Fixes: 2ed6edd33a21("perf: Add cond_resched() to task_function_call()")
Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
Reported-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
---
 kernel/events/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 5bfe8e3c6e44..330c53f7df9c 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -115,9 +115,9 @@ task_function_call(struct task_struct *p, remote_function_f func, void *info)
 	for (;;) {
 		ret = smp_call_function_single(task_cpu(p), remote_function,
 					       &data, 1);
-		ret = !ret ? data.ret : -EAGAIN;
-
-		if (ret != -EAGAIN)
+		if (!ret)
+			ret = data.ret;
+		else if (ret != -EAGAIN)
 			break;
 
 		cond_resched();
-- 
2.26.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-27 13:02 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-26  9:32 [RFC] perf/core: Fixes hung issue on perf stat command during cpu hotplug Kajol Jain
2020-08-26 13:21 ` Arnaldo Carvalho de Melo
2020-08-26 14:37   ` kajoljain
2020-08-27  8:37 ` [perf/core] 16fb162e78: WARNING:at_kernel/events/core.c:#list_add_event kernel test robot
2020-08-27 13:02   ` kajoljain

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).