From: Kajol Jain <kjain@linux.ibm.com>
To: acme@kernel.org
Cc: peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, pc@us.ibm.com,
jolsa@redhat.com, namhyung@kernel.org, ak@linux.intel.com,
yao.jin@linux.intel.com, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, irogers@google.com,
maddy@linux.ibm.com, ravi.bangoria@linux.ibm.com,
john.garry@huawei.com, kjain@linux.ibm.com
Subject: [PATCH v7 0/5] powerpc/perf: Add json file support for hv_24x7 core level events
Date: Wed, 2 Sep 2020 21:34:34 +0530 [thread overview]
Message-ID: <20200902160439.335232-1-kjain@linux.ibm.com> (raw)
Patchset enhance current runtime parameter support. It introduces new
fields like "PerChip" and "PerCore" similar to the field "PerPkg" which is
used to specify perpkg events.
The "PerCore" and "PerChip" specifies whether its core or chip events.
Based on which we can decide which runtime parameter user want to
access. Now character '?' can refers different parameter based on user
requirement.
Initially, every time we want to add new terms like chip, core, thread
etc, we need to create corrsponding fields in pmu_events and event
struct.
This patchset adds an enum called 'aggr_mode_class' which store all these
aggregation like perchip/percore. It also adds new field 'AggregationMode'
to capture these terms.
Now, if user wants to add any new term, they just need to add it in
the enum defined.
This patchset also adds changes of adding new structure
called 'json_event' inside jevents.h
file to improve the callback prototype inside jevent files.
Initially, whenever user want to add new field, they need to update
in all function callback which makes it more and more complex with
increased number of parmeters.
With this change, we just need to add it in new structure 'json_event'.
link to the patch: https://lkml.org/lkml/2020/8/25/217
Changelog:
v6 -> v7
- Remove min and get_cpu_str functions from jevents.c
- Make json_events function static to solve warning part [John Garry].
- Add event attribute in json_events function to remove strcpy from
real_event function, as suggested by Jiri Olsa.
- Add warning while checking aggr_mode value [Jiri Olsa].
v5 -> v6
- Made changes to improve callback prototype inside jevent file
by adding new struture 'json_event' as suggested by Andi Kleen.
- Added Reviewd-by tag from Andi Kleen
- Made changes suggested by Jiri Olsa and John garry includes:
- Removing jevents.h file.
- Some nits like freeing je->event mem, adding typedef for func
and not allocating mem for json_event structure.
- Added free for each field in json_event as suggested by
John Garry.
- In real_event function, rather then returning fixed structure
pointer, used strcpy to copy event to je->event field.
- Also merge some changes in this patch set from the patch-
https://lkml.org/lkml/2020/8/21/222. except nest event
change which was using capability of defining metric using other metric.
- Make power side changes as per new struture added.
Link to the previous version patchset: https://lkml.org/lkml/2020/8/27/799
Kajol Jain (5):
perf/jevents: Remove jevents.h file
perf/jevents: Add new structure to pass json fields.
perf jevents: Add support for parsing perchip/percore events
perf/tools: Pass pmu_event structure as a parameter for
arch_get_runtimeparam
perf/tools/pmu_events/powerpc: Add hv_24x7 core level metric events
tools/perf/arch/powerpc/util/header.c | 7 +-
.../arch/powerpc/power9/nest_metrics.json | 35 ++-
tools/perf/pmu-events/jevents.c | 234 +++++++++---------
tools/perf/pmu-events/jevents.h | 23 --
tools/perf/pmu-events/pmu-events.h | 6 +
tools/perf/util/metricgroup.c | 5 +-
tools/perf/util/metricgroup.h | 3 +-
7 files changed, 154 insertions(+), 159 deletions(-)
delete mode 100644 tools/perf/pmu-events/jevents.h
--
2.26.2
next reply other threads:[~2020-09-02 16:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 16:04 Kajol Jain [this message]
2020-09-02 16:04 ` [PATCH v7 1/5] perf/jevents: Remove jevents.h file Kajol Jain
2020-09-02 17:00 ` John Garry
2020-09-02 16:04 ` [PATCH v7 2/5] perf/jevents: Add new structure to pass json fields Kajol Jain
2020-09-02 17:05 ` John Garry
2020-09-04 8:29 ` kajoljain
2020-09-03 14:54 ` Namhyung Kim
2020-09-04 8:30 ` kajoljain
2020-09-02 16:04 ` [PATCH v7 3/5] perf jevents: Add support for parsing perchip/percore events Kajol Jain
2020-09-02 16:04 ` [PATCH v7 4/5] perf/tools: Pass pmu_event structure as a parameter for arch_get_runtimeparam Kajol Jain
2020-09-02 16:04 ` [PATCH v7 5/5] perf/tools/pmu_events/powerpc: Add hv_24x7 core level metric events Kajol Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902160439.335232-1-kjain@linux.ibm.com \
--to=kjain@linux.ibm.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).