linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Clark Williams <williams@redhat.com>,
	linux-perf-users@vger.kernel.org
Subject: Re: [BUG] perf probe can't remove probes
Date: Wed, 16 Dec 2020 10:59:29 -0300	[thread overview]
Message-ID: <20201216135929.GA294100@kernel.org> (raw)
In-Reply-To: <20201216091640.402d51e22dff04fff8ba6d79@kernel.org>

Em Wed, Dec 16, 2020 at 09:16:40AM +0900, Masami Hiramatsu escreveu:
> On Thu, 26 Nov 2020 14:26:03 -0300
 Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > Em Thu, Nov 26, 2020 at 09:21:25AM +0900, Masami Hiramatsu escreveu:
> > > On Wed, 25 Nov 2020 14:27:55 -0300 Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > > As you can see, "-D" is showing definition. Not delete. (*)
> > > Delete is "-d" or "--del".

> > Yeah, I was in a hurry and looked at just the first line right after the
> > command, didn't want to forget reporting it so sent the "bug" report,
> > d0h, sorry about the noise, using -d or --del works.

> > But having both -d and -D, in retrospect, wasn't such a good idea :-\
> 
> Sorry for confusing :(
 
> Hmm, would we better to remove -D and keep only --definition?
> But it is already there, I think we should keep this option
> for backward compatibility.

Nah, since we have it there, lets take this just as a lesson and in the
future use single letter options just for core functionality, leaving
things like --definition to be just a long option.

We can't change it now :-)

- Arnaldo

  reply	other threads:[~2020-12-16 14:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 17:27 [BUG] perf probe can't remove probes Arnaldo Carvalho de Melo
2020-11-26  0:21 ` Masami Hiramatsu
2020-11-26 17:26   ` Arnaldo Carvalho de Melo
2020-12-16  0:16     ` Masami Hiramatsu
2020-12-16 13:59       ` Arnaldo Carvalho de Melo [this message]
2020-12-01 13:25   ` Arnaldo Carvalho de Melo
2020-12-01 13:43     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201216135929.GA294100@kernel.org \
    --to=acme@kernel.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).