From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Nick Thompson <nathompson7@protonmail.com>
Cc: trivial@kernel.org, linux-perf-users@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH] perf config: Fix example command in manpage to conform to syntax specified in the SYNOPSIS section.
Date: Thu, 17 Dec 2020 11:38:30 -0300 [thread overview]
Message-ID: <20201217143830.GA309398@kernel.org> (raw)
In-Reply-To: <20201217142619.GA14524@redhat.com>
Em Thu, Dec 17, 2020 at 11:26:19AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Dec 16, 2020 at 05:29:43PM +0000, Nick Thompson escreveu:
> > Attached is a trivial fix to the syntax in the perf config man page.
>
>
> Thanks, I've added this to complement the commit log message, and as
> well your Signed-off-by, ok?
Oops, I mean this:
perf config: Fix example command in manpage to conform to syntax specified in the SYNOPSIS section.
Committer testing:
With the previously documented example:
$ perf config --user report sort-order=srcline
The config variable does not contain a section name: report
$
With the fixed example line:
$ perf config --user report.sort-order=srcline
$ perf config --user report.sort-order
report.sort-order=srcline
$
Signed-off-by: Nick Thompson <nathompson7@protonmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/linux-perf-users/20201217142619.GA14524@redhat.com/
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
prev parent reply other threads:[~2020-12-17 14:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4NRiGHoarpAH9Bm8v4IALfprSaF_-io8e27O4A486cEAHRfNccrU0jOWM4Bep37oMSUSNk565zwqiWac_l-nYQXfPBWgAtDjWBJVfO4SbrY=@protonmail.com>
2020-12-17 14:26 ` [PATCH] perf config: Fix example command in manpage to conform to syntax specified in the SYNOPSIS section Arnaldo Carvalho de Melo
2020-12-17 14:38 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217143830.GA309398@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=nathompson7@protonmail.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).