Re: [PATCH 1/3] perf core: Make local function perf_pmu_snapshot_aux() static

[Haocheng Xie <xiehaocheng.cn@gmail.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 1342 bytes --]

* Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Wed, May 26, 2021 at 07:52:18PM +0800, Haocheng Xie wrote:
> > Fixes the following W=1 kernel build warning:
> >   kernel/events/core.c:6670:6: warning: no previous prototype for 'perf_pmu_snapshot_aux' [-Wmissing-prototypes]
> >
> > Signed-off-by: Haocheng Xie <xiehaocheng.cn@gmail.com>
> > ---
> >  kernel/events/core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/events/core.c b/kernel/events/core.c
> > index 6fee4a7..0d98d6a 100644
> > --- a/kernel/events/core.c
> > +++ b/kernel/events/core.c
> > @@ -6667,7 +6667,7 @@ static unsigned long perf_prepare_sample_aux(struct perf_event *event,
> >       return data->aux_size;
> >  }
> >
> > -long perf_pmu_snapshot_aux(struct perf_buffer *rb,
> > +static long perf_pmu_snapshot_aux(struct perf_buffer *rb,
> >                          struct perf_event *event,
> >                          struct perf_output_handle *handle,
> >                          unsigned long size)
>
> Your $subject is broken (superfluous whitespace) and you've wrecked
> alignment of the arguments in the core.

Hi, Peter:
  Sorry for bothering you for these simple mistakes.
  I will optimize my patch series and send a "v2" version after that.

Thanks,

Haocheng Xie