From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D961FC4708F for ; Wed, 2 Jun 2021 13:02:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2532613DC for ; Wed, 2 Jun 2021 13:02:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229738AbhFBNEg (ORCPT ); Wed, 2 Jun 2021 09:04:36 -0400 Received: from mail-pf1-f181.google.com ([209.85.210.181]:46827 "EHLO mail-pf1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229665AbhFBNEf (ORCPT ); Wed, 2 Jun 2021 09:04:35 -0400 Received: by mail-pf1-f181.google.com with SMTP id y15so2090093pfn.13 for ; Wed, 02 Jun 2021 06:02:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YI37M6WTB9tOz3HBK6mip6CCX60bhaIRlELFRiHmBo8=; b=WPntc7Kz0gCfuC7el9Vy999j5F05xUwLTaT76ZzqgCUhdhbALv1Fh8zus1SEofEzDn gVUwQN3efdDCF8Ekt2wDxM+L0oZAWBwZ96YaYFmFKwxVA+hpWkd3bxiypQgfSjAoVV/Z 9SSKEuuvAublQXCeAyg0+QLtxoIQBBzQ+s5ZjJdpYdoP5ZOGg6i64ilxFsqQdP4fHjrE tmGx/oZjGny/ayR/SoYqLGLflzs6apQk2vO8kmaYYlrQpSJyQEh0s83LCgWNUjCDqIy/ c7/yrojLy+4smIAEz+4j5FmCz9nIgqAZHREzOhVD+ySv9d2kMEjzFpReAfSUIpc9Ask2 CR7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YI37M6WTB9tOz3HBK6mip6CCX60bhaIRlELFRiHmBo8=; b=CDXv6mvU0JOOvDz/LCaIpitkZV8NSruEwAa9svPRa0CWNzs1LZWHNgec1dgWOw/mCU gQyitVFRO/QzJAoxwIvsBgU9bYlpU8/N8jld+1OiT5EDjhOAbYErLWLHQlOajGsvjWb0 V/EMTOrP0FP3uxK1nVviSAnwsSdhKc66yRUK/N4l+kOfwBoFEcCzZjD/rz6TxDqLcp1d 8L6ESwHe/cGMILNVU7Me3SxceTqqzSFeiWFqu+ji5du/nbdXvWmr6iuXC1IDGAY12ghd BAPHQZsZA4U3v9nahnlsrcYRimVdoK++YBhSAT49kLgqPxcAVADwgZ7UwjypBv7ITEb+ wCCA== X-Gm-Message-State: AOAM5331ZWLJNPnW4/eeEEW9cFB4CozEt9syfP9qh5U7hJv++ae2RzoT ZzoJzgha9Bz+UvMFqrwW/J40Sg== X-Google-Smtp-Source: ABdhPJxNI77ZxyMoAz4JSba4wJsZgj88a5H7K2T0ZSPsUpwuJZZDEBhk50O02tQ/AXokHZ1pjXXqYQ== X-Received: by 2002:a63:ff22:: with SMTP id k34mr33546970pgi.336.1622638899656; Wed, 02 Jun 2021 06:01:39 -0700 (PDT) Received: from leoy-ThinkPad-X240s (ec2-18-167-84-74.ap-east-1.compute.amazonaws.com. [18.167.84.74]) by smtp.gmail.com with ESMTPSA id h13sm10991973pfv.213.2021.06.02.06.01.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 06:01:38 -0700 (PDT) Date: Wed, 2 Jun 2021 21:01:32 +0800 From: Leo Yan To: Adrian Hunter Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , x86@kernel.org, "H. Peter Anvin" , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Andi Kleen , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 6/8] perf auxtrace: Drop legacy __sync functions Message-ID: <20210602130132.GF10272@leoy-ThinkPad-X240s> References: <20210602103007.184993-1-leo.yan@linaro.org> <20210602103007.184993-7-leo.yan@linaro.org> <20210602111620.GD10272@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Wed, Jun 02, 2021 at 02:21:05PM +0300, Adrian Hunter wrote: > On 2/06/21 2:16 pm, Leo Yan wrote: > > Hi Adrian, > > > > On Wed, Jun 02, 2021 at 01:47:42PM +0300, Adrian Hunter wrote: > > > > [...] > > > >>> @@ -451,11 +445,7 @@ static inline u64 auxtrace_mmap__read_snapshot_head(struct auxtrace_mmap *mm) > >>> static inline u64 auxtrace_mmap__read_head(struct auxtrace_mmap *mm) > >>> { > >>> struct perf_event_mmap_page *pc = mm->userpg; > >>> -#if BITS_PER_LONG == 64 || !defined(HAVE_SYNC_COMPARE_AND_SWAP_SUPPORT) > >> > >> The test and setup for HAVE_SYNC_COMPARE_AND_SWAP_SUPPORT is not needed anymore either. > > > > Yes, I think there have two files should be cleaned: > > > > Makefile.config > > util/auxtrace.c > > > > If still miss anything, please let me know (I remembered there have a > > test case for __sync_xxx_compare_and_swap, but I cannot find it now, > > so this is why I am concern if I miss anything not). > > tools/build/feature/test-sync-compare-and-swap.c Thanks a lot!