From: Pavel Skripkin <paskripkin@gmail.com>
To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Pavel Skripkin <paskripkin@gmail.com>
Subject: [PATCH v2] perf: events: make perf_pmu_snapshot_aux static
Date: Wed, 9 Jun 2021 12:37:50 +0300 [thread overview]
Message-ID: <20210609093750.19198-1-paskripkin@gmail.com> (raw)
In-Reply-To: <YL+mziX+UU4MHQyZ@hirez.programming.kicks-ass.net>
Sparse says:
warning: symbol 'perf_pmu_snapshot_aux' was not declared. Should it be static?
Since perf_pmu_snapshot_aux() is not used outside this file,
it can be made static
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
---
Changes in v2:
Changed subject line
Fixed alignment of the arguments
---
kernel/events/core.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 6fee4a7e88d7..9ad01ff5692b 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -6667,10 +6667,10 @@ static unsigned long perf_prepare_sample_aux(struct perf_event *event,
return data->aux_size;
}
-long perf_pmu_snapshot_aux(struct perf_buffer *rb,
- struct perf_event *event,
- struct perf_output_handle *handle,
- unsigned long size)
+static long perf_pmu_snapshot_aux(struct perf_buffer *rb,
+ struct perf_event *event,
+ struct perf_output_handle *handle,
+ unsigned long size)
{
unsigned long flags;
long ret;
--
2.31.1
prev parent reply other threads:[~2021-06-09 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 16:22 [PATCH] events: core: make perf_pmu_snapshot_aux static Pavel Skripkin
2021-06-08 17:20 ` Peter Zijlstra
2021-06-09 9:37 ` Pavel Skripkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210609093750.19198-1-paskripkin@gmail.com \
--to=paskripkin@gmail.com \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).