From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: James Clark <james.clark@arm.com>
Cc: acme@kernel.org, coresight@lists.linaro.org, leo.yan@linaro.org,
al.grant@arm.com, branislav.rankov@arm.com, denik@chromium.org,
suzuki.poulose@arm.com, anshuman.khandual@arm.com,
Mike Leach <mike.leach@linaro.org>,
John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/1] perf cs-etm: Split Coresight decode by aux records
Date: Thu, 10 Jun 2021 09:52:25 -0600 [thread overview]
Message-ID: <20210610155225.GA34238@p14s> (raw)
In-Reply-To: <f92553c4-fe72-1a95-3f7c-f7a8481a0538@arm.com>
On Thu, Jun 10, 2021 at 04:55:27PM +0300, James Clark wrote:
>
>
> On 10/06/2021 13:36, James Clark wrote:
> > + return auxtrace_queues__add_event(&etm->queues,
> > + session,
> > + &auxtrace_fragment,
> > + file_offset,
> > + NULL);
>
> There's one more indentation error here that I will fix in the next set.
Yes, this one needs fixing and while at it you probably want to fix the stacking
as well:
return auxtrace_queues__add_event(&etm->queues, session,
&auxtrace_fragment,
file_offset, NULL);
Also look for "deccoding" at the end of the second paragraph in the changelog.
Thanks,
Mathieu
prev parent reply other threads:[~2021-06-10 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 10:36 [PATCH v5 0/1] perf cs-etm: Split Coresight decode by aux records James Clark
2021-06-10 10:36 ` [PATCH v5 1/1] " James Clark
2021-06-10 13:55 ` James Clark
2021-06-10 15:52 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610155225.GA34238@p14s \
--to=mathieu.poirier@linaro.org \
--cc=acme@kernel.org \
--cc=al.grant@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=branislav.rankov@arm.com \
--cc=coresight@lists.linaro.org \
--cc=denik@chromium.org \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=namhyung@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).