From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AB21C48BE5 for ; Sat, 12 Jun 2021 03:27:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0381360234 for ; Sat, 12 Jun 2021 03:27:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229931AbhFLD3g (ORCPT ); Fri, 11 Jun 2021 23:29:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229874AbhFLD3g (ORCPT ); Fri, 11 Jun 2021 23:29:36 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D467C061574 for ; Fri, 11 Jun 2021 20:27:28 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id x21-20020a17090aa395b029016e25313bfcso7055714pjp.2 for ; Fri, 11 Jun 2021 20:27:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wMbJzEFA4rizeAED4h0yeaNqBh4tC+L5roFT//ohrj0=; b=X5FQFhk4+/SkVAlz4VPwkLe6H0Ir6Dir/Hy625SgB2RA0op3Kd/4UsRqRLCbAKCoOx DuV67LDfpukyDdxC8Sv6272FEQqvkMjjjwRYm+M6Ck/g4NXuWx/3aMIBX9NTLSp3kXFf 8y21X5nKs4ZtFw4Hzdx/0f2/j8FD1OeA8/tsF2JatUOrGExLVPhnKBQXaSrg2ZUIrAuM 2U01NxNYsn70PIaNHN+XSl+HepOqAqvuBXf5aEOT0ffP+aadqkAJ7FGtkWiefLBhbDAL csMZ4qWtK2g2/2BzDzdd7jCZPiyeJpys5Xg5xNnz7BMavZkBxz01MhkKOBWDJl7XqVwj MKwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wMbJzEFA4rizeAED4h0yeaNqBh4tC+L5roFT//ohrj0=; b=lXrHIPc44yJmkBnYQb1mT0A7QzDYnRjD/a27r0D5dSlEJYzqYg/asE92zCEwdm6qx7 +irfRUHpiXoeNJkJuGA+V2pFynkdIq/5WHQpiPLhJt23uJZYMO1zPQR1c5/1nz14Lezi pwguDDUyrL1jfceJhDnj5UorYtFcqNv7MdRYAcn91Y2ehejdWDAezrSJvRv8+9bSo6ft t+0GlCDP8q8+TrooGrbRN2cd8DicLrpSGza/RY/KNrjxqJaKkvrFCFXJ2FVNt1SyiLNL OjdcgYwmFp47i0x2RMJZF9O7VAdC5JrLfxcP544GlIGkiqcrQZsgR5lQjUoObK87vXuh dWIA== X-Gm-Message-State: AOAM533T/NU56Zwy/jUWPoXejc2Tnx2GGlWMY8NvS1Eqjb2f367EVqyV AlMAE1I5pihA4dd4Wr8h4N4ssA== X-Google-Smtp-Source: ABdhPJytUShYTPDharDBywS2Z7+9/SAE4GGzuMWqdRZhU84lmAt50glv7oQXNpqThsQEZhK1FhfJ7w== X-Received: by 2002:a17:90a:f291:: with SMTP id fs17mr12148977pjb.8.1623468447896; Fri, 11 Jun 2021 20:27:27 -0700 (PDT) Received: from leoy-ThinkPad-X240s (ec2-18-167-84-74.ap-east-1.compute.amazonaws.com. [18.167.84.74]) by smtp.gmail.com with ESMTPSA id c130sm6176886pfc.51.2021.06.11.20.27.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jun 2021 20:27:27 -0700 (PDT) Date: Sat, 12 Jun 2021 11:27:21 +0800 From: Leo Yan To: Denis Nikitin Cc: Suzuki K Poulose , Arnaldo Carvalho de Melo , Mathieu Poirier , Mike Leach , Alexander Shishkin , John Garry , Will Deacon , Peter Zijlstra , Ingo Molnar , Jiri Olsa , Namhyung Kim , Daniel Kiss , Coresight ML , linux-arm-kernel , Linux Kernel Mailing List , linux-perf-users@vger.kernel.org Subject: Re: [PATCH v1 0/3] coresight: Fix for snapshot mode Message-ID: <20210612032721.GB36748@leoy-ThinkPad-X240s> References: <20210528161552.654907-1-leo.yan@linaro.org> <5cf3effb-fccc-9385-6328-6d1e2e5ccdf3@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Fri, Jun 11, 2021 at 01:31:41AM -0700, Denis Nikitin wrote: > Hi Suzuki, > > On Thu, Jun 10, 2021 at 9:04 AM Suzuki K Poulose wrote: > > > [...] > > > > Are you able to confirm if the patch 3 alone fixes the above issue ? > > I am not convinced that Patch 1 is necessary. > > > > Yes. "perf cs-etm: Remove callback cs_etm_find_snapshot()" alone fixes > the issue. Based on current testing result, we should give high priority for patches 2 and 3. The patch 1 is controversial for how to handle the trace data kept in multiple AUX buffers; essentially it's up to how we understand the snapshot definition. I confirmed Intel-PT and CoreSight have the same behaviour for capturing trace data from multiple AUX ring buffers when snapshot occurs. I'd like to leave patch 1/3 out, and resend it if we get conclusion. At the meantime, @Denis, if you have observed any profiling result (or profiling quality) difference caused by patch 1, the feedback would be very valuable. Thanks a lot for Denis' testing and insight review from Suzuki! Leo