From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0316C2B9F4 for ; Tue, 22 Jun 2021 12:58:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A32DD60720 for ; Tue, 22 Jun 2021 12:58:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231888AbhFVNAf (ORCPT ); Tue, 22 Jun 2021 09:00:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231897AbhFVNAe (ORCPT ); Tue, 22 Jun 2021 09:00:34 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AA25C061756 for ; Tue, 22 Jun 2021 05:58:19 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id z3-20020a17090a3983b029016bc232e40bso2207943pjb.4 for ; Tue, 22 Jun 2021 05:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=f9OF9+cTsV76jYHHpwVoZLDcZqPbxO7qKYzofSgo8Pg=; b=OFpxtQm5vLGwlFw+Me/BiyK4F1HGQ8R+ScFVH7VPPr9O6v+UFQ0giHLU6qr0zmDIiE EeBmtWHlaJhb20ucnFYs4oSmXHRtnGaXSyLjmyX9kOVzSyWlImVG9yDcQwkjcx/UwjzT 7XMgfiR4OXKa3i03c6fhDVJxFPfLHc4MwVF3WwJ/TUmjy4s/cPJw7SHu4mer/2Oblf/I t//Is8QJagddM2Qe6zyv14oXp88+5Z2DXGHe6ssdL6mwomllfQf3hqx+Uf0xcC8nabf5 wWVlYJ7UHGTIgPZPA/A3Kjp7H+deAehv5gYmrA+SOMGqE59ZukWnVnpRVlUbwWjEFud9 kPbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=f9OF9+cTsV76jYHHpwVoZLDcZqPbxO7qKYzofSgo8Pg=; b=GjMokRRlOMTZLUQq/W68MJ7Vv4pMc71JJndwNqEM29ZSRl8i1m+O0D0mKJkfpZj5l4 4hwIfR5u18HtAspqIW1iLgLbi9f9DQx2wkoHRmGXf2Nx42mwcLf6Taua2QY/WdORWrty MhSQox5MQoUv5Q8xElVWpMpnOBD+633Ol/krSlWjX0niSuIovCWRcDjuZFz5aUJx6sA0 Q5EklafS0d4TI0YYlcIWjNzOAuzTROknz5mM/TaFCiEcwrj4xX/qmcFlIW9Ig+NXkxME t94c01kjnhXYupQKTXElVq/r2Xak9/BQ+H9hXyROPALQEMmAN32J6ItXwqEocPBtDSHW GpMA== X-Gm-Message-State: AOAM530KeeYMY8304Tffp8uLMKttXz6aqRmVd0RQ8Ki8InU0eN9+h9Zv cucoepXtD5iNxw0afIqja+QILA== X-Google-Smtp-Source: ABdhPJwkdJz6qeGI/28xb2HvyjTPB3JsW/4fcQ3R7ItNNOrcmiGKsx5LiXIznOKMKFruA1ui4k4vYg== X-Received: by 2002:a17:90b:247:: with SMTP id fz7mr3877637pjb.137.1624366698531; Tue, 22 Jun 2021 05:58:18 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([202.155.204.36]) by smtp.gmail.com with ESMTPSA id u1sm17984196pfu.160.2021.06.22.05.58.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jun 2021 05:58:17 -0700 (PDT) Date: Tue, 22 Jun 2021 20:58:11 +0800 From: Leo Yan To: Denis Nikitin Cc: Suzuki K Poulose , Arnaldo Carvalho de Melo , Mathieu Poirier , Mike Leach , Alexander Shishkin , John Garry , Will Deacon , Peter Zijlstra , Ingo Molnar , Jiri Olsa , Namhyung Kim , Daniel Kiss , Coresight ML , linux-arm-kernel , Linux Kernel Mailing List , linux-perf-users@vger.kernel.org Subject: Re: [PATCH v1 0/3] coresight: Fix for snapshot mode Message-ID: <20210622125811.GB297306@leoy-ThinkPad-X240s> References: <20210528161552.654907-1-leo.yan@linaro.org> <5cf3effb-fccc-9385-6328-6d1e2e5ccdf3@arm.com> <20210612032721.GB36748@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Hi Denis, On Sun, Jun 20, 2021 at 10:21:57PM -1000, Denis Nikitin wrote: [...] > > I'd like to leave patch 1/3 out, and resend it if we get conclusion. > > At the meantime, @Denis, if you have observed any profiling result > > (or profiling quality) difference caused by patch 1, the feedback would > > be very valuable. > > I evaluated AutoFDO profiles with benchmarks but I was only focused > on the system-wide mode. And as I understood patch 1 fixes the issue > in non system-wide mode. Yes, patch 1 doesn't work for the system-wide mode. In the system-wide mode, CoreSight driver has its own reference counter to only allow the last CPU to fill trace data to AUX buffer. > Currently I'm OoO so I won't be able to do further evaluation. No problem, thanks for the feedback! Leo