From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AC4BC11F6D for ; Sun, 4 Jul 2021 23:10:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11B766195B for ; Sun, 4 Jul 2021 23:10:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232820AbhGDXNT (ORCPT ); Sun, 4 Jul 2021 19:13:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:48298 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232376AbhGDXMV (ORCPT ); Sun, 4 Jul 2021 19:12:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E45FA61474; Sun, 4 Jul 2021 23:08:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625440128; bh=kUZsgb8dfS/8kleJfRU5m1xSp/sKoanlCexjaXBYWZo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AVanrqIi2i2aG3J29D6AQTTczjp7zGzNTNuDkbC8TgpwFL2knfogvqEeMY5nuJv+x yK18kO78ew7s/KYRfnWQONb7hcJE0bGaZsRWjZw5ApZU4GkIzqVJbK64G8HF+rR126 sAPTvZMc3hO6DVIR6e36NL4SPuL0KTNINgd73uRLvnhWb6zmoA9fiMGVyhX/j4jNn8 I5vMvkxN0/We2tvuc6lhQWgatTAxE9I5kkV7u99SJI43IW1s0EqXpPXVWks8gbasl+ ffC1JXLt5kSJGSrPzHsQv1sETHnG/WAoKwIVWTQUTz0bhRaEy3EA16R8BNKOYB8reE hufTV+16BSp0w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tian Tao , Will Deacon , Sasha Levin , linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.10 32/70] arm64: perf: Convert snprintf to sysfs_emit Date: Sun, 4 Jul 2021 19:07:25 -0400 Message-Id: <20210704230804.1490078-32-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210704230804.1490078-1-sashal@kernel.org> References: <20210704230804.1490078-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org From: Tian Tao [ Upstream commit a5740e955540181f4ab8f076cc9795c6bbe4d730 ] Use sysfs_emit instead of snprintf to avoid buf overrun,because in sysfs_emit it strictly checks whether buf is null or buf whether pagesize aligned, otherwise it returns an error. Signed-off-by: Tian Tao Link: https://lore.kernel.org/r/1621497585-30887-1-git-send-email-tiantao6@hisilicon.com Signed-off-by: Will Deacon Signed-off-by: Sasha Levin --- arch/arm64/kernel/perf_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c index 11852e05ee32..cdb3d4549b3a 100644 --- a/arch/arm64/kernel/perf_event.c +++ b/arch/arm64/kernel/perf_event.c @@ -312,7 +312,7 @@ static ssize_t slots_show(struct device *dev, struct device_attribute *attr, struct arm_pmu *cpu_pmu = container_of(pmu, struct arm_pmu, pmu); u32 slots = cpu_pmu->reg_pmmir & ARMV8_PMU_SLOTS_MASK; - return snprintf(page, PAGE_SIZE, "0x%08x\n", slots); + return sysfs_emit(page, "0x%08x\n", slots); } static DEVICE_ATTR_RO(slots); -- 2.30.2