* [PATCH] perf test: Fix bpf test sample mismatch reporting
@ 2021-08-05 16:06 Michael Petlan
2021-09-06 14:26 ` Michael Petlan
0 siblings, 1 reply; 3+ messages in thread
From: Michael Petlan @ 2021-08-05 16:06 UTC (permalink / raw)
To: acme, linux-perf-users; +Cc: jolsa, sumanthk
When the expected sample count in the condition changed, the message
needs to be changed too, otherwise we'll get:
0x1001f2091d8: mmap mask[0]:
BPF filter result incorrect, expected 56, got 56 samples
Fixes: 4b04e0decd25 ("perf test: Fix basic bpf filtering test")
Signed-off-by: Michael Petlan <mpetlan@redhat.com>
---
tools/perf/tests/bpf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/bpf.c b/tools/perf/tests/bpf.c
index dbf5f5215abe..fa03ff0dc083 100644
--- a/tools/perf/tests/bpf.c
+++ b/tools/perf/tests/bpf.c
@@ -192,7 +192,7 @@ static int do_test(struct bpf_object *obj, int (*func)(void),
}
if (count != expect * evlist->core.nr_entries) {
- pr_debug("BPF filter result incorrect, expected %d, got %d samples\n", expect, count);
+ pr_debug("BPF filter result incorrect, expected %d, got %d samples\n", expect * evlist->core.nr_entries, count);
goto out_delete_evlist;
}
--
2.18.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] perf test: Fix bpf test sample mismatch reporting
2021-08-05 16:06 [PATCH] perf test: Fix bpf test sample mismatch reporting Michael Petlan
@ 2021-09-06 14:26 ` Michael Petlan
2021-09-09 12:42 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Michael Petlan @ 2021-09-06 14:26 UTC (permalink / raw)
To: acme; +Cc: linux-perf-users, jolsa, sumanthk
Hi Arnaldo, please have a look.
This is still valid.
Thanks.
Michael
On Thu, 5 Aug 2021, Michael Petlan wrote:
> When the expected sample count in the condition changed, the message
> needs to be changed too, otherwise we'll get:
>
> 0x1001f2091d8: mmap mask[0]:
> BPF filter result incorrect, expected 56, got 56 samples
>
> Fixes: 4b04e0decd25 ("perf test: Fix basic bpf filtering test")
>
> Signed-off-by: Michael Petlan <mpetlan@redhat.com>
> ---
> tools/perf/tests/bpf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/bpf.c b/tools/perf/tests/bpf.c
> index dbf5f5215abe..fa03ff0dc083 100644
> --- a/tools/perf/tests/bpf.c
> +++ b/tools/perf/tests/bpf.c
> @@ -192,7 +192,7 @@ static int do_test(struct bpf_object *obj, int (*func)(void),
> }
>
> if (count != expect * evlist->core.nr_entries) {
> - pr_debug("BPF filter result incorrect, expected %d, got %d samples\n", expect, count);
> + pr_debug("BPF filter result incorrect, expected %d, got %d samples\n", expect * evlist->core.nr_entries, count);
> goto out_delete_evlist;
> }
>
> --
> 2.18.4
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf test: Fix bpf test sample mismatch reporting
2021-09-06 14:26 ` Michael Petlan
@ 2021-09-09 12:42 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-09-09 12:42 UTC (permalink / raw)
To: Michael Petlan; +Cc: acme, linux-perf-users, jolsa, sumanthk
Em Mon, Sep 06, 2021 at 04:26:31PM +0200, Michael Petlan escreveu:
> Hi Arnaldo, please have a look.
> This is still valid.
> Thanks.
> Michael
Looks correct, thanks for resending, applied.
- Arnaldo
> On Thu, 5 Aug 2021, Michael Petlan wrote:
> > When the expected sample count in the condition changed, the message
> > needs to be changed too, otherwise we'll get:
> >
> > 0x1001f2091d8: mmap mask[0]:
> > BPF filter result incorrect, expected 56, got 56 samples
> >
> > Fixes: 4b04e0decd25 ("perf test: Fix basic bpf filtering test")
> >
> > Signed-off-by: Michael Petlan <mpetlan@redhat.com>
> > ---
> > tools/perf/tests/bpf.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/tests/bpf.c b/tools/perf/tests/bpf.c
> > index dbf5f5215abe..fa03ff0dc083 100644
> > --- a/tools/perf/tests/bpf.c
> > +++ b/tools/perf/tests/bpf.c
> > @@ -192,7 +192,7 @@ static int do_test(struct bpf_object *obj, int (*func)(void),
> > }
> >
> > if (count != expect * evlist->core.nr_entries) {
> > - pr_debug("BPF filter result incorrect, expected %d, got %d samples\n", expect, count);
> > + pr_debug("BPF filter result incorrect, expected %d, got %d samples\n", expect * evlist->core.nr_entries, count);
> > goto out_delete_evlist;
> > }
> >
> > --
> > 2.18.4
> >
> >
--
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-09 13:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-05 16:06 [PATCH] perf test: Fix bpf test sample mismatch reporting Michael Petlan
2021-09-06 14:26 ` Michael Petlan
2021-09-09 12:42 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).