From: carsten.haitzler@foss.arm.com
To: linux-perf-users@vger.kernel.org
Subject: [PATCH 02/12] perf test: Shell - only run .sh shell files to skip other files
Date: Wed, 15 Dec 2021 16:22:40 +0000 [thread overview]
Message-ID: <20211215162250.70322-2-carsten.haitzler@foss.arm.com> (raw)
In-Reply-To: <20211215162250.70322-1-carsten.haitzler@foss.arm.com>
From: Carsten Haitzler <carsten.haitzler@arm.com>
You edit your scripts in the tests and end up with your usual shell
backup files with ~ or .bak or something else at the end, but then your
next perf test run wants to run the backups too. You might also have perf
.data files in the directory or something else undesireable as well. You end
up chasing which test is the one you edited and the backup and have to keep
removing all the backup files, so automatically skip any files that are
not plain *.sh scripts to limit the time wasted in chasing ghosts.
Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
---
tools/perf/tests/builtin-test.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index ece272b55587..849737ead9fd 100644
--- a/tools/perf/tests/builtin-test.c
+++ b/tools/perf/tests/builtin-test.c
@@ -297,7 +297,20 @@ static const char *shell_test__description(char *description, size_t size,
for (int __i = 0; __i < nr && (ent = entlist[__i]); __i++) \
if (!is_directory(base, ent) && \
is_executable_file(base, ent) && \
- ent->d_name[0] != '.')
+ ent->d_name[0] != '.' && \
+ (shell_file_is_sh(ent->d_name) == 0))
+
+static int shell_file_is_sh(const char *file)
+{
+ const char *ext;
+
+ ext = strchr(file, '.');
+ if (!ext)
+ return -1;
+ if (!strcmp(ext, ".sh"))
+ return 0;
+ return -1;
+}
static const char *shell_tests__dir(char *path, size_t size)
{
--
2.32.0
next prev parent reply other threads:[~2021-12-15 16:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 16:22 [PATCH 01/12] perf test: Shell - Limit to only run executable scripts in tests carsten.haitzler
2021-12-15 16:22 ` carsten.haitzler [this message]
2021-12-15 16:22 ` [PATCH 03/12] perf test: Use 3 digits for test numbering now we can have more tests carsten.haitzler
2021-12-15 16:22 ` [PATCH 04/12] perf test: Add beginning of test infra + test to exercise coresight carsten.haitzler
2021-12-15 16:22 ` [PATCH 05/12] perf test: Add coresight test to check all threads get some data logged carsten.haitzler
2021-12-15 16:22 ` [PATCH 06/12] perf test: Add tests to re-use the thread loop test to check aux data carsten.haitzler
2021-12-15 16:22 ` [PATCH 07/12] perf test: Add simple bubblesort test for coresight " carsten.haitzler
2021-12-15 16:22 ` [PATCH 09/12] perf test: Add add memcpy test for coresight quality checking carsten.haitzler
2021-12-15 16:22 ` [PATCH 10/12] perf test: Add threaded memcpy tests to check coresight aux data carsten.haitzler
2021-12-15 16:22 ` [PATCH 11/12] perf test: Add unrolled loop tests for " carsten.haitzler
2021-12-15 16:22 ` [PATCH 12/12] perf test: Add docs for coresight and related tests carsten.haitzler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211215162250.70322-2-carsten.haitzler@foss.arm.com \
--to=carsten.haitzler@foss.arm.com \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).