From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBEE0C433F5 for ; Thu, 23 Dec 2021 07:46:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347029AbhLWHq5 (ORCPT ); Thu, 23 Dec 2021 02:46:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347080AbhLWHqq (ORCPT ); Thu, 23 Dec 2021 02:46:46 -0500 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 053CBC061761 for ; Wed, 22 Dec 2021 23:46:46 -0800 (PST) Received: by mail-yb1-xb4a.google.com with SMTP id w9-20020a25c709000000b00608a9489fc1so8584962ybe.20 for ; Wed, 22 Dec 2021 23:46:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=oK4z5E5fiyzkgFCJbjPVTXl+1a3iQ4V/763qtnP+njI=; b=FJ470XTGu1n28V1ATGzFkx+a6y6IY7sA8YqbHakatI88rGF0HcROWHQ7c+agHMxVGQ ipZRdI2SLwQ6Q4zx0go2BxMm9pWQrnTq1w1xsgCZPWvIL0oT8/09FwThJFmBKh9kwQw1 eaLr3iKbvTNJtLGZN44476RGQaz+qCAvrAFRn5kvTi9hrWPVGJD6OnjmaGaar2/g2vit C2kYNb42EjdduHlZMy1cRWyL0DeNfakffPV2owzKsQWI34nNvfESCEwnKvRxQOgb1I32 Q67p2LBNN46xiesFBCBufpIcfId3DLncPFbxrhDFoJv0lniPufGKQYSTo+gY4a30MDwM p/ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=oK4z5E5fiyzkgFCJbjPVTXl+1a3iQ4V/763qtnP+njI=; b=1zmlBbRdgj6ZuRVNPQckeE+1xkRe3TZFRi1/Sb0RpkM5sz1y9pW27ILODDVeDKkqcB 7ADBIScrIWY5yKpNoRqt2mmCmKZABwGEZrwsMMjJmofGnZDdxnnA2slJqoEhhF7u6XHG ZZhjf9TOfR0iG9KhcM+Z9YMXbxGfF2a4dsIrjbhf8FZbs7Hj89OCqJWl4gnlkJEklheJ czzzgvBTUVwjwR3DNE/DtSFatZE5C+kPKuPWy0PYTP67vbHa6Tab7QZBE81Dis43rF4q zLv1nyPVpLjh25mHkncQ1Er7ILIIcwPV6u1n7vLOmD8DFB1pFBMF7DbCOrrZ2qI+6/ui WhDQ== X-Gm-Message-State: AOAM530nLdIH/OiP5FjDB2NzpdoTJYvSWMJYnipBm8I6vaEVTX2ryg8T FCBOiLvsHdzIDFxvH6ssSsaK+f84tBou X-Google-Smtp-Source: ABdhPJymUOB7LGtIX2a9eR7ad1c348HlWb3l8JGGmoCGMzqjqRvlco6jPwBosbOtjOlDzUZa4aiCJXzdmfAn X-Received: from irogers.svl.corp.google.com ([2620:15c:2cd:202:4fef:90ff:589d:24ca]) (user=irogers job=sendgmr) by 2002:a25:abe3:: with SMTP id v90mr1636040ybi.315.1640245605233; Wed, 22 Dec 2021 23:46:45 -0800 (PST) Date: Wed, 22 Dec 2021 23:45:08 -0800 In-Reply-To: <20211223074541.3318938-1-irogers@google.com> Message-Id: <20211223074541.3318938-16-irogers@google.com> Mime-Version: 1.0 References: <20211223074541.3318938-1-irogers@google.com> X-Mailer: git-send-email 2.34.1.307.g9b7440fafd-goog Subject: [PATCH v2 15/48] perf cpumap: Document cpu__get_node and remove redundant function From: Ian Rogers To: Andi Kleen , Jiri Olsa , Namhyung Kim , John Garry , Kajol Jain , "Paul A . Clarke" , Arnaldo Carvalho de Melo , Riccardo Mancini , Kan Liang , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Vineet Singh , James Clark , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org Cc: eranian@google.com, Ian Rogers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org cpu_map__get_node_id isn't used externally and merely delegates to cpu__get_node. Reviewed-by: James Clark Signed-off-by: Ian Rogers --- tools/perf/util/cpumap.c | 11 +++++------ tools/perf/util/cpumap.h | 5 ++++- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/tools/perf/util/cpumap.c b/tools/perf/util/cpumap.c index b3e1304aca0c..1626b0991408 100644 --- a/tools/perf/util/cpumap.c +++ b/tools/perf/util/cpumap.c @@ -16,6 +16,10 @@ static int max_cpu_num; static int max_present_cpu_num; static int max_node_num; +/** + * The numa node X as read from /sys/devices/system/node/nodeX indexed by the + * CPU number. + */ static int *cpunode_map; static struct perf_cpu_map *cpu_map__from_entries(struct cpu_map_entries *cpus) @@ -222,11 +226,6 @@ int cpu_map__get_core_id(int cpu) return ret ?: value; } -int cpu_map__get_node_id(int cpu) -{ - return cpu__get_node(cpu); -} - struct aggr_cpu_id cpu_map__get_core_aggr_by_cpu(int cpu, void *data) { struct aggr_cpu_id id; @@ -250,7 +249,7 @@ struct aggr_cpu_id cpu_map__get_node_aggr_by_cpu(int cpu, void *data __maybe_unu { struct aggr_cpu_id id = aggr_cpu_id__empty(); - id.node = cpu_map__get_node_id(cpu); + id.node = cpu__get_node(cpu); return id; } diff --git a/tools/perf/util/cpumap.h b/tools/perf/util/cpumap.h index 9589b0001a28..f849f01c5860 100644 --- a/tools/perf/util/cpumap.h +++ b/tools/perf/util/cpumap.h @@ -45,7 +45,6 @@ int cpu_map__get_die_id(int cpu); struct aggr_cpu_id cpu_map__get_die_aggr_by_cpu(int cpu, void *data); int cpu_map__get_core_id(int cpu); struct aggr_cpu_id cpu_map__get_core_aggr_by_cpu(int cpu, void *data); -int cpu_map__get_node_id(int cpu); struct aggr_cpu_id cpu_map__get_node_aggr_by_cpu(int cpu, void *data); int cpu_map__build_socket_map(struct perf_cpu_map *cpus, struct cpu_aggr_map **sockp); int cpu_map__build_die_map(struct perf_cpu_map *cpus, struct cpu_aggr_map **diep); @@ -58,6 +57,10 @@ int cpu__setup_cpunode_map(void); int cpu__max_node(void); int cpu__max_cpu(void); int cpu__max_present_cpu(void); +/** + * cpu__get_node - Returns the numa node X as read from + * /sys/devices/system/node/nodeX for the given CPU. + */ int cpu__get_node(int cpu); int cpu_map__build_map(struct perf_cpu_map *cpus, struct cpu_aggr_map **res, -- 2.34.1.307.g9b7440fafd-goog