From: Ali Saidi <alisaidi@amazon.com>
To: <linux-kernel@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Cc: <alisaidi@amazon.com>, <benh@kernel.crashing.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
John Garry <john.garry@huawei.com>,
"Will Deacon" <will@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
"Leo Yan" <leo.yan@linaro.org>, James Clark <james.clark@arm.com>,
German Gomez <german.gomez@arm.com>,
Andrew Kilroy <andrew.kilroy@arm.com>
Subject: [PATCH 2/2] perf arm-spe: Parse more SPE fields and store source
Date: Tue, 25 Jan 2022 19:20:10 +0000 [thread overview]
Message-ID: <20220125192016.20538-3-alisaidi@amazon.com> (raw)
In-Reply-To: <20220125192016.20538-1-alisaidi@amazon.com>
Decode more SPE events and op types to allow for processing by perf
scripts. For example looking for branches which may indicate candidates
for conversion to a CSEL, store exclusives that are candidates for
conversion to LSE atomics and record the source information for memory
ops.
Signed-off-by: Ali Saidi <alisaidi@amazon.com>
---
.../util/arm-spe-decoder/arm-spe-decoder.c | 18 ++++++++++++++++++
.../util/arm-spe-decoder/arm-spe-decoder.h | 8 ++++++++
2 files changed, 26 insertions(+)
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
index 5e390a1a79ab..177bac0f7128 100644
--- a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
+++ b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
@@ -191,6 +191,20 @@ static int arm_spe_read_record(struct arm_spe_decoder *decoder)
decoder->record.op = ARM_SPE_ST;
else
decoder->record.op = ARM_SPE_LD;
+ if (SPE_OP_PKT_IS_LDST_ATOMIC(payload)) {
+ if (payload & SPE_OP_PKT_AT)
+ decoder->record.op |= ARM_SPE_LDST_ATOMIC;
+ if (payload & SPE_OP_PKT_EXCL)
+ decoder->record.op |= ARM_SPE_LDST_EXCL;
+ if (payload & SPE_OP_PKT_AR)
+ decoder->record.op |= ARM_SPE_LDST_ACQREL;
+ }
+ } else if (idx == SPE_OP_PKT_HDR_CLASS_BR_ERET) {
+ decoder->record.op = ARM_SPE_BR;
+ if (payload & SPE_OP_PKT_COND)
+ decoder->record.op |= ARM_SPE_BR_COND;
+ if (SPE_OP_PKT_IS_INDIRECT_BRANCH(payload))
+ decoder->record.op |= ARM_SPE_BR_IND;
}
break;
case ARM_SPE_EVENTS:
@@ -218,8 +232,12 @@ static int arm_spe_read_record(struct arm_spe_decoder *decoder)
if (payload & BIT(EV_MISPRED))
decoder->record.type |= ARM_SPE_BRANCH_MISS;
+ if (payload & BIT(EV_NOT_TAKEN))
+ decoder->record.type |= ARM_SPE_BR_NOT_TAKEN;
+
break;
case ARM_SPE_DATA_SOURCE:
+ decoder->record.source = payload;
break;
case ARM_SPE_BAD:
break;
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h
index 69b31084d6be..113e427afe99 100644
--- a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h
+++ b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h
@@ -22,11 +22,18 @@ enum arm_spe_sample_type {
ARM_SPE_TLB_MISS = 1 << 5,
ARM_SPE_BRANCH_MISS = 1 << 6,
ARM_SPE_REMOTE_ACCESS = 1 << 7,
+ ARM_SPE_BR_NOT_TAKEN = 1 << 8,
};
enum arm_spe_op_type {
ARM_SPE_LD = 1 << 0,
ARM_SPE_ST = 1 << 1,
+ ARM_SPE_LDST_EXCL = 1 << 2,
+ ARM_SPE_LDST_ATOMIC = 1 << 3,
+ ARM_SPE_LDST_ACQREL = 1 << 4,
+ ARM_SPE_BR = 1 << 5,
+ ARM_SPE_BR_COND = 1 << 6,
+ ARM_SPE_BR_IND = 1 << 7,
};
struct arm_spe_record {
@@ -40,6 +47,7 @@ struct arm_spe_record {
u64 virt_addr;
u64 phys_addr;
u64 context_id;
+ u16 source;
};
struct arm_spe_insn;
--
2.24.4.AMZN
next prev parent reply other threads:[~2022-01-25 19:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 19:20 [PATCH 0/2] Allow perf scripts to process SPE raw data Ali Saidi
2022-01-25 19:20 ` [PATCH 1/2] perf arm-spe: Add arm_spe_record to synthesized sample Ali Saidi
2022-01-25 20:47 ` German Gomez
2022-01-26 15:58 ` [PATCH 1/2] perf arm-spe: Add arm_spe_record to synthesized Ali Saidi
2022-01-26 19:07 ` German Gomez
2022-01-27 19:13 ` Ali Saidi
2022-01-25 19:20 ` Ali Saidi [this message]
2022-01-28 17:20 ` [PATCH 2/2] perf arm-spe: Parse more SPE fields and store source German Gomez
2022-01-28 21:02 ` Ali Saidi
2022-02-11 16:31 ` German Gomez
2022-02-12 4:19 ` Leo Yan
2022-02-21 20:41 ` German Gomez
2022-02-22 19:29 ` Ali Saidi
2022-02-25 12:40 ` German Gomez
2022-02-27 13:54 ` Leo Yan
2022-02-27 13:20 ` Leo Yan
2022-03-01 10:54 ` German Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125192016.20538-3-alisaidi@amazon.com \
--to=alisaidi@amazon.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrew.kilroy@arm.com \
--cc=benh@kernel.crashing.org \
--cc=german.gomez@arm.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).