From: Peter Zijlstra <peterz@infradead.org>
To: Zhipeng Xie <xiezhipeng1@huawei.com>
Cc: mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix perf_mmap fail when CONFIG_PERF_USE_VMALLOC enabled
Date: Mon, 7 Feb 2022 15:11:36 +0100 [thread overview]
Message-ID: <20220207141136.GG23216@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20220207170259.2566-1-xiezhipeng1@huawei.com>
Your $Subject needs a subsystem prefix.
On Mon, Feb 07, 2022 at 12:02:59PM -0500, Zhipeng Xie wrote:
> when CONFIG_PERF_USE_VMALLOC is enabled, rb->nr_pages is always
> equal to 1 in rb_alloc, causing perf_mmap return -EINVAL when mmap.
> Fix this problem using data_page_nr.
How can this be? This would mean that any arch that selects that hasn't
worked for forever ?! That seems unlikely.
> Signed-off-by: Zhipeng Xie <xiezhipeng1@huawei.com>
If this is correct; this is also missing a Fixes: tag.
next prev parent reply other threads:[~2022-02-07 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 17:02 [PATCH] Fix perf_mmap fail when CONFIG_PERF_USE_VMALLOC enabled Zhipeng Xie
2022-02-07 14:11 ` Peter Zijlstra [this message]
2022-02-08 15:49 ` Zhipeng Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220207141136.GG23216@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=xiezhipeng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox