From: Lecopzer Chen <lecopzer.chen@mediatek.com>
To: <linux-kernel@vger.kernel.org>
Cc: <lecopzer.chen@mediatek.com>, <acme@kernel.org>,
<akpm@linux-foundation.org>, <alexander.shishkin@linux.intel.com>,
<catalin.marinas@arm.com>, <davem@davemloft.net>,
<jolsa@redhat.com>, <jthierry@redhat.com>,
<keescook@chromium.org>, <kernelfans@gmail.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-perf-users@vger.kernel.org>, <mark.rutland@arm.com>,
<masahiroy@kernel.org>, <matthias.bgg@gmail.com>,
<maz@kernel.org>, <mcgrof@kernel.org>, <mingo@redhat.com>,
<namhyung@kernel.org>, <nixiaoming@huawei.com>,
<peterz@infradead.org>, <pmladek@suse.com>,
<sparclinux@vger.kernel.org>, <sumit.garg@linaro.org>,
<wangqing@vivo.com>, <will@kernel.org>, <yj.chiang@mediatek.com>
Subject: [PATCH v2 0/5] Suppot hld based on Pseudo-NMI for arm64
Date: Mon, 7 Mar 2022 23:47:24 +0800 [thread overview]
Message-ID: <20220307154729.13477-1-lecopzer.chen@mediatek.com> (raw)
As we already used hld internally for arm64 since 2020, there still
doesn't have a proper commit on the upstream and we badly need it.
This serise rework on 5.17-rc7 from [1] and the origin author is
Pingfan Liu <kernelfans@gmail.com>
Sumit Garg <sumit.garg@linaro.org>
Qoute from [1]:
> Hard lockup detector is helpful to diagnose unpaired irq enable/disable.
> But the current watchdog framework can not cope with arm64 hw perf event
> easily.
> On arm64, when lockup_detector_init()->watchdog_nmi_probe(), PMU is not
> ready until device_initcall(armv8_pmu_driver_init). And it is deeply
> integrated with the driver model and cpuhp. Hence it is hard to push the
> initialization of armv8_pmu_driver_init() before smp_init().
> But it is easy to take an opposite approach by enabling watchdog_hld to
> get the capability of PMU async.
> The async model is achieved by expanding watchdog_nmi_probe() with
> -EBUSY, and a re-initializing work_struct which waits on a
> wait_queue_head.
[1] https://lore.kernel.org/lkml/20211014024155.15253-1-kernelfans@gmail.com/
v2:
1. Tweak commit message in patch 01/02/04/05
2. Remove vobose WARN in patch 04 within watchdog core.
3. Change from three states variable: detector_delay_init_state to
two states variable: lockup_detector_pending_init
Thanks Petr Mladek <pmladek@suse.com> for the idea.
> 1. lockup_detector_work() called before lockup_detector_check().
> In this case, wait_event() will wait until lockup_detector_check()
> clears detector_delay_pending_init and calls wake_up().
> 2. lockup_detector_check() called before lockup_detector_work().
> In this case, wait_even() will immediately continue because
> it will see cleared detector_delay_pending_init.
4. Add comment in code in patch 04/05 for two states variable changing.
Lecopzer Chen (4):
kernel/watchdog: remove WATCHDOG_DEFAULT
kernel/watchdog: change watchdog_nmi_enable() to void
kernel/watchdog: Adapt the watchdog_hld interface for async model
arm64: Enable perf events based hard lockup detector
Pingfan Liu (1):
kernel/watchdog_hld: Ensure CPU-bound context when creating hardlockup
detector event
arch/arm64/Kconfig | 2 +
arch/arm64/kernel/Makefile | 1 +
arch/arm64/kernel/perf_event.c | 12 +++++-
arch/sparc/kernel/nmi.c | 8 ++--
drivers/perf/arm_pmu.c | 5 +++
include/linux/nmi.h | 5 ++-
include/linux/perf/arm_pmu.h | 2 +
kernel/watchdog.c | 67 +++++++++++++++++++++++++++++++---
kernel/watchdog_hld.c | 8 +++-
9 files changed, 95 insertions(+), 15 deletions(-)
--
2.25.1
next reply other threads:[~2022-03-07 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 15:47 Lecopzer Chen [this message]
2022-03-07 15:47 ` [PATCH v2 1/5] kernel/watchdog: remove WATCHDOG_DEFAULT Lecopzer Chen
2022-03-07 15:47 ` [PATCH v2 2/5] kernel/watchdog: change watchdog_nmi_enable() to void Lecopzer Chen
2022-03-07 15:47 ` [PATCH v2 3/5] kernel/watchdog_hld: Ensure CPU-bound context when creating hardlockup detector event Lecopzer Chen
2022-03-07 15:47 ` [PATCH v2 4/5] kernel/watchdog: Adapt the watchdog_hld interface for async model Lecopzer Chen
2022-03-18 10:40 ` Petr Mladek
2022-03-19 8:18 ` Lecopzer Chen
2022-03-21 17:37 ` Petr Mladek
2022-03-24 12:55 ` Lecopzer Chen
2022-03-07 15:47 ` [PATCH v2 5/5] arm64: Enable perf events based hard lockup detector Lecopzer Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220307154729.13477-1-lecopzer.chen@mediatek.com \
--to=lecopzer.chen@mediatek.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=jolsa@redhat.com \
--cc=jthierry@redhat.com \
--cc=keescook@chromium.org \
--cc=kernelfans@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=maz@kernel.org \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nixiaoming@huawei.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=sparclinux@vger.kernel.org \
--cc=sumit.garg@linaro.org \
--cc=wangqing@vivo.com \
--cc=will@kernel.org \
--cc=yj.chiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).