From: carsten.haitzler@foss.arm.com
To: linux-kernel@vger.kernel.org
Cc: coresight@lists.linaro.org, suzuki.poulose@arm.com,
mathieu.poirier@linaro.org, mike.leach@linaro.org,
leo.yan@linaro.org, linux-perf-users@vger.kernel.org,
acme@kernel.org
Subject: [PATCH 2/3] perf test: Shell - only run .sh shell files to skip other files
Date: Wed, 9 Mar 2022 12:28:58 +0000 [thread overview]
Message-ID: <20220309122859.31487-2-carsten.haitzler@foss.arm.com> (raw)
In-Reply-To: <20220309122859.31487-1-carsten.haitzler@foss.arm.com>
From: Carsten Haitzler <carsten.haitzler@arm.com>
You edit your scripts in the tests and end up with your usual shell
backup files with ~ or .bak or something else at the end, but then your
next perf test run wants to run the backups too. You might also have perf
.data files in the directory or something else undesireable as well. You end
up chasing which test is the one you edited and the backup and have to keep
removing all the backup files, so automatically skip any files that are
not plain *.sh scripts to limit the time wasted in chasing ghosts.
Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
---
tools/perf/tests/builtin-test.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index 3c34cb766724..3a02ba7a7a89 100644
--- a/tools/perf/tests/builtin-test.c
+++ b/tools/perf/tests/builtin-test.c
@@ -296,9 +296,22 @@ static const char *shell_test__description(char *description, size_t size,
#define for_each_shell_test(entlist, nr, base, ent) \
for (int __i = 0; __i < nr && (ent = entlist[__i]); __i++) \
- if (!is_directory(base, ent) && \
+ if (ent->d_name[0] != '.' && \
+ !is_directory(base, ent) && \
is_executable_file(base, ent) && \
- ent->d_name[0] != '.')
+ is_shell_script(ent->d_name))
+
+static bool is_shell_script(const char *file)
+{
+ const char *ext;
+
+ ext = strrchr(file, '.');
+ if (!ext)
+ return false;
+ if (!strcmp(ext, ".sh"))
+ return true;
+ return false;
+}
static const char *shell_tests__dir(char *path, size_t size)
{
--
2.32.0
next prev parent reply other threads:[~2022-03-09 12:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 12:28 [PATCH 1/3] perf test: Shell - Limit to only run executable scripts in tests carsten.haitzler
2022-03-09 12:28 ` carsten.haitzler [this message]
2022-04-10 2:28 ` [PATCH 2/3] perf test: Shell - only run .sh shell files to skip other files Leo Yan
2022-04-21 16:21 ` Carsten Haitzler
2022-05-26 10:14 ` Leo Yan
2022-06-13 13:08 ` Carsten Haitzler
2022-06-15 9:14 ` Leo Yan
2022-03-09 12:28 ` [PATCH 3/3] perf test: Add coresight tests to guage quality of data generated carsten.haitzler
2022-04-10 8:30 ` Leo Yan
2022-04-21 17:38 ` Carsten Haitzler
2022-05-26 8:20 ` Leo Yan
2022-05-26 16:08 ` Leo Yan
2022-06-13 14:15 ` Carsten Haitzler
2022-05-30 16:27 ` Mathieu Poirier
2022-05-30 16:47 ` Mathieu Poirier
2022-06-13 12:53 ` Carsten Haitzler
2022-06-13 13:00 ` Carsten Haitzler
2022-04-10 1:24 ` [PATCH 1/3] perf test: Shell - Limit to only run executable scripts in tests Leo Yan
2022-04-11 19:08 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220309122859.31487-2-carsten.haitzler@foss.arm.com \
--to=carsten.haitzler@foss.arm.com \
--cc=acme@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).