From: Ali Saidi <alisaidi@amazon.com>
To: <linux-kernel@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <german.gomez@arm.com>,
<leo.yan@linaro.org>, <acme@kernel.org>
Cc: <alisaidi@amazon.com>, <benh@kernel.crashing.org>,
<Nick.Forrington@arm.com>, <alexander.shishkin@linux.intel.com>,
<andrew.kilroy@arm.com>, <james.clark@arm.com>,
<john.garry@huawei.com>, <jolsa@kernel.org>,
<kjain@linux.ibm.com>, <lihuafei1@huawei.com>,
<mark.rutland@arm.com>, <mathieu.poirier@linaro.org>,
<mingo@redhat.com>, <namhyung@kernel.org>, <peterz@infradead.org>,
<will@kernel.org>
Subject: [PATCH v4 3/4] perf mem: Support mem_lvl_num in c2c command
Date: Thu, 24 Mar 2022 18:33:22 +0000 [thread overview]
Message-ID: <20220324183323.31414-4-alisaidi@amazon.com> (raw)
In-Reply-To: <20220324183323.31414-1-alisaidi@amazon.com>
In addition to summarizing data encoded in mem_lvl also support data
encoded in mem_lvl_num.
Since other architectures don't seem to populate the mem_lvl_num field
here there shouldn't be a change in functionality.
Signed-off-by: Ali Saidi <alisaidi@amazon.com>
Tested-by: German Gomez <german.gomez@arm.com>
Reviewed-by: German Gomez <german.gomez@arm.com>
---
tools/perf/util/mem-events.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
index ed0ab838bcc5..e5e405185498 100644
--- a/tools/perf/util/mem-events.c
+++ b/tools/perf/util/mem-events.c
@@ -485,6 +485,7 @@ int c2c_decode_stats(struct c2c_stats *stats, struct mem_info *mi)
u64 daddr = mi->daddr.addr;
u64 op = data_src->mem_op;
u64 lvl = data_src->mem_lvl;
+ u64 lnum = data_src->mem_lvl_num;
u64 snoop = data_src->mem_snoop;
u64 lock = data_src->mem_lock;
u64 blk = data_src->mem_blk;
@@ -527,16 +528,18 @@ do { \
if (lvl & P(LVL, UNC)) stats->ld_uncache++;
if (lvl & P(LVL, IO)) stats->ld_io++;
if (lvl & P(LVL, LFB)) stats->ld_fbhit++;
- if (lvl & P(LVL, L1 )) stats->ld_l1hit++;
- if (lvl & P(LVL, L2 )) stats->ld_l2hit++;
- if (lvl & P(LVL, L3 )) {
+ if (lvl & P(LVL, L1) || lnum == P(LVLNUM, L1))
+ stats->ld_l1hit++;
+ if (lvl & P(LVL, L2) || lnum == P(LVLNUM, L2))
+ stats->ld_l2hit++;
+ if (lvl & P(LVL, L3) || lnum == P(LVLNUM, L3)) {
if (snoop & P(SNOOP, HITM))
HITM_INC(lcl_hitm);
else
stats->ld_llchit++;
}
- if (lvl & P(LVL, LOC_RAM)) {
+ if (lvl & P(LVL, LOC_RAM) || lnum == P(LVLNUM, RAM)) {
stats->lcl_dram++;
if (snoop & P(SNOOP, HIT))
stats->ld_shared++;
--
2.32.0
next prev parent reply other threads:[~2022-03-24 18:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 18:33 [PATCH v4 0/4] perf: arm-spe: Decode SPE source and use for perf c2c Ali Saidi
2022-03-24 18:33 ` [PATCH v4 1/4] tools: arm64: Import cputype.h Ali Saidi
2022-03-25 18:39 ` Arnaldo Carvalho de Melo
2022-03-25 18:58 ` Ali Saidi
2022-03-25 19:42 ` Arnaldo Carvalho de Melo
2022-03-26 5:49 ` Leo Yan
2022-03-26 13:59 ` Arnaldo Carvalho de Melo
2022-03-24 18:33 ` [PATCH v4 2/4] perf arm-spe: Use SPE data source for neoverse cores Ali Saidi
2022-03-26 13:47 ` Leo Yan
2022-03-26 13:52 ` Arnaldo Carvalho de Melo
2022-03-26 13:56 ` Leo Yan
2022-03-26 14:04 ` Arnaldo Carvalho de Melo
2022-03-26 19:43 ` Ali Saidi
2022-03-27 9:09 ` Leo Yan
2022-03-28 3:08 ` Ali Saidi
2022-03-28 13:05 ` Leo Yan
2022-03-29 13:34 ` Shuai Xue
2022-03-29 14:32 ` Ali Saidi
2022-03-31 12:19 ` Leo Yan
2022-03-31 12:28 ` German Gomez
2022-03-31 12:44 ` Leo Yan
2022-04-03 20:33 ` Ali Saidi
2022-04-04 15:12 ` Leo Yan
2022-04-06 21:00 ` Ali Saidi
2022-04-08 1:06 ` Leo Yan
2022-04-07 15:24 ` German Gomez
2022-04-08 1:18 ` Leo Yan
2022-03-24 18:33 ` Ali Saidi [this message]
2022-03-26 13:54 ` [PATCH v4 3/4] perf mem: Support mem_lvl_num in c2c command Arnaldo Carvalho de Melo
2022-03-24 18:33 ` [PATCH v4 4/4] perf mem: Support HITM for when mem_lvl_num is any Ali Saidi
2022-03-26 6:23 ` Leo Yan
2022-03-26 13:30 ` Arnaldo Carvalho de Melo
2022-03-26 19:14 ` Ali Saidi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220324183323.31414-4-alisaidi@amazon.com \
--to=alisaidi@amazon.com \
--cc=Nick.Forrington@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrew.kilroy@arm.com \
--cc=benh@kernel.crashing.org \
--cc=german.gomez@arm.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=leo.yan@linaro.org \
--cc=lihuafei1@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).