From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6E16C433FE for ; Thu, 7 Apr 2022 04:28:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236381AbiDGEa3 (ORCPT ); Thu, 7 Apr 2022 00:30:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236350AbiDGEa1 (ORCPT ); Thu, 7 Apr 2022 00:30:27 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 576DBAAB41; Wed, 6 Apr 2022 21:28:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649305707; x=1680841707; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ts+o/jr2ZC6MZBkFgb5YbXFIFLPZBtS2sjuEohSRpHM=; b=gEqD8mIKpe7XVOjU5dKHkcC7NVLnew1P2oAFrhAYlbrfmb7DpEX8A1Vz NN6qp09ZQSOs/WZT11YJUmmtdv+NbHjZ+I8NkjVGgK3tEy/BCWOe+kV4A 4GWJEaJxf71xsxjlDcw0XgIOi+ECvaV8m8nhCBfWWgIFgB/znYKneMPou +ERs0EtJO+mrXHXZkR3GECx0D9/0IUaSM6FSiOIGAe05f5t/sqv0Jv6dn d89S9NZ/ZpnL4hCkVDeSt+QGABDowdFYiMvhP4zfnZubVIQMD1iKsfkn7 DS+5tdPAxSkZbwFUCfqSDgeI0TGAGoJOigP/4CXWZAoofytP/crafi/vA w==; X-IronPort-AV: E=McAfee;i="6200,9189,10309"; a="261218780" X-IronPort-AV: E=Sophos;i="5.90,241,1643702400"; d="scan'208";a="261218780" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2022 21:28:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,241,1643702400"; d="scan'208";a="621093362" Received: from lkp-server02.sh.intel.com (HELO a44fdfb70b94) ([10.239.97.151]) by fmsmga004.fm.intel.com with ESMTP; 06 Apr 2022 21:28:20 -0700 Received: from kbuild by a44fdfb70b94 with local (Exim 4.95) (envelope-from ) id 1ncJkp-000543-At; Thu, 07 Apr 2022 04:28:19 +0000 Date: Thu, 7 Apr 2022 12:28:05 +0800 From: kernel test robot To: Yicong Yang , gregkh@linuxfoundation.org, helgaas@kernel.org, alexander.shishkin@linux.intel.com, lorenzo.pieralisi@arm.com, will@kernel.org, mark.rutland@arm.com, mathieu.poirier@linaro.org, suzuki.poulose@arm.com, mike.leach@linaro.org, leo.yan@linaro.org, jonathan.cameron@huawei.com, daniel.thompson@linaro.org, joro@8bytes.org, john.garry@huawei.com, shameerali.kolothum.thodi@huawei.com, robin.murphy@arm.com, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, linux-pci@vger.kernel.org, linux-perf-users@vger.kernel.org, iommu@lists.linux-foundation.org Cc: kbuild-all@lists.01.org, prime.zeng@huawei.com, liuqi115@huawei.com, zhangshaokun@hisilicon.com, linuxarm@huawei.com, yangyicong@hisilicon.com Subject: Re: [PATCH v6 4/7] hisi_ptt: Add tune function support for HiSilicon PCIe Tune and Trace device Message-ID: <202204071201.AcePULOR-lkp@intel.com> References: <20220406071730.41031-5-yangyicong@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220406071730.41031-5-yangyicong@hisilicon.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Hi Yicong, I love your patch! Perhaps something to improve: [auto build test WARNING on joro-iommu/next] [also build test WARNING on linus/master linux/master v5.18-rc1 next-20220406] [cannot apply to tip/perf/core] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Yicong-Yang/Add-support-for-HiSilicon-PCIe-Tune-and-Trace-device/20220406-200044 base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20220407/202204071201.AcePULOR-lkp@intel.com/config) compiler: alpha-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/9400668b70cbcd5ec74a52f043c3a333b80135f8 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Yicong-Yang/Add-support-for-HiSilicon-PCIe-Tune-and-Trace-device/20220406-200044 git checkout 9400668b70cbcd5ec74a52f043c3a333b80135f8 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash drivers/hwtracing/ptt/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/hwtracing/ptt/hisi_ptt.c: In function 'hisi_ptt_tune_data_get': >> drivers/hwtracing/ptt/hisi_ptt.c:46:16: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551615' to '4294967295' [-Woverflow] 46 | writel(~0UL, hisi_ptt->iobase + HISI_PTT_TUNING_DATA); | ^~~~ drivers/hwtracing/ptt/hisi_ptt.c: At top level: drivers/hwtracing/ptt/hisi_ptt.c:1131:6: warning: no previous prototype for 'hisi_ptt_remove' [-Wmissing-prototypes] 1131 | void hisi_ptt_remove(struct pci_dev *pdev) | ^~~~~~~~~~~~~~~ vim +46 drivers/hwtracing/ptt/hisi_ptt.c 33 34 static int hisi_ptt_tune_data_get(struct hisi_ptt *hisi_ptt, 35 u32 event, u16 *data) 36 { 37 u32 reg; 38 39 reg = readl(hisi_ptt->iobase + HISI_PTT_TUNING_CTRL); 40 reg &= ~(HISI_PTT_TUNING_CTRL_CODE | HISI_PTT_TUNING_CTRL_SUB); 41 reg |= FIELD_PREP(HISI_PTT_TUNING_CTRL_CODE | HISI_PTT_TUNING_CTRL_SUB, 42 event); 43 writel(reg, hisi_ptt->iobase + HISI_PTT_TUNING_CTRL); 44 45 /* Write all 1 to indicates it's the read process */ > 46 writel(~0UL, hisi_ptt->iobase + HISI_PTT_TUNING_DATA); 47 48 if (!hisi_ptt_wait_tuning_finish(hisi_ptt)) 49 return -ETIMEDOUT; 50 51 reg = readl(hisi_ptt->iobase + HISI_PTT_TUNING_DATA); 52 reg &= HISI_PTT_TUNING_DATA_VAL_MASK; 53 *data = FIELD_GET(HISI_PTT_TUNING_DATA_VAL_MASK, reg); 54 55 return 0; 56 } 57 -- 0-DAY CI Kernel Test Service https://01.org/lkp