From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF9C9C433F5 for ; Sat, 9 Apr 2022 10:00:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236486AbiDIKCT (ORCPT ); Sat, 9 Apr 2022 06:02:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232630AbiDIKCR (ORCPT ); Sat, 9 Apr 2022 06:02:17 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6E4BE98 for ; Sat, 9 Apr 2022 02:59:50 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id r13so21701649ejd.5 for ; Sat, 09 Apr 2022 02:59:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=N4XJfs2B+Cri2iOejBgjUkpCtU57s9kSfpppvvyrQ3Y=; b=nCAc3eD+ukkUEzJ+5m0uI1Yk9ZLxaGw4gCZilaLJMFu3LwVidMWBJNsv4nCr4xaFGB XOIkpON+cxcV0sSDyCxcFz5tweWwxjl9pdmg0McvIABk/wSL/C+uMof2TytvT2k9Oarf PC2DoRXaIxsNglfmCcQxingTPZYXnWhaJ/boelOQH7dFSim74h9FwvMRioIuyTwgjFUC XlrKg1kHS2sba/oQ3SU1Uhbe8MnpsKj2wigGrocU99fnvELvlqkvlBEQowo5iObfwgsz iO9bddAjlwOWkyQGR9KkUmGJ6rXwkt7WgAXs/laz4ew5+arw4DsV9MMHAej1ogrYxiBn 5v3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=N4XJfs2B+Cri2iOejBgjUkpCtU57s9kSfpppvvyrQ3Y=; b=dBF7X0Yv7qPhbHZx2v76oAXpRL/aEIsURIThG0axHe3GwZIJrn9lSm4jl6weDaiW0a tdwXOUWU8Cfn+sQ1jks0lsK2F+AclLD+iIkRt9IRw0kDpmxFnqbU6C4O+ER7Fgx5mSZ0 h4IWR1raiyXcY3wqrtlVCoiY59jnO6T4+OCWtY1v+fl8JvPwX8DJbxZcJoU5ondNEjo1 ccKXkm7bVZtqKJh5cb7a8raQ5MK3I5unNXvkLbmVZlaxGPLSiJmds61NEILWThuA2lXT Us1GjpxFhprX59mh+XM96bwmPlPnwfgarm4Pe6O+eafr+LAXhxQkIWqTwVFgsBMbNjO/ 150Q== X-Gm-Message-State: AOAM532xInE3nlMCa99EDCfGHrP2yjKURQAYTHzJ4Eqc1plqYouFHNvq He8407T4ffFJGkdJdEOzKx1sKQ== X-Google-Smtp-Source: ABdhPJzia8lT1grS0oZhObzaXk1Mxby37e8QeLtr75r2MAWa1O9h8k6Ly94DLakgv4ib364h5bhSKA== X-Received: by 2002:a17:907:72c7:b0:6e8:442c:1722 with SMTP id du7-20020a17090772c700b006e8442c1722mr8607936ejc.120.1649498388695; Sat, 09 Apr 2022 02:59:48 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([104.245.96.34]) by smtp.gmail.com with ESMTPSA id e11-20020a17090681cb00b006e86b594e1fsm785527ejx.207.2022.04.09.02.59.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Apr 2022 02:59:48 -0700 (PDT) Date: Sat, 9 Apr 2022 17:59:41 +0800 From: Leo Yan To: Namhyung Kim Cc: James Clark , Arnaldo Carvalho de Melo , linux-perf-users , leo.yan@linaro.com, German Gomez , John Garry , Will Deacon , Mathieu Poirier , Mark Rutland , Alexander Shishkin , Jiri Olsa , Arnaldo Carvalho de Melo , Ravi Bangoria , linux-arm-kernel@lists.infradead.org, linux-kernel Subject: Re: [PATCH] perf: arm-spe: Fix perf report --mem-mode Message-ID: <20220409095941.GA1000846@leoy-ThinkPad-X240s> References: <20220408144056.1955535-1-james.clark@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Fri, Apr 08, 2022 at 11:13:09AM -0700, Namhyung Kim wrote: > Hello, > > On Fri, Apr 8, 2022 at 7:41 AM James Clark wrote: > > > > Since commit bb30acae4c4d ("perf report: Bail out --mem-mode if mem info > > is not available") "perf mem report" and "perf report --mem-mode" don't > > allow opening the file unless one of the events has PERF_SAMPLE_DATA_SRC > > set. > > > > SPE doesn't have this set even though synthetic memory data is generated > > after it is decoded. Fix this issue by setting DATA_SRC on SPE events. > > This has no effect on the data collected because the SPE driver doesn't > > do anything with that flag and doesn't generate samples. > > > > Fixes: bb30acae4c4d ("perf report: Bail out --mem-mode if mem info is not available") > > Signed-off-by: James Clark > > Acked-by: Namhyung Kim Tested-by: Leo Yan It's a bit awkward that after the commit bb30acae4c4d we cannot be backward compatible and any old perf data file will be failed to support by 'perf mem report' tool. Thanks, Leo