From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25412C433EF for ; Sun, 17 Apr 2022 12:45:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234053AbiDQMsO (ORCPT ); Sun, 17 Apr 2022 08:48:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234017AbiDQMsN (ORCPT ); Sun, 17 Apr 2022 08:48:13 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC732EA0 for ; Sun, 17 Apr 2022 05:45:37 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id lc2so22719386ejb.12 for ; Sun, 17 Apr 2022 05:45:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=d0NpqGl1oKuCDKK6YqMWlHFLPk05EK6v3fjoJIR9AXE=; b=fy3aoVSpwgXrwvuWPVrID/wRU5DAyDrjgPET4pnQzlQkWUzL/6IHK75YRxiU9gB8UK eQMrqDymbyy58EHlQubtSZwd1rpkx919MmPUScKBpIJ4uzDACjv87qWFpE1Nzk393F6H /eAg4/6fMcxBQIZTUgoE/oKtnlFL/whOe8X55JU84NZaPsIr9UqKOm4MLzi4nW0yVoTA tcpAQO61px1Ub4W4ryNnzCmHd3fJCBj5wS11rLSjhHv1mscepcCAEeSweRoexjBHr55E JeVKlFq7i6IjC3hhpxU+u8vpjCwvNKy8TIPU5kyXY1G9xmiaBLOFdxgyEhd2GCcai9wJ 9mmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=d0NpqGl1oKuCDKK6YqMWlHFLPk05EK6v3fjoJIR9AXE=; b=BrYTGZJKo2CE/aoC4FfTCJlsC3posHCrmPdqAy7pcB3e6Ea6tsGUiDC/ZkS+5yzGXB thQx6hwKxeVWk9LSWdJsSScqK/Iqn5fEh/tlsShmlx//TQWj4thzmrB4K72TbixCsyGE F3QbHfj5AfCW8h8e+wIRy8rrk50LhOZo8fYX7kSGd3GloxSsuuMeOMXpN7gpAWH4y49t 95yhqtbl+RUaZmuL5Al3PDmOQ9fm7KQ6GRwIG1+DS2G9AEndFqZ4AeiNrNTlGdncibcB cCAE90i6xaVS0yQKTsww/4y/rZ2XkSJhMtZVoKFonYEgYfXVfbEDkMFLx7+SNGYWzIqT RcPQ== X-Gm-Message-State: AOAM530EE8XbSZ7sMih6gYYaGChGXSWg4IiaXdmFwd2Mm48XEjiFnCcY Rnge8m5Ex61QGAiwi3e/6MSqCg== X-Google-Smtp-Source: ABdhPJw8J7hshp/T+PkBbUWSdEGyBv+bsgA/yAvMw1/l87P9f/Wd4fOR8sTbzNaiX4sjBSIbLxAwgQ== X-Received: by 2002:a17:907:6d10:b0:6e8:8fbc:310c with SMTP id sa16-20020a1709076d1000b006e88fbc310cmr5455154ejc.530.1650199536410; Sun, 17 Apr 2022 05:45:36 -0700 (PDT) Received: from localhost.localdomain ([134.195.101.46]) by smtp.gmail.com with ESMTPSA id ee17-20020a056402291100b0041fe1e4e342sm5485527edb.27.2022.04.17.05.45.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Apr 2022 05:45:35 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Kajol Jain , Li Huafei , Ali Saidi , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan Subject: [PATCH] perf mem: Print memory operation type Date: Sun, 17 Apr 2022 20:45:24 +0800 Message-Id: <20220417124524.901148-1-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org The memory operation types are not only for load and store, for easier reviewing the memory operation type, this patch prints out it. Before: ls 14753 [011] 3678.072400: 1 l1d-miss: 88000182 L1 miss|SNP N/A|TLB Walker hit|LCK No|BLK N/A ffffa7c22b4b2a00 [unknown] ([kernel.kallsyms]) ls 14753 [011] 3678.072400: 1 l1d-access: 88000182 L1 miss|SNP N/A|TLB Walker hit|LCK No|BLK N/A ffffa7c22b4b2a00 [unknown] ([kernel.kallsyms]) ls 14753 [011] 3678.072400: 1 tlb-access: 88000182 L1 miss|SNP N/A|TLB Walker hit|LCK No|BLK N/A ffffa7c22b4b2a00 [unknown] ([kernel.kallsyms]) ls 14753 [011] 3678.072400: 1 memory: 88000182 L1 miss|SNP N/A|TLB Walker hit|LCK No|BLK N/A ffffa7c22b4b2a00 [unknown] ([kernel.kallsyms]) After: ls 14753 [011] 3678.072400: 1 l1d-miss: 88000182 |OP LOAD|LVL L1 miss|SNP N/A|TLB Walker hit|LCK No|BLK N/A ffffa7c22b4b2a00 [unknown] ([kernel.kallsyms]) ls 14753 [011] 3678.072400: 1 l1d-access: 88000182 |OP LOAD|LVL L1 miss|SNP N/A|TLB Walker hit|LCK No|BLK N/A ffffa7c22b4b2a00 [unknown] ([kernel.kallsyms]) ls 14753 [011] 3678.072400: 1 tlb-access: 88000182 |OP LOAD|LVL L1 miss|SNP N/A|TLB Walker hit|LCK No|BLK N/A ffffa7c22b4b2a00 [unknown] ([kernel.kallsyms]) ls 14753 [011] 3678.072400: 1 memory: 88000182 |OP LOAD|LVL L1 miss|SNP N/A|TLB Walker hit|LCK No|BLK N/A ffffa7c22b4b2a00 [unknown] ([kernel.kallsyms]) Signed-off-by: Leo Yan --- tools/perf/util/mem-events.c | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c index e5e405185498..f8f234251f92 100644 --- a/tools/perf/util/mem-events.c +++ b/tools/perf/util/mem-events.c @@ -314,6 +314,30 @@ static const char * const mem_hops[] = { "board", }; +static int perf_mem__op_scnprintf(char *out, size_t sz, struct mem_info *mem_info) +{ + u64 op = PERF_MEM_LOCK_NA; + int l; + + if (mem_info) + op = mem_info->data_src.mem_op; + + if (op & PERF_MEM_OP_NA) + l = scnprintf(out, sz, "N/A"); + else if (op & PERF_MEM_OP_LOAD) + l = scnprintf(out, sz, "LOAD"); + else if (op & PERF_MEM_OP_STORE) + l = scnprintf(out, sz, "STORE"); + else if (op & PERF_MEM_OP_PFETCH) + l = scnprintf(out, sz, "PFETCH"); + else if (op & PERF_MEM_OP_EXEC) + l = scnprintf(out, sz, "EXEC"); + else + l = scnprintf(out, sz, "No"); + + return l; +} + int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info) { size_t i, l = 0; @@ -466,7 +490,10 @@ int perf_script__meminfo_scnprintf(char *out, size_t sz, struct mem_info *mem_in { int i = 0; - i += perf_mem__lvl_scnprintf(out, sz, mem_info); + i += scnprintf(out, sz, "|OP "); + i += perf_mem__op_scnprintf(out + i, sz - i, mem_info); + i += scnprintf(out + i, sz - i, "|LVL "); + i += perf_mem__lvl_scnprintf(out + i, sz, mem_info); i += scnprintf(out + i, sz - i, "|SNP "); i += perf_mem__snp_scnprintf(out + i, sz - i, mem_info); i += scnprintf(out + i, sz - i, "|TLB "); -- 2.25.1